Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4525 - Support recommendations for non-string primitive features #4526

Merged
merged 1 commit into from
Feb 18, 2024
Merged

#4525 - Support recommendations for non-string primitive features #4526

merged 1 commit into from
Feb 18, 2024

Conversation

reckart
Copy link
Member

@reckart reckart commented Feb 18, 2024

What's in the PR

  • Boolean features now seem to work in String Matching recommender and Active Learning Sidebar

How to test manually

  • Try configuring a string matcher recommender for a boolean feature
  • Use the recommender normally and with active learning

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart
#4525 - Support recommendations for non-string primitive features
1c7c1a0 
- Boolean features now seem to work in String Matching recommender and Active Learning Sidebar
@reckart reckart added this to the 32.0 milestone Feb 18, 2024
@reckart reckart self-assigned this Feb 18, 2024
@reckart reckart merged commit 21a8bc4 into main Feb 18, 2024
2 checks passed
@reckart reckart deleted the feature/4525-Support-recommendations-for-non-string-primitive-features branch February 18, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: Recommender
Projects
Kanban
Archived in project
Milestone
32.0
Development

Successfully merging this pull request may close these issues.
1 participant
@reckart