Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No helpful error message when recommender is not called due to feature being disabled #4622

Closed
reckart opened this issue Mar 12, 2024 · 0 comments
Closed

No helpful error message when recommender is not called due to feature being disabled #4622

reckart opened this issue Mar 12, 2024 · 0 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Recommender
Milestone
31.3

Comments

@reckart
Copy link
Member

reckart commented Mar 12, 2024

Describe the bug
The recommender system will not trigger a training run on a recommender that applies to a disabled feature. While this is sensible, it is not good that there is no warning about this visible in the UI.

To Reproduce
Steps to reproduce the behavior:

  1. Create recommender that applies to a feature
  2. Disable that feature
  3. Try annotating something on the layer the recommender applies to
  4. Wonder why nothing happens (in particular no call to an external recommender is made)

Expected behavior
The log in the recommender sidebar should display a warning in such a case.

Please complete the following information:

  • Version and build ID: 31.2
@reckart reckart added 🐛Bug Something isn't working Module: Recommender labels Mar 12, 2024
@reckart reckart added this to the 31.3 milestone Mar 12, 2024
@reckart reckart self-assigned this Mar 12, 2024
reckart added a commit that referenced this issue Mar 12, 2024
@reckart
#4622 - No helpful error message when recommender is not called due t…
034117b 
…o feature being disabled

- Issue warnings in the log in cases where the user may be surprised that the recommender is not running or where the recommender may be misconfigured
reckart added a commit that referenced this issue Mar 12, 2024
@reckart
Merge pull request #4623 from inception-project/bugfix/4622-No-helpfu…
9cdcb3b 
…l-error-message-when-recommender-is-not-called-due-to-feature-being-disabled

#4622 - No helpful error message when recommender is not called due to feature being disabled
@reckart reckart closed this as completed Mar 12, 2024
reckart added a commit that referenced this issue Mar 12, 2024
@reckart
Merge branch 'release/31.x'
4a8bbd4 
* release/31.x:
  #4622 - No helpful error message when recommender is not called due to feature being disabled
reckart added a commit that referenced this issue Mar 12, 2024
@reckart
Merge branch 'main' into feature/1321-Importing-.ann-files-from-BRAT
5c522da 
* main:
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-31.3
  #4622 - No helpful error message when recommender is not called due to feature being disabled
  #4550 - Clean up code
reckart added a commit that referenced this issue Mar 17, 2024
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
fea0068 
* main:
  #1321 - Importing .ann files from BRAT
  #4614 - Display suggestions from Named Entity Linker immediately
  #4638 - Ability to filter annotation sidebar by covered text
  #4636 - Ability to collapse groups in annotation sidebar
  #4634 - Pull document file storage code out of document service into a new service
  #4550 - Clean up code
  #4625 - Azure AI Open AI recommender
  #4628 - Better results when using unlabelled annotations for few-shot learning
  #4550 - Clean up code
  #4625 - Azure AI Open AI recommender
  #1321 - Importing .ann files from BRAT
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-31.3
  #1321 - Importing .ann files from BRAT
  #4622 - No helpful error message when recommender is not called due to feature being disabled
  No issue: Better logging
  #4550 - Clean up code
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Recommender
Projects
Kanban
Archived in project
Milestone
31.3
Development

No branches or pull requests
1 participant
@reckart