Skip to content

Commit

Permalink
Merge pull request #4623 from inception-project/bugfix/4622-No-helpfu…
Browse files Browse the repository at this point in the history
…l-error-message-when-recommender-is-not-called-due-to-feature-being-disabled

#4622 - No helpful error message when recommender is not called due to feature being disabled
  • Loading branch information
reckart authored Mar 12, 2024
2 parents c2a7980 + 034117b commit 9cdcb3b
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,8 @@ private void logTrainingOverallEnd(long overallStartTime)

private void logUnsupportedRecommenderType(Recommender aRecommender)
{
warn("Recommender [%s] uses unsupported tool [%s] - skipping", aRecommender.getName(),
aRecommender.getTool());
LOG.warn("[{}][{}]: No factory found - skipping recommender",
getSessionOwner().getUsername(), aRecommender.getName());
}
Expand All @@ -270,18 +272,22 @@ private void logTrainingNotSupported(Recommender aRecommender)

private void logRecommenderDisabled(Recommender aRecommender)
{
LOG.debug("[{}][{}][{}]: Recommenderdisabled - skipping", getSessionOwner().getUsername(),
LOG.debug("[{}][{}][{}]: Recommender disabled - skipping", getSessionOwner().getUsername(),
getId(), aRecommender.getName());
}

private void logLayerDisabled(Recommender aRecommender)
{
warn("Recommender [%s] uses disabled layer [%s] disabled - skipping recommender.",
aRecommender.getName(), aRecommender.getLayer().getUiName());
LOG.debug("[{}][{}][{}]: Layer disabled - skipping", getSessionOwner().getUsername(),
getId(), aRecommender.getLayer().getUiName());
}

private void logFeatureDisabled(Recommender aRecommender)
{
warn("Recommender [%s] uses disabled feature [%s] - skipping recommender.",
aRecommender.getName(), aRecommender.getFeature().getUiName());
LOG.debug("[{}][{}][{}]: Feature disabled - skipping", getSessionOwner().getUsername(),
getId(), aRecommender.getFeature().getUiName());
}
Expand Down

0 comments on commit 9cdcb3b

Please sign in to comment.