depguard is enabled and fails on v1.53.0 #3862

adamdecaf · 2023-06-01T20:38:29Z

Welcome

Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
Yes, I've searched similar issues on GitHub and didn't find any.
Yes, I've included all information below (version, config, etc.).
Yes, I've tried with the standalone linter if available (e.g., gocritic, go vet, etc.). (https://golangci-lint.run/usage/linters/)

Description of the problem

Running v1.53.0 of golangci-lint seems to enable depguard and fails due to a config error.

Version of golangci-lint

$ golangci-lint --version

v1.53.0

Configuration file

Go environment

$ go version && go env

go version go1.20.4 darwin/amd64

Verbose output of running

$ golangci-lint cache clean
$ golangci-lint run -v

golangci/golangci-lint info checking GitHub for tag 'v1.53.0'
golangci/golangci-lint info found version: 1.53.0 for v1.53.0/darwin/amd64
golangci/golangci-lint info installed ./bin/golangci-lint
STARTING golangci-lint checks
ERRO [linter] depguard: create analyzer: couldn't expand $gostd: could not read GOROOT directory: open src: no such file or directory
must have an Allow and/or Deny package list

Code example or link to a public repository

Updating golangci-lint to v1.53.0 in https://github.com/moov-io/infra/blob/master/go/lint-project.sh

CI run: https://github.com/moov-io/infra/actions/runs/5149020788/jobs/9271486191

The text was updated successfully, but these errors were encountered:

gandarez · 2023-06-01T20:43:24Z

It's happening with latest version released v1.53.0.

gandarez · 2023-06-01T20:46:53Z

There's an open issue to track it but the maintainer hasn't replied yet OpenPeeDeeP/depguard#46

adamdecaf · 2023-06-01T20:48:11Z

Does the upgrade to v2 need to be reverted? #3795

ldez · 2023-06-01T20:52:49Z

The configuration has changed and it's expected.

#3727

We will not revert the upgrade.

gandarez · 2023-06-01T20:57:31Z

It bumped from v1.52.2 to v1.53.0 so no major change was implicitly made. It's breaking for everyone who was using previous version and you assumed that's expected?? How to fix it without reverting the upgrade?

note: I have no depguard enabled on my side.

ldez · 2023-06-01T20:59:06Z

It bumped from v1.52.2 to v1.53.0 so no major change was implicitly made

We follow semver but we cannot follow the major version of each linter, then changes inside linter configuration are not considered as breaking.

ldez · 2023-06-01T20:59:15Z

I will try to reproduce the problem locally and find a fix.

ldez · 2023-06-01T21:01:00Z

Can you provide the output of go env?

jhheider · 2023-06-01T21:01:06Z

It fails something as simple as a golangci-lint help linters in an empty directory, where this was a working behavior in the previous version:

https://github.com/teaxyz/pantry/actions/runs/5148610773/jobs/9271272674

adamdecaf · 2023-06-01T21:03:08Z

I don't have depguard enabled either.

ldez · 2023-06-01T21:03:52Z

I need a reproducible context, then I need information.

$ golangci-lint version

$ go env

$ cat .golangci.yml

And a public repo.

adamdecaf · 2023-06-01T21:05:16Z

v1.53.0 of golangci-lint fails locally for me inside a Go project. There's no golangci.yml file in the project.

$ ./bin/golangci-lint version
ERRO [linter] depguard: create analyzer: couldn't expand $gostd: could not read GOROOT directory: open src: no such file or directory
must have an Allow and/or Deny package list

ldez · 2023-06-01T21:05:34Z

I need a reproducible context, then I need information.

$ golangci-lint version

$ go env

$ cat .golangci.yml

And a public repo.

jhheider · 2023-06-01T21:05:38Z

$ mkdir foo
$ cd foo
$ golangci-lint version
ERRO [linter] depguard: create analyzer: couldn't expand $gostd: could not read GOROOT directory: open src: no such file or directory
must have an Allow and/or Deny package list
$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/jacob/Library/Caches/go-build"
GOENV="/Users/jacob/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/jacob/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/jacob/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/jacob/.tea/go.dev/v1.20.4"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/jacob/.tea/go.dev/v1.20.4/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.20.4"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/t5/180fzzln0k7_0cgpzmkx2_w80000gn/T/go-build2213119517=/tmp/go-build -gno-record-gcc-switches -fno-common"
$ cat .golangci.yml
cat: .golangci.yml: No such file or directory

edited to add:

even just version has stopped working. Simplest quick test:

$ tea +golangci-lint.run=1.52.2 golangci-lint version
installed: ~/.tea/golangci-lint.run/v1.52.2
golangci-lint has version 1.52.2 built with go1.20.2 from da04413a on 2023-03-25T18:11:28Z
$ tea +golangci-lint.run=1.53.0 golangci-lint version
ERRO [linter] depguard: create analyzer: couldn't expand $gostd: could not read GOROOT directory: open src: no such file or directory
must have an Allow and/or Deny package list

ldez · 2023-06-01T21:12:45Z

I think I know the root of the problem: https://github.com/OpenPeeDeeP/depguard/blob/84475ef6d579f85ae86343f549bd9c267d3b7993/internal/utils/variables.go#L48

The use of build.Default.GOROOT cannot work because it's the GOROOT of the build.

ldez · 2023-06-01T21:18:40Z

I'm working on a fix, give me some time.

JohnRoesler · 2023-06-01T21:19:27Z

Thank you @ldez if you need an example on a public repo - I've got it failing here https://github.com/go-co-op/gocron/actions/runs/5149340859/jobs/9272212188

adamdecaf · 2023-06-01T21:25:04Z

I have a public repo which has the failure as well moov-io/infra#271

ldez · 2023-06-01T21:29:46Z

I am still not able to reproduce it locally.

I created a simple app just to display build.Default.GOROOT and use 2 different GOROOT (one for the build, one for the run) and it works (I'm surprised but it works).

package main

import (
	"fmt"
	"go/build"
)

func main() {
	fmt.Println(build.Default.GOROOT)
}

$ ./sandbox
/usr/lib/go

$ ./sandbox 
/home/ldez/.gvm/gos/go1.20.4

$ GOROOT=fofo ./sandbox                                                                                                              
fofo
2023/06/02 00:01:38 open fofo: no such file or directory

ldez · 2023-06-01T21:39:58Z

What I'm sure about:

ERRO [linter] depguard: create analyzer: couldn't expand $gostd: could not read GOROOT directory: open src: no such file or directory

the message open src: no such file or directory means that the directory based on GOROOT is src.

This directory (src) is not related to your GOROOT (GOROOT="/Users/jacob/.tea/go.dev/v1.20.4")

And 2 users have the same error message with this directory (src).

Based on jobs/9271272674 it fails on all OS.

jobs/9272212188 and jobs/9271486191 failed on liunx amd64.

adamdecaf · 2023-06-01T21:41:16Z

I'm on macOS right now and Go is installed via homebrew.

go env | grep ROOT
GOROOT="/usr/local/Cellar/go/1.20.4/libexec"

ldez · 2023-06-01T21:45:43Z

$ golangci-lint version              
golangci-lint has version 1.53.0 built with go1.20.4 from 9f2528a3 on 2023-06-01T19:43:45Z

$ git clone [email protected]:moov-io/infra.git  
Cloning into 'infra'...
remote: Enumerating objects: 9277, done.
remote: Counting objects: 100% (96/96), done.
remote: Compressing objects: 100% (60/60), done.
remote: Total 9277 (delta 42), reused 86 (delta 36), pack-reused 9181
Receiving objects: 100% (9277/9277), 3.93 MiB | 1.45 MiB/s, done.
Resolving deltas: 100% (5751/5751), done.
$ cd infra      
$ golangci-lint run  
$

$ git clone [email protected]:go-co-op/gocron.git                  
Cloning into 'gocron'...
remote: Enumerating objects: 1746, done.
remote: Counting objects: 100% (314/314), done.
remote: Compressing objects: 100% (161/161), done.
remote: Total 1746 (delta 218), reused 234 (delta 149), pack-reused 1432
Receiving objects: 100% (1746/1746), 592.91 KiB | 1.54 MiB/s, done.
Resolving deltas: 100% (1158/1158), done.
$ cd gocron
$ golangci-lint run
scheduler.go:1178:11: superfluous-else: if block ends with a break statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
} else {
repeatMap[dayOfMonth]++
}
scheduler_test.go:26:24: unused-parameter: parameter 'i' seems to be unused, consider removing or renaming it as _ (revive)
func (f fakeTime) Unix(i int64, i2 int64) time.Time {
^
scheduler_test.go:2356:54: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
func TestScheduler_CheckSetBehaviourBeforeJobCreated(t *testing.T) {
^
$

I'm on Linux amd64.

ldez · 2023-06-01T22:04:30Z

can someone try this command:

GOROOT=<YOUR REAL GOROOT> golangci-lint version

adamdecaf · 2023-06-01T22:08:07Z

I can reproduce this with the following Dockerfile.

FROM golang:1.20

RUN wget https://github.com/golangci/golangci-lint/releases/download/v1.53.0/golangci-lint-1.53.0-linux-amd64.tar.gz
RUN tar xf golangci-lint-1.53.0-linux-amd64.tar.gz

RUN go env
RUN /go/golangci-lint-1.53.0-linux-amd64/golangci-lint version

Building that fails with the following.

 => ERROR [5/5] RUN /go/golangci-lint-1.53.0-linux-amd64/golangci-lint version                                                         0.5s 
------                                                                                                                                      
 > [5/5] RUN /go/golangci-lint-1.53.0-linux-amd64/golangci-lint version:                                                                    
#0 0.468 level=error msg="[linter] depguard: create analyzer: must have an Allow and/or Deny package list"                                  
------
Dockerfile:8
--------------------
   6 |     RUN go env
   7 |     
   8 | >>> RUN /go/golangci-lint-1.53.0-linux-amd64/golangci-lint version
   9 |     
  10 |     # WORKDIR /go/src/
--------------------
ERROR: failed to solve: process "/bin/sh -c /go/golangci-lint-1.53.0-linux-amd64/golangci-lint version" did not complete successfully: exit code: 3

Edit: If I setup a new GOROOT which matches the v1.53.0 builder release path the issue goes away, so it does appear to be a mismatch of the build's GOROOT and the runtime GOROOT.

Add the following steps to the Dockerfile allows docker build -t golangci-issue . to complete.

RUN mkdir -p /opt/hostedtoolcache/go/1.20.4/x64
RUN ln -s /usr/local/go/* /opt/hostedtoolcache/go/1.20.4/x64/
ENV GOROOT=/opt/hostedtoolcache/go/1.20.4/x64/

Jumping into the completed Docker image shows a working GOROOT.

docker run -it --entrypoint /bin/bash golangci-issue 
root@bb48f4e764af:/go# go env | grep ROOT
GOROOT="/opt/hostedtoolcache/go/1.20.4/x64"

ldez · 2023-06-01T22:12:53Z

Thank you, I can reproduce it now.

$ docker run --rm -it golang:1.20-alpine sh                                                                  
/go # wget https://github.com/golangci/golangci-lint/releases/download/v1.53.0/golangci-lint-1.53.0-linux-amd64.tar.gz
Connecting to github.com (140.82.121.4:443)
Connecting to objects.githubusercontent.com (185.199.109.133:443)
saving to 'golangci-lint-1.53.0-linux-amd64.tar.gz'
golangci-lint-1.53.0 100% |********************************************************************************************************************************************************************************************| 9760k  0:00:00 ETA
'golangci-lint-1.53.0-linux-amd64.tar.gz' saved
/go # tar xf golangci-lint-1.53.0-linux-amd64.tar.gz
/go # go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.20.4"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="0"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3482902365=/tmp/go-build -gno-record-gcc-switches"
/go # /go/golangci-lint-1.53.0-linux-amd64/golangci-lint version
ERRO [linter] depguard: create analyzer: must have an Allow and/or Deny package list 
/go # GOROOT=$(go env GOROOT) /go/golangci-lint-1.53.0-linux-amd64/golangci-lint version
golangci-lint has version 1.53.0 built with go1.20.4 from 9f2528a3 on 2023-06-01T19:43:45Z

If I set the GOROOT explicitly it works 🤔

ldez · 2023-06-01T22:15:43Z

More information: the problem appears even if you don't use depguard because it is related to a global variable.

Another example of why I hate global variables 😢

See golangci/golangci-lint#3862 Signed-off-by: Marc 'risson' Schmitt <[email protected]>

relates to golangci/golangci-lint#3862

See golangci/golangci-lint#3862 Signed-off-by: Marc 'risson' Schmitt <[email protected]>

JohnRoesler · 2023-06-02T13:26:51Z

Thanks for the quick resolution folks! 👏

See golangci/golangci-lint#3862 Signed-off-by: Marc 'risson' Schmitt <[email protected]>

deitch · 2024-06-07T08:33:36Z

I know this is a year old, but picking it up now.

If I understand correctly, after this fix, if you do not have depguard enabled, everything should work. And, indeed, running golangci-lint run ./... --disable depguard works.

If you use depguard it remains broken? I had thought depguard was now built in with a fix in a fork based on this comment, and so it should be fixed for depguard-enabled as well? Or is that fork just to fix the "breaks everything else even if not enabled"?

ldez · 2024-06-07T11:21:23Z

depguard has been updated since that issue.

We don't use a fork now and you don't need to disable it.

You should update your configuration: https://golangci-lint.run/usage/linters/#depguard

deitch · 2024-06-07T11:22:47Z

Thanks @ldez .

adamdecaf added the bug Something isn't working label Jun 1, 2023

ldez added question Further information is requested and removed bug Something isn't working labels Jun 1, 2023

jhheider mentioned this issue Jun 1, 2023

❌ build issues: golangci-lint.run=1.53.0 pkgxdev/pantry#2104

Closed

liaodaniel mentioned this issue Jun 2, 2023

Implement rulesets google/go-github#2795

Merged

rissson added a commit to goauthentik/authentik that referenced this issue Jun 2, 2023

ci: outpost: use golangci-lint v1.52.2

8d5c786

See golangci/golangci-lint#3862 Signed-off-by: Marc 'risson' Schmitt <[email protected]>

JanDeDobbeleer added a commit to JanDeDobbeleer/oh-my-posh that referenced this issue Jun 2, 2023

chore: pin golangci-lint to v1.52.2

e380c9d

relates to golangci/golangci-lint#3862

JanDeDobbeleer mentioned this issue Jun 2, 2023

chore: pin golangci-lint to v1.52.2 JanDeDobbeleer/oh-my-posh#3930

Merged

JanDeDobbeleer added a commit to JanDeDobbeleer/oh-my-posh that referenced this issue Jun 2, 2023

chore: pin golangci-lint to v1.52.2

5cf524f

relates to golangci/golangci-lint#3862

rissson added a commit to goauthentik/authentik that referenced this issue Jun 2, 2023

ci: outpost: use golangci-lint v1.52.2

dc0ba8b

See golangci/golangci-lint#3862 Signed-off-by: Marc 'risson' Schmitt <[email protected]>

Szzrain mentioned this issue Jun 2, 2023

chore: 移除kook/discord平台的代码块包裹 sealdice/sealdice-core#111

Merged

tnevrlka mentioned this issue Jun 2, 2023

fix: expiration not getting set konflux-ci/build-service#162

Merged

ldez closed this as completed in #3866 Jun 2, 2023

This was referenced Jun 2, 2023

Github Actions lint failures on 1.53.0 golangci/golangci-lint-action#761

Closed

Issue running golangci-lint 1.53 via the action golangci/golangci-lint-action#760

Closed

rogercoll mentioned this issue Jun 2, 2023

chore: disable cgo newrelic/nri-jmx#116

Merged

This was referenced Jun 2, 2023

goland latest plugin error #3870

Closed

depguard: create analyzer: couldn't expand $gostd #3871

Closed

WeiJun0827 mentioned this issue Jun 2, 2023

✨ /owner supports exclude_iscn_owner qs likecoin/likecoin-chain-tx-indexer#110

Merged

andig mentioned this issue Jun 2, 2023

Easee: fix potential deadlock in product update handling evcc-io/evcc#8267

Merged

rissson added a commit to goauthentik/authentik that referenced this issue Jun 2, 2023

ci: outpost: use golangci-lint v1.52.2

00620b7

See golangci/golangci-lint#3862 Signed-off-by: Marc 'risson' Schmitt <[email protected]>

This was referenced Jun 2, 2023

golangci-lint run error due to depguard #3876

Closed

binary download, golangci-lint fails to run even a simple --version. #3878

Closed

rissson added a commit to goauthentik/authentik that referenced this issue Jun 2, 2023

ci: outpost: use golangci-lint v1.52.2

afa8a50

See golangci/golangci-lint#3862 Signed-off-by: Marc 'risson' Schmitt <[email protected]>

ramsayleung mentioned this issue Jun 2, 2023

Add ISSUE and PULL REQUEST template deb-sig/double-entry-generator#104

Merged

4 tasks

et mentioned this issue Jun 2, 2023

unpin golangci-lint version highlight/highlight#5527

Draft

atc0005 mentioned this issue Jun 5, 2023

New version of depguard linter included in golangci-lint v1.53.0 and newer fails when run without explicit configuration atc0005/go-ci#1024

Closed

ldez mentioned this issue Jun 5, 2023

depguard: migrate to v2 #3795

Merged

jtraxy mentioned this issue Jun 9, 2023

Go lint workflow issue portainer/portainer#9057

Closed

jonjohnsonjr mentioned this issue Jul 8, 2023

Bump go-apk chainguard-dev/apko#795

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

depguard is enabled and fails on v1.53.0 #3862

depguard is enabled and fails on v1.53.0 #3862

adamdecaf commented Jun 1, 2023 •

edited

Loading

gandarez commented Jun 1, 2023

gandarez commented Jun 1, 2023

adamdecaf commented Jun 1, 2023

ldez commented Jun 1, 2023 •

edited

Loading

gandarez commented Jun 1, 2023 •

edited

Loading

ldez commented Jun 1, 2023

ldez commented Jun 1, 2023

ldez commented Jun 1, 2023 •

edited

Loading

jhheider commented Jun 1, 2023

adamdecaf commented Jun 1, 2023

ldez commented Jun 1, 2023 •

edited

Loading

adamdecaf commented Jun 1, 2023

ldez commented Jun 1, 2023

jhheider commented Jun 1, 2023 •

edited by ldez

Loading

ldez commented Jun 1, 2023 •

edited

Loading

ldez commented Jun 1, 2023

JohnRoesler commented Jun 1, 2023

adamdecaf commented Jun 1, 2023

ldez commented Jun 1, 2023 •

edited

Loading

ldez commented Jun 1, 2023 •

edited

Loading

adamdecaf commented Jun 1, 2023

ldez commented Jun 1, 2023 •

edited

Loading

ldez commented Jun 1, 2023 •

edited

Loading

adamdecaf commented Jun 1, 2023 •

edited

Loading

ldez commented Jun 1, 2023

ldez commented Jun 1, 2023 •

edited

Loading

JohnRoesler commented Jun 2, 2023

deitch commented Jun 7, 2024

ldez commented Jun 7, 2024 •

edited

Loading

deitch commented Jun 7, 2024

depguard is enabled and fails on v1.53.0 #3862

depguard is enabled and fails on v1.53.0 #3862

Comments

adamdecaf commented Jun 1, 2023 • edited Loading

Welcome

Description of the problem

Version of golangci-lint

Configuration file

Go environment

Verbose output of running

Code example or link to a public repository

gandarez commented Jun 1, 2023

gandarez commented Jun 1, 2023

adamdecaf commented Jun 1, 2023

ldez commented Jun 1, 2023 • edited Loading

gandarez commented Jun 1, 2023 • edited Loading

ldez commented Jun 1, 2023

ldez commented Jun 1, 2023

ldez commented Jun 1, 2023 • edited Loading

jhheider commented Jun 1, 2023

adamdecaf commented Jun 1, 2023

ldez commented Jun 1, 2023 • edited Loading

adamdecaf commented Jun 1, 2023

ldez commented Jun 1, 2023

jhheider commented Jun 1, 2023 • edited by ldez Loading

ldez commented Jun 1, 2023 • edited Loading

ldez commented Jun 1, 2023

JohnRoesler commented Jun 1, 2023

adamdecaf commented Jun 1, 2023

ldez commented Jun 1, 2023 • edited Loading

ldez commented Jun 1, 2023 • edited Loading

adamdecaf commented Jun 1, 2023

ldez commented Jun 1, 2023 • edited Loading

ldez commented Jun 1, 2023 • edited Loading

adamdecaf commented Jun 1, 2023 • edited Loading

ldez commented Jun 1, 2023

ldez commented Jun 1, 2023 • edited Loading

JohnRoesler commented Jun 2, 2023

deitch commented Jun 7, 2024

ldez commented Jun 7, 2024 • edited Loading

deitch commented Jun 7, 2024

adamdecaf commented Jun 1, 2023 •

edited

Loading

ldez commented Jun 1, 2023 •

edited

Loading

gandarez commented Jun 1, 2023 •

edited

Loading

ldez commented Jun 1, 2023 •

edited

Loading

ldez commented Jun 1, 2023 •

edited

Loading

jhheider commented Jun 1, 2023 •

edited by ldez

Loading

ldez commented Jun 1, 2023 •

edited

Loading

ldez commented Jun 1, 2023 •

edited

Loading

ldez commented Jun 1, 2023 •

edited

Loading

ldez commented Jun 1, 2023 •

edited

Loading

ldez commented Jun 1, 2023 •

edited

Loading

adamdecaf commented Jun 1, 2023 •

edited

Loading

ldez commented Jun 1, 2023 •

edited

Loading

ldez commented Jun 7, 2024 •

edited

Loading