Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expiration not getting set #162

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

tnevrlka
Copy link
Contributor

@tnevrlka tnevrlka commented Jun 2, 2023

STONEBLD-1341

expiration did not get set if the environment variable was set

@tnevrlka tnevrlka requested review from mmorhun and Michkov and removed request for mmorhun June 2, 2023 07:42
@openshift-ci openshift-ci bot requested review from mmorhun and psturc June 2, 2023 07:42
@tnevrlka tnevrlka removed the request for review from psturc June 2, 2023 07:42
@tnevrlka
Copy link
Contributor Author

tnevrlka commented Jun 2, 2023

Seems to be affected by golangci/golangci-lint#3862? Lint passes using golangci-lint 1.52.2 on my machine

@Michkov Michkov merged commit 4f438bd into konflux-ci:main Jun 2, 2023
@tnevrlka tnevrlka deleted the empty-expiration branch June 21, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants