Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go-apk #795

Merged
merged 4 commits into from
Jul 8, 2023
Merged

Bump go-apk #795

merged 4 commits into from
Jul 8, 2023

Conversation

jonjohnsonjr
Copy link
Contributor

No description provided.

@jonjohnsonjr
Bump go-apk
b836fae 
Signed-off-by: Jon Johnson <[email protected]>
@jonjohnsonjr jonjohnsonjr requested a review from a team as a code owner July 8, 2023 22:32
@jonjohnsonjr jonjohnsonjr requested review from kaniini and removed request for a team July 8, 2023 22:32
@jonjohnsonjr
Bump go to 1.20
9526601 
Signed-off-by: Jon Johnson <[email protected]>
@jonjohnsonjr
Copy link
Contributor Author

I used errors.Join like a fool, so I had to bump to 1.20, which seems fine to me but I'm open to pushback.

@kaniini
Copy link
Contributor

kaniini commented Jul 8, 2023

Looks fine but the tests are failing in CI.

@jonjohnsonjr
Fix race
fd49498 
Signed-off-by: Jon Johnson <[email protected]>
@jonjohnsonjr
Copy link
Contributor Author

Looks fine but the tests are failing in CI.

Exposed a race, fixed.

@kaniini kaniini enabled auto-merge July 8, 2023 22:42
@jonjohnsonjr
Copy link
Contributor Author

Linter is failing to install itself, hoping to fix that by just bumping to the latest version of that.

@jonjohnsonjr
Copy link
Contributor Author

jonjohnsonjr commented Jul 8, 2023 •
edited
Loading 

run golangci-lint
  Running [/home/runner/golangci-lint-1.53.3-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: import 'github.com/go-git/go-git/v5' is not allowed from list 'Main' (depguard)

These are dark times.

Edit: Culprit is golangci/golangci-lint#3862, downgrading.

@jonjohnsonjr
Bump lint
d837990 
Signed-off-by: Jon Johnson <[email protected]>
@kaniini kaniini merged commit 6e6ea4a into chainguard-dev:main Jul 8, 2023
@jonjohnsonjr
Copy link
Contributor Author

Hallelujah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaniini kaniini kaniini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonjohnsonjr @kaniini