Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version of depguard linter included in golangci-lint v1.53.0 and newer fails when run without explicit configuration #1024

Closed
atc0005 opened this issue Jun 5, 2023 · 0 comments · Fixed by #1025
Closed

New version of depguard linter included in golangci-lint v1.53.0 and newer fails when run without explicit configuration #1024

atc0005 opened this issue Jun 5, 2023 · 0 comments · Fixed by #1025
Assignees
@atc0005
Labels
bug Something isn't working CI linting oldstable stable unstable
Milestone
v0.10.6

Comments

@atc0005
Copy link
Owner

atc0005 commented Jun 5, 2023 •
edited
Loading

Overview

v2 of the depguard linter changes the default behavior of the linter. Now, when enabled in the golangci-lint configuration but without an explicitly defined settings block the linter will emit errors like these:

internal\config\config.go:18:2: import 'github.com/rs/zerolog' is not allowed from list 'Main' (depguard)
        "github.com/rs/zerolog"
        ^
internal\config\getters.go:13:2: import 'github.com/atc0005/go-nagios' is not allowed from list 'Main' (depguard)
        "github.com/atc0005/go-nagios"
        ^
internal\config\logging.go:14:2: import 'github.com/rs/zerolog' is not allowed from list 'Main' (depguard)
        "github.com/rs/zerolog"
        ^

This fails any CI runs which execute golangci-lint using current configurations.

Current settings

go-ci/oldstable/combined/.golangci.yml

Lines 26 to 28 in 5180a0c

linters:
enable:
- depguard

go-ci/stable/combined/.golangci.yml

Lines 26 to 28 in 5180a0c

linters:
enable:
- depguard

go-ci/unstable/combined/.golangci.yml

Lines 33 to 35 in 5180a0c

linters:
enable:
- depguard

References
@atc0005 atc0005 added this to the v0.10.6 milestone Jun 5, 2023
@atc0005 atc0005 self-assigned this Jun 5, 2023
atc0005 added a commit that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
95f2731 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define
"global" permit/deny lists for any projects using images from
this project.

refs GH-1024
@atc0005 atc0005 mentioned this issue Jun 5, 2023
Merged
atc0005 added a commit to atc0005/elbow that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
9cfd84a 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
@atc0005 atc0005 mentioned this issue Jun 5, 2023
Merged
atc0005 added a commit to atc0005/bounce that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
99dc221 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
@atc0005 atc0005 mentioned this issue Jun 5, 2023
Merged
atc0005 added a commit to atc0005/brick that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
e7c80b6 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
@atc0005 atc0005 mentioned this issue Jun 5, 2023
Merged
atc0005 added a commit to atc0005/bridge that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
30520d8 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
@atc0005 atc0005 mentioned this issue Jun 5, 2023
Merged
atc0005 added a commit to atc0005/check-cert that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
dbf79da 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
@atc0005 atc0005 mentioned this issue Jun 5, 2023
Merged
atc0005 added a commit to atc0005/check-illiad that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
35436ae 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
atc0005 added a commit to atc0005/check-mail that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
6e14971 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
This was referenced Jun 5, 2023
Merged
Merged
atc0005 added a commit to atc0005/check-ntpt that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
81eecac 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
@atc0005 atc0005 mentioned this issue Jun 5, 2023
Merged
atc0005 added a commit to atc0005/check-path that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
bfda878 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
@atc0005 atc0005 mentioned this issue Jun 5, 2023
Merged
atc0005 added a commit to atc0005/check-process that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
20a31a4 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
@atc0005 atc0005 mentioned this issue Jun 5, 2023
Merged
atc0005 added a commit to atc0005/check-restart that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
561a694 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
@atc0005 atc0005 mentioned this issue Jun 5, 2023
Merged
atc0005 added a commit to atc0005/check-statuspage that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
56d25fc 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
atc0005 added a commit to atc0005/check-vmware that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
21d2d2c 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
This was referenced Jun 5, 2023
Merged
Merged
atc0005 added a commit to atc0005/check-whois that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
1a8bfa9 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
atc0005 added a commit to atc0005/dnsc that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
c7f7c48 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
This was referenced Jun 5, 2023
Merged
Merged
atc0005 added a commit to atc0005/go-ezproxy that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
8fd9c17 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
atc0005 added a commit to atc0005/go-lockss that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
d548ad9 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
This was referenced Jun 5, 2023
Merged
Merged
atc0005 added a commit to atc0005/mysql2sqlite that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
45df1f9 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
@atc0005 atc0005 mentioned this issue Jun 5, 2023
Merged
atc0005 added a commit to atc0005/go-nagios that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
e1e6f61 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
@atc0005 atc0005 mentioned this issue Jun 5, 2023
Merged
atc0005 added a commit to atc0005/nagios-debug that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
382fe6c 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
@atc0005 atc0005 mentioned this issue Jun 5, 2023
Merged
atc0005 added a commit to atc0005/query-meta that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
50a20be 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
@atc0005 atc0005 mentioned this issue Jun 5, 2023
Merged
atc0005 added a commit to atc0005/safelinks that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
48c70b0 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
atc0005 added a commit to atc0005/send2teams that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
45136c5 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
This was referenced Jun 5, 2023
Merged
Merged
atc0005 added a commit to atc0005/tsm-pass that referenced this issue Jun 5, 2023
@atc0005
Disable depguard linter
90af989 
By having v2 of the linter enabled without an explicitly
defined configuration the linter assumes that *no* non-stdlib
packages are permitted.

We disable the linter because we do not have any need to define permit/deny
lists for packages used by this project at this time.

refs atc0005/go-ci#1024
@atc0005 atc0005 mentioned this issue Jun 5, 2023
Merged
@dianadevasia dianadevasia mentioned this issue Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
bug Something isn't working CI linting oldstable stable unstable
Projects
None yet
Milestone
v0.10.6
Development

Successfully merging a pull request may close this issue.

Disable depguard linter atc0005/go-ci
1 participant
@atc0005