Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easee: fix potential deadlock in product update handling #8267

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Easee: fix potential deadlock in product update handling #8267

merged 2 commits into from
Jun 2, 2023

Conversation

andig
Copy link
Member

@andig andig commented Jun 2, 2023 •
edited
Loading

Refs #8009

This PR:

  • replaces hard to use sync.Cond with once/chan
  • moves logging outside the lock (we might further put logging into go routing)
  • doesn't re-update charger current on mismatch; should already be handled by returning error in charger.MaxCurrent

@andig andig added the bug Something isn't working label Jun 2, 2023
@andig andig requested a review from naltatis June 2, 2023 10:05
@andig
Copy link
Member Author

andig commented Jun 2, 2023

Der lint Fehler ist golangci/golangci-lint#3862 und kann ignoriert werden.

@andig andig changed the title Easee: fix deadlock in product update handling Easee: fix potential deadlock in product update handling Jun 2, 2023
@naltatis
Copy link
Member

naltatis commented Jun 2, 2023

evcc charger zeigt mir hier unvollständige Daten an weil nicht mehr lange genug gewartet wird.

@naltatis
Copy link
Member

naltatis commented Jun 2, 2023

Gerade lokal getestet. Sieht gut aus. Start/Stop/Switch läuft wie erwartet.

@andig andig merged commit 0be5db6 into master Jun 2, 2023
@andig andig deleted the fix/easee branch June 2, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naltatis naltatis naltatis approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andig @naltatis