Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin GolangCI #1757

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Pin GolangCI #1757

merged 2 commits into from
Jun 2, 2023

Conversation

tisnik
Copy link
Collaborator

@tisnik tisnik commented Jun 2, 2023

Description

Fixes golangci/golangci-lint#3862

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Configuration update

Testing steps

Done on CI

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (6cf0f4f) 74.14% compared to head (569c6a2) 74.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1757      +/-   ##
==========================================
+ Coverage   74.14%   74.18%   +0.04%     
==========================================
  Files          63       63              
  Lines        4437     4444       +7     
==========================================
+ Hits         3290     3297       +7     
  Misses        841      841              
  Partials      306      306              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tisnik tisnik merged commit 081dd45 into RedHatInsights:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

depguard is enabled and fails on v1.53.0
4 participants