-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor env:unlink, add tests #2591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2024
Size Change: +24 B (0%) Total Size: 52.9 MB
|
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split
branch
from
September 20, 2024 11:33
246eb9b
to
262e746
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split
branch
from
September 20, 2024 11:33
79de10b
to
0dd6b91
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split
branch
from
September 20, 2024 15:46
0dd6b91
to
34beb40
Compare
khamilowicz
changed the base branch from
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split
to
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split
September 20, 2024 15:46
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split
branch
from
September 20, 2024 16:11
6957021
to
c569276
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split
branch
2 times, most recently
from
September 20, 2024 16:54
06efc07
to
c43b7ad
Compare
khamilowicz
changed the base branch from
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split
to
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split
September 20, 2024 16:54
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split
branch
from
September 20, 2024 17:03
9964d64
to
42912f8
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split
branch
from
September 20, 2024 17:03
c43b7ad
to
0ae58aa
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split
branch
from
September 20, 2024 17:16
42912f8
to
6192048
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split
branch
from
September 20, 2024 17:16
0ae58aa
to
2027093
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split
branch
from
September 20, 2024 17:27
6192048
to
0a0bb79
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split
branch
from
September 20, 2024 17:27
2027093
to
39968b8
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split
branch
from
September 23, 2024 10:37
fac3a94
to
05787b7
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split
branch
from
September 23, 2024 13:01
271cadd
to
8ae5123
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split
branch
from
September 23, 2024 13:02
05787b7
to
c897214
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split
branch
from
September 23, 2024 13:20
8ae5123
to
8f68213
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split
branch
from
September 23, 2024 13:20
c897214
to
f310668
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split
branch
from
September 24, 2024 10:16
8f68213
to
1e12954
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split
branch
from
September 24, 2024 10:17
f310668
to
9c42e37
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split
branch
from
September 24, 2024 11:06
1e12954
to
7af9c14
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split
branch
from
September 24, 2024 11:06
9c42e37
to
4b8bdb7
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split
branch
from
September 24, 2024 11:14
7af9c14
to
078821d
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split
branch
from
September 24, 2024 11:14
4b8bdb7
to
673e296
Compare
szdziedzic
approved these changes
Sep 27, 2024
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split
branch
from
September 27, 2024 10:18
078821d
to
1fd4a89
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split
branch
from
September 27, 2024 10:18
673e296
to
2c88996
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split
branch
from
September 27, 2024 10:30
1fd4a89
to
eaf0256
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split
branch
2 times, most recently
from
September 27, 2024 10:43
f764418
to
5cf60fc
Compare
Merge activity
|
khamilowicz
changed the base branch from
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split
to
graphite-base/2591
October 1, 2024 08:58
khamilowicz
force-pushed
the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split
branch
from
October 1, 2024 09:01
5cf60fc
to
f36d44f
Compare
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
|
khamilowicz
deleted the
piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split
branch
October 1, 2024 09:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
ENG-13525: Update EAS-CLI for new EnvVar features
Update command to use multiple environments, polish the interface.
How
variable-name
andvariable-environment
to select the variablemultiselect
and multipleenvironment
parameters to allow unlinking multiple envsAll commands that were using name parameter to identify a single variable will use variable-name and variable-environment instead. This change will enable user to distinguish between name and environment that is identifying variable that is acted upon, and name and environment that is a parameter for command.
For example, when the user wants to update variable TEST that has environment production and change its name and change its environment, they can use:
eas env:update --variable-name TEST --variable-environment production --name TEST-update --environment production --environment preview
Test Plan
Added tests