Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor env:unlink, add tests #2591

Conversation

khamilowicz
Copy link
Contributor

@khamilowicz khamilowicz commented Sep 20, 2024

Why

ENG-13525: Update EAS-CLI for new EnvVar features

Update command to use multiple environments, polish the interface.

How

  • use variable-name and variable-environment to select the variable
  • Use multiselect and multiple environment parameters to allow unlinking multiple envs

All commands that were using name parameter to identify a single variable will use variable-name and variable-environment instead. This change will enable user to distinguish between name and environment that is identifying variable that is acted upon, and name and environment that is a parameter for command.

For example, when the user wants to update variable TEST that has environment production and change its name and change its environment, they can use:

eas env:update --variable-name TEST --variable-environment production --name TEST-update --environment production --environment preview

Test Plan

Added tests

Copy link

linear bot commented Sep 20, 2024

This was referenced Sep 20, 2024
Copy link

github-actions bot commented Sep 20, 2024

Size Change: +24 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +24 B (0%)

compressed-size-action

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split branch from 246eb9b to 262e746 Compare September 20, 2024 11:33
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split branch from 79de10b to 0dd6b91 Compare September 20, 2024 11:33
@khamilowicz khamilowicz reopened this Sep 20, 2024
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split branch from 0dd6b91 to 34beb40 Compare September 20, 2024 15:46
@khamilowicz khamilowicz changed the base branch from piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split to piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split September 20, 2024 15:46
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split branch from 6957021 to c569276 Compare September 20, 2024 16:11
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split branch 2 times, most recently from 06efc07 to c43b7ad Compare September 20, 2024 16:54
@khamilowicz khamilowicz changed the base branch from piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split to piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split September 20, 2024 16:54
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split branch from 9964d64 to 42912f8 Compare September 20, 2024 17:03
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split branch from c43b7ad to 0ae58aa Compare September 20, 2024 17:03
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split branch from 42912f8 to 6192048 Compare September 20, 2024 17:16
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split branch from 0ae58aa to 2027093 Compare September 20, 2024 17:16
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split branch from 6192048 to 0a0bb79 Compare September 20, 2024 17:27
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split branch from 2027093 to 39968b8 Compare September 20, 2024 17:27
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split branch from fac3a94 to 05787b7 Compare September 23, 2024 10:37
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split branch from 271cadd to 8ae5123 Compare September 23, 2024 13:01
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split branch from 05787b7 to c897214 Compare September 23, 2024 13:02
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split branch from 8ae5123 to 8f68213 Compare September 23, 2024 13:20
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split branch from c897214 to f310668 Compare September 23, 2024 13:20
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split branch from 8f68213 to 1e12954 Compare September 24, 2024 10:16
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split branch from f310668 to 9c42e37 Compare September 24, 2024 10:17
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split branch from 1e12954 to 7af9c14 Compare September 24, 2024 11:06
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split branch from 9c42e37 to 4b8bdb7 Compare September 24, 2024 11:06
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split branch from 7af9c14 to 078821d Compare September 24, 2024 11:14
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split branch from 4b8bdb7 to 673e296 Compare September 24, 2024 11:14
@khamilowicz khamilowicz marked this pull request as ready for review September 25, 2024 12:32
packages/eas-cli/src/commands/env/unlink.ts Outdated Show resolved Hide resolved
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split branch from 078821d to 1fd4a89 Compare September 27, 2024 10:18
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split branch from 673e296 to 2c88996 Compare September 27, 2024 10:18
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split branch from 1fd4a89 to eaf0256 Compare September 27, 2024 10:30
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split branch 2 times, most recently from f764418 to 5cf60fc Compare September 27, 2024 10:43
Copy link
Contributor Author

khamilowicz commented Oct 1, 2024

Merge activity

  • Oct 1, 4:35 AM EDT: @khamilowicz started a stack merge that includes this pull request via Graphite.
  • Oct 1, 5:02 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 1, 5:03 AM EDT: @khamilowicz merged this pull request with Graphite.

@khamilowicz khamilowicz changed the base branch from piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split to graphite-base/2591 October 1, 2024 08:58
@khamilowicz khamilowicz changed the base branch from graphite-base/2591 to main October 1, 2024 09:00
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split branch from 5cf60fc to f36d44f Compare October 1, 2024 09:01
Copy link

github-actions bot commented Oct 1, 2024

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Copy link

github-actions bot commented Oct 1, 2024

CodeMention:

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela

@khamilowicz khamilowicz merged commit 3f83276 into main Oct 1, 2024
7 checks passed
@khamilowicz khamilowicz deleted the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split_split_split_split_split_split_split_split_split branch October 1, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants