Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EnvironmentVariableMutation and associated commands #2581

Conversation

khamilowicz
Copy link
Contributor

@khamilowicz khamilowicz commented Sep 20, 2024

Why

ENG-13525 Update EAS-CLI for new EnvVar features

Bring up to date create and update EnvVar mutations.

How

  • Use updateEnvironmentVariable operation instead of createEnvironmentVariable with an 'overwrite' option.
  • Add type parameter
  • Add environment parameter for shared variables

Test Plan

Tested manually, tests will be added in the following PRs

Copy link

linear bot commented Sep 20, 2024

Copy link

github-actions bot commented Sep 20, 2024

Size Change: -2.17 kB (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -2.17 kB (0%)

compressed-size-action

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars branch from 4091feb to 181a247 Compare September 20, 2024 15:34
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split branch 2 times, most recently from df57d64 to 3d131e1 Compare September 20, 2024 16:10
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 51.86%. Comparing base (37a68c5) to head (98e9929).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/env/create.ts 0.00% 6 Missing and 1 partial ⚠️
packages/eas-cli/src/commands/env/update.ts 0.00% 4 Missing and 1 partial ⚠️
...c/graphql/mutations/EnvironmentVariableMutation.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2581      +/-   ##
==========================================
- Coverage   51.87%   51.86%   -0.01%     
==========================================
  Files         563      563              
  Lines       21303    21309       +6     
  Branches     4348     4350       +2     
==========================================
  Hits        11049    11049              
- Misses       9366     9372       +6     
  Partials      888      888              
Flag Coverage Δ
51.86% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars branch from 3de1edb to 0b07b3f Compare September 23, 2024 10:08
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split branch from 3d131e1 to f315c41 Compare September 23, 2024 10:08
@khamilowicz khamilowicz marked this pull request as ready for review September 25, 2024 12:31
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars branch from 0b07b3f to a82040b Compare September 27, 2024 10:17
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split branch from f315c41 to df6b8c1 Compare September 27, 2024 10:17
Copy link
Contributor Author

khamilowicz commented Oct 1, 2024

Merge activity

  • Oct 1, 4:35 AM EDT: @khamilowicz started a stack merge that includes this pull request via Graphite.
  • Oct 1, 4:38 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 1, 4:39 AM EDT: @khamilowicz merged this pull request with Graphite.

@khamilowicz khamilowicz changed the base branch from piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars to graphite-base/2581 October 1, 2024 08:36
@khamilowicz khamilowicz changed the base branch from graphite-base/2581 to main October 1, 2024 08:36
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split branch from df6b8c1 to 98e9929 Compare October 1, 2024 08:37
Copy link

github-actions bot commented Oct 1, 2024

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Copy link

github-actions bot commented Oct 1, 2024

CodeMention:

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela

@khamilowicz khamilowicz merged commit 99765c1 into main Oct 1, 2024
7 checks passed
@khamilowicz khamilowicz deleted the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split branch October 1, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants