-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor env:update, add tests #2586
Refactor env:update, add tests #2586
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @khamilowicz and the rest of your teammates on Graphite |
Size Change: -500 B (0%) Total Size: 52.9 MB
|
a0f1412
to
7de87c5
Compare
7dacc37
to
8351549
Compare
7de87c5
to
6f8dad2
Compare
8351549
to
686de52
Compare
6f8dad2
to
304bd96
Compare
686de52
to
cf96d31
Compare
304bd96
to
4bbeae4
Compare
f3e7c08
to
e039833
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2586 +/- ##
==========================================
+ Coverage 51.87% 52.75% +0.89%
==========================================
Files 563 563
Lines 21303 21354 +51
Branches 4348 4371 +23
==========================================
+ Hits 11049 11264 +215
+ Misses 9366 9242 -124
+ Partials 888 848 -40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4bbeae4
to
f6c69d9
Compare
e039833
to
b34acbb
Compare
f6c69d9
to
c110713
Compare
b34acbb
to
2818467
Compare
ff8d302
to
e4ec1a0
Compare
3b540ac
to
16a0fe8
Compare
e4ec1a0
to
91cebca
Compare
16a0fe8
to
076b630
Compare
91cebca
to
fd9e830
Compare
076b630
to
ef1335b
Compare
fd9e830
to
6208199
Compare
ef1335b
to
855b3ce
Compare
6208199
to
3091bf1
Compare
855b3ce
to
e3dfd4d
Compare
3091bf1
to
30de1cb
Compare
e3dfd4d
to
e8b7509
Compare
30de1cb
to
6ef64f6
Compare
e8b7509
to
4311ded
Compare
6ef64f6
to
11957c3
Compare
4311ded
to
b4d4ac6
Compare
Merge activity
|
b4d4ac6
to
960757d
Compare
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
|
Why
ENG-13525: Update EAS-CLI for new EnvVar features
Rework the EnvironmentVariableUpdate function - user is able to alter name, and environments.
How
--variable-name
and--variable-environment
parameters to identify the variable to update--name
and--environment
to update the variable using the newupdateEnvironmentVariable
method.All commands that were using name parameter to identify a single variable will use variable-name and variable-environment instead. This change will enable user to distinguish between name and environment that is identifying variable that is acted upon, and name and environment that is a parameter for command.
For example, when the user wants to update variable TEST that has environment production and change its name and change its environment, they can use:
eas env:update --variable-name TEST --variable-environment production --name TEST-update --environment production --environment preview
Test Plan
Added tests