-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support File type environment variables #2512
Support File type environment variables #2512
Conversation
Size Change: +8.15 kB (+0.02%) Total Size: 52.9 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2512 +/- ##
==========================================
+ Coverage 53.09% 53.12% +0.03%
==========================================
Files 563 564 +1
Lines 21399 21474 +75
Branches 4390 4427 +37
==========================================
+ Hits 11360 11405 +45
- Misses 9201 9224 +23
- Partials 838 845 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c9cb3bd
to
a4ea882
Compare
a4ea882
to
3db0bb5
Compare
673e296
to
2c88996
Compare
3db0bb5
to
bf02d6f
Compare
2c88996
to
f764418
Compare
bf02d6f
to
cc3de5f
Compare
f764418
to
5cf60fc
Compare
cc3de5f
to
9a20a52
Compare
5cf60fc
to
3f83276
Compare
9a20a52
to
5efd133
Compare
|
5efd133
to
6cfa43b
Compare
6cfa43b
to
62f3817
Compare
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable, let's get it released in hidden
state and test it 👍
@@ -34,6 +37,7 @@ type CreateFlags = { | |||
value?: string; | |||
link?: boolean; | |||
force?: boolean; | |||
type?: 'string' | 'file'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: if we use it in multiple places maybe it's worth extracting it to a type and importing it? 🤔
Why
User should be able to upload files to environment variables and read content of those files
How
--type FILE
, selected file is encoded to base64 and sent to www.includeFileContent
file is passedenv:get
automatically include file content,env:list
requires--include-file-content
flagenvironments
,type
andvisibility
Test Plan
tested manually, updated tests