Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EnvironmentVariableCreate for multiple environments, add tests #2583

Conversation

khamilowicz
Copy link
Contributor

@khamilowicz khamilowicz commented Sep 20, 2024

Why

ENG-13525: Update EAS-CLI for new EnvVar features

Update eas env:create to accept multiple --environment parameters.

How

  • Use EASMultiEnvironmentFlag in EnvironmentVariableCreate
  • Update variable display with environment and updatedAt fields

Test Plan

Added tests

Copy link

linear bot commented Sep 20, 2024

Copy link

github-actions bot commented Sep 20, 2024

Size Change: +4.69 kB (+0.01%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +4.69 kB (+0.01%)

compressed-size-action

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split branch from 62678bb to 6c85ac7 Compare September 20, 2024 11:32
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split branch from 4d72da0 to 8a2ed45 Compare September 20, 2024 11:32
@khamilowicz khamilowicz added the no changelog PR that doesn't require a changelog entry label Sep 20, 2024 — with Graphite App
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split branch from 6c85ac7 to b5f43d6 Compare September 20, 2024 15:35
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split branch from 8a2ed45 to acaee00 Compare September 20, 2024 15:35
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split branch from b5f43d6 to 270e02a Compare September 20, 2024 16:10
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split branch 2 times, most recently from 65922dd to 580f6db Compare September 20, 2024 16:54
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 77.96610% with 13 lines in your changes missing coverage. Please review.

Project coverage is 52.14%. Comparing base (37a68c5) to head (ac67608).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/env/create.ts 77.09% 9 Missing and 2 partials ⚠️
packages/eas-cli/src/utils/variableUtils.ts 77.78% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2583      +/-   ##
==========================================
+ Coverage   51.87%   52.14%   +0.27%     
==========================================
  Files         563      563              
  Lines       21303    21327      +24     
  Branches     4348     4361      +13     
==========================================
+ Hits        11049    11118      +69     
+ Misses       9366     9332      -34     
+ Partials      888      877      -11     
Flag Coverage Δ
52.14% <77.97%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split branch from 270e02a to 4fe62cc Compare September 23, 2024 09:26
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split branch from 580f6db to 9271658 Compare September 23, 2024 09:26
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split branch from 4fe62cc to 370a4ba Compare September 23, 2024 09:43
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split branch from 9271658 to 3ef10f3 Compare September 23, 2024 09:43
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split branch from 370a4ba to 186deef Compare September 23, 2024 10:08
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split branch 2 times, most recently from 3ed523f to df9deba Compare September 23, 2024 10:37
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split branch from 186deef to 753351a Compare September 23, 2024 13:01
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split branch from df9deba to ef4327f Compare September 23, 2024 13:01
@khamilowicz khamilowicz marked this pull request as ready for review September 25, 2024 12:31
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split branch from 753351a to dcf1d99 Compare September 27, 2024 10:17
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split branch from ef4327f to 6d52cf8 Compare September 27, 2024 10:18
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split branch from dcf1d99 to 8668cc9 Compare September 27, 2024 10:29
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split branch from 6d52cf8 to 2cda791 Compare September 27, 2024 10:30
Copy link
Contributor Author

khamilowicz commented Oct 1, 2024

Merge activity

  • Oct 1, 4:35 AM EDT: @khamilowicz started a stack merge that includes this pull request via Graphite.
  • Oct 1, 4:44 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 1, 4:45 AM EDT: @khamilowicz merged this pull request with Graphite.

@khamilowicz khamilowicz changed the base branch from piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split to graphite-base/2583 October 1, 2024 08:40
@khamilowicz khamilowicz changed the base branch from graphite-base/2583 to main October 1, 2024 08:42
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split branch from 2cda791 to ac67608 Compare October 1, 2024 08:43
Copy link

github-actions bot commented Oct 1, 2024

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Copy link

github-actions bot commented Oct 1, 2024

CodeMention:

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela

@khamilowicz khamilowicz merged commit 9521cc4 into main Oct 1, 2024
7 checks passed
@khamilowicz khamilowicz deleted the piotrekszeremeta/eng-13525-eas-cli-should-support-multiple-environments-for-envvars_split_split_split branch October 1, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants