Add tests to env:list

expo · Sep 24, 2024 · 078821d · 078821d
1 parent 84d9253
commit 078821d
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 94 deletions.
diff --git a/packages/eas-cli/src/commands/env/__tests__/EnvironmentVariableList.test.ts b/packages/eas-cli/src/commands/env/__tests__/EnvironmentVariableList.test.ts
@@ -11,13 +11,36 @@ import {
 } from '../../../graphql/generated';
 import { AppQuery } from '../../../graphql/queries/AppQuery';
 import { EnvironmentVariablesQuery } from '../../../graphql/queries/EnvironmentVariablesQuery';
-import EnvironmentVariableList from '../list';
 import Log from '../../../log';
+import EnvironmentVariableList from '../list';
 
 jest.mock('../../../graphql/queries/EnvironmentVariablesQuery');
 jest.mock('../../../graphql/queries/AppQuery');
 jest.mock('../../../log');
 
+const mockVariables: EnvironmentVariableFragment[] = [
+  {
+    id: 'var1',
+    name: 'TEST_VAR_1',
+    value: 'value1',
+    environments: [EnvironmentVariableEnvironment.Production],
+    scope: EnvironmentVariableScope.Project,
+    visibility: EnvironmentVariableVisibility.Public,
+    createdAt: undefined,
+    updatedAt: undefined,
+  },
+  {
+    id: 'var2',
+    name: 'TEST_VAR_2',
+    value: 'value2',
+    environments: [EnvironmentVariableEnvironment.Development],
+    scope: EnvironmentVariableScope.Project,
+    visibility: EnvironmentVariableVisibility.Public,
+    createdAt: undefined,
+    updatedAt: undefined,
+  },
+];
+
 describe(EnvironmentVariableList, () => {
   const graphqlClient = {} as any as ExpoGraphqlClient;
   const mockConfig = {} as unknown as Config;
@@ -28,29 +51,6 @@ describe(EnvironmentVariableList, () => {
   });
 
   it('lists project environment variables successfully', async () => {
-    const mockVariables: EnvironmentVariableFragment[] = [
-      {
-        id: 'var1',
-        name: 'TEST_VAR_1',
-        value: 'value1',
-        environments: [EnvironmentVariableEnvironment.Production],
-        scope: EnvironmentVariableScope.Project,
-        visibility: EnvironmentVariableVisibility.Public,
-        createdAt: undefined,
-        updatedAt: undefined,
-      },
-      {
-        id: 'var2',
-        name: 'TEST_VAR_2',
-        value: 'value2',
-        environments: [EnvironmentVariableEnvironment.Development],
-        scope: EnvironmentVariableScope.Project,
-        visibility: EnvironmentVariableVisibility.Public,
-        createdAt: undefined,
-        updatedAt: undefined,
-      },
-    ];
-
     jest.mocked(EnvironmentVariablesQuery.byAppIdAsync).mockResolvedValueOnce(mockVariables);
 
     const command = new EnvironmentVariableList([], mockConfig);
@@ -70,30 +70,27 @@ describe(EnvironmentVariableList, () => {
     expect(Log.log).toHaveBeenCalledWith(expect.stringContaining('TEST_VAR_2'));
   });
 
-  it('lists project environment variables including sensitive values', async () => {
-    const mockVariables: EnvironmentVariableFragment[] = [
-      {
-        id: 'var1',
-        name: 'TEST_VAR_1',
-        value: 'value1',
-        environments: [EnvironmentVariableEnvironment.Production],
-        scope: EnvironmentVariableScope.Project,
-        visibility: EnvironmentVariableVisibility.Public,
-        createdAt: undefined,
-        updatedAt: undefined,
-      },
-      {
-        id: 'var2',
-        name: 'TEST_VAR_2',
-        value: 'value2',
-        environments: [EnvironmentVariableEnvironment.Development],
-        scope: EnvironmentVariableScope.Project,
-        visibility: EnvironmentVariableVisibility.Sensitive,
-        createdAt: undefined,
-        updatedAt: undefined,
-      },
-    ];
+  it('lists project environment variables in specified environments', async () => {
+    jest.mocked(EnvironmentVariablesQuery.byAppIdAsync).mockResolvedValueOnce(mockVariables);
+
+    const command = new EnvironmentVariableList(['--environment', 'production'], mockConfig);
+
+    // @ts-expect-error
+    jest.spyOn(command, 'getContextAsync').mockReturnValue({
+      loggedIn: { graphqlClient },
+      privateProjectConfig: { projectId: testProjectId },
+    });
+    await command.runAsync();
+
+    expect(EnvironmentVariablesQuery.byAppIdAsync).toHaveBeenCalledWith(graphqlClient, {
+      appId: testProjectId,
+      environment: EnvironmentVariableEnvironment.Production,
+    });
+    expect(Log.log).toHaveBeenCalledWith(expect.stringContaining('TEST_VAR_1'));
+    expect(Log.log).toHaveBeenCalledWith(expect.stringContaining('TEST_VAR_2'));
+  });
 
+  it('lists project environment variables including sensitive values', async () => {
     jest
       .mocked(EnvironmentVariablesQuery.byAppIdWithSensitiveAsync)
       .mockResolvedValueOnce(mockVariables);
@@ -119,29 +116,6 @@ describe(EnvironmentVariableList, () => {
   });
 
   it('lists shared environment variables successfully', async () => {
-    const mockVariables: EnvironmentVariableFragment[] = [
-      {
-        id: 'var1',
-        name: 'TEST_VAR_1',
-        value: 'value1',
-        environments: [EnvironmentVariableEnvironment.Production],
-        scope: EnvironmentVariableScope.Shared,
-        visibility: EnvironmentVariableVisibility.Public,
-        createdAt: undefined,
-        updatedAt: undefined,
-      },
-      {
-        id: 'var2',
-        name: 'TEST_VAR_2',
-        value: 'value2',
-        environments: [EnvironmentVariableEnvironment.Development],
-        scope: EnvironmentVariableScope.Shared,
-        visibility: EnvironmentVariableVisibility.Public,
-        createdAt: undefined,
-        updatedAt: undefined,
-      },
-    ];
-
     jest.mocked(EnvironmentVariablesQuery.sharedAsync).mockResolvedValueOnce(mockVariables);
 
     const command = new EnvironmentVariableList(['--scope', 'shared'], mockConfig);
@@ -162,29 +136,6 @@ describe(EnvironmentVariableList, () => {
   });
 
   it('lists shared environment variables including sensitive values', async () => {
-    const mockVariables: EnvironmentVariableFragment[] = [
-      {
-        id: 'var1',
-        name: 'TEST_VAR_1',
-        value: 'value1',
-        environments: [EnvironmentVariableEnvironment.Production],
-        scope: EnvironmentVariableScope.Shared,
-        visibility: EnvironmentVariableVisibility.Public,
-        createdAt: undefined,
-        updatedAt: undefined,
-      },
-      {
-        id: 'var2',
-        name: 'TEST_VAR_2',
-        value: 'value2',
-        environments: [EnvironmentVariableEnvironment.Development],
-        scope: EnvironmentVariableScope.Shared,
-        visibility: EnvironmentVariableVisibility.Sensitive,
-        createdAt: undefined,
-        updatedAt: undefined,
-      },
-    ];
-
     jest
       .mocked(EnvironmentVariablesQuery.sharedWithSensitiveAsync)
       .mockResolvedValueOnce(mockVariables);

diff --git a/packages/eas-cli/src/commands/env/list.ts b/packages/eas-cli/src/commands/env/list.ts
@@ -76,7 +76,7 @@ export default class EnvironmentValueList extends EasCommand {
   async runAsync(): Promise<void> {
     let {
       flags: {
-        environments,
+        environment: environments,
         format,
         scope,
         'include-sensitive': includeSensitive,