fix(NA): yarn env vars for node_modules mirrors #163549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Aug 10, 2023
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 10, 2023
This PR fixes the setup we have for the node_module mirrors vars that are overriding and pointing into our middle cache. The previous configuration was not working as intended as the env vars set globally on CI never ended up in the bazel managed yarn install. Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 17936ff)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 10, 2023
* main: (108 commits) [Telemetry Schema Validation] Allow `null` on `string` (elastic#163499) [Search] Add Slack and Gmail connectors (elastic#163321) [ML] Provide hints for empty fields in dropdown options in Anomaly detection & Transform creation wizards, Change point detection view (elastic#163371) chore(slo): Add response required fields (elastic#163430) [AO] Fix add_to_case functional test (elastic#163155) unskip license type functional test (elastic#163199) fix(NA): yarn env vars for node_modules mirrors (elastic#163549) [Response Ops][Task Manager] Expose SLI metrics in HTTP API (elastic#162178) [Logs UI] Adapt test to ES highlighting changes and unskip (elastic#163592) [Infra UI] Implement Telemetry on 'Show' buttons within Inventory (elastic#163587) [Enterprise Search]Migrate all usages of EuiPage*_Deprecated (elastic#163482) fix(slo): settings and access for serverless (elastic#163514) [Infra UI] Implement telemetry for the asset details flyout (elastic#163078) [Fleet] Add a banner to the top of the Kafka Output UI to say that Elastic Defend integration is not supported (elastic#163579) [Fleet] Re-enable and fix Fleet policy secret integration tests (elastic#163428) [Fleet] add managed to imported saved object (elastic#163526) [Index Management] Disable index actions using contextRef (elastic#163475) [Discover] Inline shard failures warnings (elastic#161271) [Security Solution][Detection engine] skips geo_point non-ecs validation (elastic#163487) Update EUI layout components in bfetch example plugin (elastic#163490) ...
kibanamachine
added a commit
that referenced
this pull request
Aug 10, 2023
) # Backport This will backport the following commits from `main` to `8.9`: - [fix(NA): yarn env vars for node_modules mirrors (#163549)](#163549) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Costa","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-10T14:35:34Z","message":"fix(NA): yarn env vars for node_modules mirrors (#163549)\n\nThis PR fixes the setup we have for the node_module mirrors vars that\r\nare overriding and pointing into our middle cache. The previous\r\nconfiguration was not working as intended as the env vars set globally\r\non CI never ended up in the bazel managed yarn install.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"17936ffd21d4b4b274d2cda90902764ed0d4ae07","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","backport:all-open","v8.10.0"],"number":163549,"url":"https://github.com/elastic/kibana/pull/163549","mergeCommit":{"message":"fix(NA): yarn env vars for node_modules mirrors (#163549)\n\nThis PR fixes the setup we have for the node_module mirrors vars that\r\nare overriding and pointing into our middle cache. The previous\r\nconfiguration was not working as intended as the env vars set globally\r\non CI never ended up in the bazel managed yarn install.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"17936ffd21d4b4b274d2cda90902764ed0d4ae07"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163549","number":163549,"mergeCommit":{"message":"fix(NA): yarn env vars for node_modules mirrors (#163549)\n\nThis PR fixes the setup we have for the node_module mirrors vars that\r\nare overriding and pointing into our middle cache. The previous\r\nconfiguration was not working as intended as the env vars set globally\r\non CI never ended up in the bazel managed yarn install.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"17936ffd21d4b4b274d2cda90902764ed0d4ae07"}}]}] BACKPORT--> Co-authored-by: Tiago Costa <[email protected]>
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Aug 15, 2023
This PR fixes the setup we have for the node_module mirrors vars that are overriding and pointing into our middle cache. The previous configuration was not working as intended as the env vars set globally on CI never ended up in the bazel managed yarn install. Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 17936ff) # Conflicts: # WORKSPACE.bazel
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mistic
added a commit
that referenced
this pull request
Aug 15, 2023
…3897) # Backport This will backport the following commits from `main` to `7.17`: - [fix(NA): yarn env vars for node_modules mirrors (#163549)](#163549) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Costa","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-10T14:35:34Z","message":"fix(NA): yarn env vars for node_modules mirrors (#163549)\n\nThis PR fixes the setup we have for the node_module mirrors vars that\r\nare overriding and pointing into our middle cache. The previous\r\nconfiguration was not working as intended as the env vars set globally\r\non CI never ended up in the bazel managed yarn install.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"17936ffd21d4b4b274d2cda90902764ed0d4ae07","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","backport:all-open","v8.10.0","v8.9.1"],"number":163549,"url":"https://github.com/elastic/kibana/pull/163549","mergeCommit":{"message":"fix(NA): yarn env vars for node_modules mirrors (#163549)\n\nThis PR fixes the setup we have for the node_module mirrors vars that\r\nare overriding and pointing into our middle cache. The previous\r\nconfiguration was not working as intended as the env vars set globally\r\non CI never ended up in the bazel managed yarn install.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"17936ffd21d4b4b274d2cda90902764ed0d4ae07"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163549","number":163549,"mergeCommit":{"message":"fix(NA): yarn env vars for node_modules mirrors (#163549)\n\nThis PR fixes the setup we have for the node_module mirrors vars that\r\nare overriding and pointing into our middle cache. The previous\r\nconfiguration was not working as intended as the env vars set globally\r\non CI never ended up in the bazel managed yarn install.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"17936ffd21d4b4b274d2cda90902764ed0d4ae07"}},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/163617","number":163617,"state":"MERGED","mergeCommit":{"sha":"fc94811899834fe1e8bbe1b27456c57ad08be211","message":"[8.9] fix(NA): yarn env vars for node_modules mirrors (#163549) (#163617)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.9`:\n- [fix(NA): yarn env vars for node_modules mirrors\n(#163549)](https://github.com/elastic/kibana/pull/163549)\n\n<!--- Backport version: 8.9.7 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Tiago\nCosta\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2023-08-10T14:35:34Z\",\"message\":\"fix(NA):\nyarn env vars for node_modules mirrors (#163549)\\n\\nThis PR fixes the\nsetup we have for the node_module mirrors vars that\\r\\nare overriding\nand pointing into our middle cache. The previous\\r\\nconfiguration was\nnot working as intended as the env vars set globally\\r\\non CI never\nended up in the bazel managed yarn install.\\r\\n\\r\\nCo-authored-by:\nKibana Machine\n<[email protected]>\",\"sha\":\"17936ffd21d4b4b274d2cda90902764ed0d4ae07\",\"branchLabelMapping\":{\"^v8.10.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"chore\",\"Team:Operations\",\"release_note:skip\",\"backport:all-open\",\"v8.10.0\"],\"number\":163549,\"url\":\"https://github.com/elastic/kibana/pull/163549\",\"mergeCommit\":{\"message\":\"fix(NA):\nyarn env vars for node_modules mirrors (#163549)\\n\\nThis PR fixes the\nsetup we have for the node_module mirrors vars that\\r\\nare overriding\nand pointing into our middle cache. The previous\\r\\nconfiguration was\nnot working as intended as the env vars set globally\\r\\non CI never\nended up in the bazel managed yarn install.\\r\\n\\r\\nCo-authored-by:\nKibana Machine\n<[email protected]>\",\"sha\":\"17936ffd21d4b4b274d2cda90902764ed0d4ae07\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v8.10.0\",\"labelRegex\":\"^v8.10.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/163549\",\"number\":163549,\"mergeCommit\":{\"message\":\"fix(NA):\nyarn env vars for node_modules mirrors (#163549)\\n\\nThis PR fixes the\nsetup we have for the node_module mirrors vars that\\r\\nare overriding\nand pointing into our middle cache. The previous\\r\\nconfiguration was\nnot working as intended as the env vars set globally\\r\\non CI never\nended up in the bazel managed yarn install.\\r\\n\\r\\nCo-authored-by:\nKibana Machine\n<[email protected]>\",\"sha\":\"17936ffd21d4b4b274d2cda90902764ed0d4ae07\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Tiago Costa <[email protected]>"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the setup we have for the node_module mirrors vars that are overriding and pointing into our middle cache. The previous configuration was not working as intended as the env vars set globally on CI never ended up in the bazel managed yarn install.