Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] fix(NA): yarn env vars for node_modules mirrors (#163549) #163897

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

mistic
Copy link
Member

@mistic mistic commented Aug 15, 2023

Backport

This will backport the following commits from main to 7.17:

Questions ?

Please refer to the Backport tool documentation

\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: Tiago Costa "}}]}] BACKPORT-->

This PR fixes the setup we have for the node_module mirrors vars that
are overriding and pointing into our middle cache. The previous
configuration was not working as intended as the env vars set globally
on CI never ended up in the bazel managed yarn install.

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 17936ff)

# Conflicts:
#	WORKSPACE.bazel
@mistic mistic enabled auto-merge (squash) August 15, 2023 00:13
@mistic mistic disabled auto-merge August 15, 2023 00:37
@mistic mistic merged commit 1dae582 into elastic:7.17 Aug 15, 2023
2 checks passed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Default CI Group #4 / lens app lens drag and drop tests basic drag and drop should construct the basic split xy chart

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants