Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.9] fix(NA): yarn env vars for node_modules mirrors (#163549) #163617

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.9:

Questions ?

Please refer to the Backport tool documentation

This PR fixes the setup we have for the node_module mirrors vars that
are overriding and pointing into our middle cache. The previous
configuration was not working as intended as the env vars set globally
on CI never ended up in the bazel managed yarn install.

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 17936ff)
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 415 419 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 496 500 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mistic

@kibanamachine kibanamachine merged commit fc94811 into elastic:8.9 Aug 10, 2023
mistic added a commit that referenced this pull request Aug 15, 2023
…3897)

# Backport

This will backport the following commits from `main` to `7.17`:
- [fix(NA): yarn env vars for node_modules mirrors
(#163549)](#163549)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tiago
Costa","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-10T14:35:34Z","message":"fix(NA):
yarn env vars for node_modules mirrors (#163549)\n\nThis PR fixes the
setup we have for the node_module mirrors vars that\r\nare overriding
and pointing into our middle cache. The previous\r\nconfiguration was
not working as intended as the env vars set globally\r\non CI never
ended up in the bazel managed yarn install.\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"17936ffd21d4b4b274d2cda90902764ed0d4ae07","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","backport:all-open","v8.10.0","v8.9.1"],"number":163549,"url":"https://github.com/elastic/kibana/pull/163549","mergeCommit":{"message":"fix(NA):
yarn env vars for node_modules mirrors (#163549)\n\nThis PR fixes the
setup we have for the node_module mirrors vars that\r\nare overriding
and pointing into our middle cache. The previous\r\nconfiguration was
not working as intended as the env vars set globally\r\non CI never
ended up in the bazel managed yarn install.\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"17936ffd21d4b4b274d2cda90902764ed0d4ae07"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163549","number":163549,"mergeCommit":{"message":"fix(NA):
yarn env vars for node_modules mirrors (#163549)\n\nThis PR fixes the
setup we have for the node_module mirrors vars that\r\nare overriding
and pointing into our middle cache. The previous\r\nconfiguration was
not working as intended as the env vars set globally\r\non CI never
ended up in the bazel managed yarn install.\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"17936ffd21d4b4b274d2cda90902764ed0d4ae07"}},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/163617","number":163617,"state":"MERGED","mergeCommit":{"sha":"fc94811899834fe1e8bbe1b27456c57ad08be211","message":"[8.9]
fix(NA): yarn env vars for node_modules mirrors (#163549) (#163617)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`8.9`:\n- [fix(NA): yarn env vars for node_modules
mirrors\n(#163549)](https://github.com/elastic/kibana/pull/163549)\n\n<!---
Backport version: 8.9.7 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Tiago\nCosta\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2023-08-10T14:35:34Z\",\"message\":\"fix(NA):\nyarn
env vars for node_modules mirrors (#163549)\\n\\nThis PR fixes
the\nsetup we have for the node_module mirrors vars that\\r\\nare
overriding\nand pointing into our middle cache. The
previous\\r\\nconfiguration was\nnot working as intended as the env vars
set globally\\r\\non CI never\nended up in the bazel managed yarn
install.\\r\\n\\r\\nCo-authored-by:\nKibana
Machine\n<[email protected]>\",\"sha\":\"17936ffd21d4b4b274d2cda90902764ed0d4ae07\",\"branchLabelMapping\":{\"^v8.10.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"chore\",\"Team:Operations\",\"release_note:skip\",\"backport:all-open\",\"v8.10.0\"],\"number\":163549,\"url\":\"https://github.com/elastic/kibana/pull/163549\",\"mergeCommit\":{\"message\":\"fix(NA):\nyarn
env vars for node_modules mirrors (#163549)\\n\\nThis PR fixes
the\nsetup we have for the node_module mirrors vars that\\r\\nare
overriding\nand pointing into our middle cache. The
previous\\r\\nconfiguration was\nnot working as intended as the env vars
set globally\\r\\non CI never\nended up in the bazel managed yarn
install.\\r\\n\\r\\nCo-authored-by:\nKibana
Machine\n<[email protected]>\",\"sha\":\"17936ffd21d4b4b274d2cda90902764ed0d4ae07\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v8.10.0\",\"labelRegex\":\"^v8.10.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/163549\",\"number\":163549,\"mergeCommit\":{\"message\":\"fix(NA):\nyarn
env vars for node_modules mirrors (#163549)\\n\\nThis PR fixes
the\nsetup we have for the node_module mirrors vars that\\r\\nare
overriding\nand pointing into our middle cache. The
previous\\r\\nconfiguration was\nnot working as intended as the env vars
set globally\\r\\non CI never\nended up in the bazel managed yarn
install.\\r\\n\\r\\nCo-authored-by:\nKibana
Machine\n<[email protected]>\",\"sha\":\"17936ffd21d4b4b274d2cda90902764ed0d4ae07\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Tiago Costa <[email protected]>"}}]}] BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants