Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search]Migrate all usages of EuiPage*_Deprecated #163482

Conversation

saarikabhasi
Copy link
Member

@saarikabhasi saarikabhasi commented Aug 9, 2023

Summary

This PR migrates all the usage of EuiPage*_Deprecated in Enterprise Search

Checklist

@saarikabhasi saarikabhasi marked this pull request as ready for review August 9, 2023 12:07
@saarikabhasi saarikabhasi requested a review from a team as a code owner August 9, 2023 12:07
@saarikabhasi saarikabhasi requested a review from a team August 9, 2023 12:07
@saarikabhasi saarikabhasi force-pushed the saarikabhasi/migrate-euiPage-depreciated branch from 0d7a5b8 to 8d08365 Compare August 9, 2023 12:45
@saarikabhasi saarikabhasi added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:EnterpriseSearch v8.10.0 labels Aug 9, 2023
@saarikabhasi saarikabhasi force-pushed the saarikabhasi/migrate-euiPage-depreciated branch from 078a78d to 0d24e86 Compare August 9, 2023 13:08
Copy link
Member

@efegurkan efegurkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Code review only

Copy link
Contributor

@daveyholler daveyholler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing on behalf of design. LGTM

@saarikabhasi saarikabhasi enabled auto-merge (squash) August 10, 2023 12:16
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.5MB 2.5MB -159.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@saarikabhasi saarikabhasi merged commit 2d8f045 into elastic:main Aug 10, 2023
@saarikabhasi saarikabhasi linked an issue Aug 10, 2023 that may be closed by this pull request
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 10, 2023
* main: (108 commits)
  [Telemetry Schema Validation] Allow `null` on `string` (elastic#163499)
  [Search] Add Slack and Gmail connectors (elastic#163321)
  [ML] Provide hints for empty fields in dropdown options in Anomaly detection & Transform creation wizards, Change point detection view (elastic#163371)
  chore(slo): Add response required fields (elastic#163430)
  [AO] Fix add_to_case functional test (elastic#163155)
  unskip license type functional test (elastic#163199)
  fix(NA): yarn env vars for node_modules mirrors (elastic#163549)
  [Response Ops][Task Manager] Expose SLI metrics in HTTP API (elastic#162178)
  [Logs UI] Adapt test to ES highlighting changes and unskip (elastic#163592)
  [Infra UI] Implement Telemetry on 'Show' buttons within Inventory (elastic#163587)
  [Enterprise Search]Migrate all usages of EuiPage*_Deprecated (elastic#163482)
  fix(slo): settings and access for serverless (elastic#163514)
  [Infra UI] Implement telemetry for the asset details flyout (elastic#163078)
  [Fleet] Add a banner to the top of the Kafka Output UI to say that Elastic Defend integration is not supported (elastic#163579)
  [Fleet] Re-enable and fix Fleet policy secret integration tests (elastic#163428)
  [Fleet] add managed to imported saved object (elastic#163526)
  [Index Management] Disable index actions using contextRef (elastic#163475)
  [Discover] Inline shard failures warnings (elastic#161271)
  [Security Solution][Detection engine] skips geo_point non-ecs validation (elastic#163487)
  Update EUI layout components in bfetch example plugin (elastic#163490)
  ...
@saarikabhasi saarikabhasi deleted the saarikabhasi/migrate-euiPage-depreciated branch November 23, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enterprise Search] Migrate all usages of EuiPage*_Deprecated
4 participants