[Ops] Bump Node.js to version 18 #160289
Merged
[Ops] Bump Node.js to version 18 #160289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview: |
jbudz
reviewed
Jun 22, 2023
delanni
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
TinaHeiligers
approved these changes
Jun 23, 2023
|
Thanks @patrykkopycinski - I forgot to highlight in the PR that this is with the custom node 18 builds (with glibc 2.17) in mind. |
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
approved these changes
Jun 26, 2023
|
Added label to make sure all our E2E are passing as well |
amyjtechwriter
approved these changes
Jul 26, 2023
|
@elasticmachine merge upstream |
💔 Build FailedFailed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Thanks everyone for their help and reviews! |
This was referenced Jul 28, 2023
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
delanni
added a commit
to delanni/kibana
that referenced
this pull request
Jul 28, 2023
## Summary Bumps node.js to 18.17.0 (replacement for PR elastic#144012 which was later reverted) As a result, these categorical additions were needed: - `node` evocations will need the `--openssl-legacy-provider` flag, wherever it would use certain crypto functionalities - tests required updating of the expected HTTPS Agent call arguments, `noDelay` seems to be a default - `window.[NAME]` fields cannot be written directly - some stricter typechecks This is using our in-house built node.js 18 versions through the URLs the proxy-cache. (built with elastic/kibana-custom-nodejs-builds#4) These urls are served from a bucket, where the RHEL7/Centos7 compatible node distributables are. (see: elastic/kibana-ci-proxy-cache#7) Further todos: - [x] check docs wording and consistency - [ ] update the dependency report - [x] explain custom builds in documentation - [x] node_sass prebuilts --------- Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Tiago Costa <[email protected]> Co-authored-by: Thomas Watson <[email protected]>
mistic
added a commit
that referenced
this pull request
Jul 31, 2023
…preter on the cloud artifacts deployment scripts (#162742) Closes #162756 This PR fixes a problem introduced after the merge of #160289 Looks like the behaviour of node regarding the use of the `FORCE_COLOR` flag is now propagated differently when cashing the output of a given node interpreter run in a bash variable which was affecting the script and making it to fail when casting a number string to a number. --------- Co-authored-by: kibanamachine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 31, 2023
…preter on the cloud artifacts deployment scripts (elastic#162742) Closes elastic#162756 This PR fixes a problem introduced after the merge of elastic#160289 Looks like the behaviour of node regarding the use of the `FORCE_COLOR` flag is now propagated differently when cashing the output of a given node interpreter run in a bash variable which was affecting the script and making it to fail when casting a number string to a number. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit f981722)
mistic
added a commit
that referenced
this pull request
Jul 31, 2023
… interpreter on the cloud artifacts deployment scripts (#162742) (#162843) # Backport This will backport the following commits from `main` to `8.9`: - [chore(NA): disables FORCE_COLOR temporarily when executing node interpreter on the cloud artifacts deployment scripts (#162742)](#162742) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Costa","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-31T19:57:21Z","message":"chore(NA): disables FORCE_COLOR temporarily when executing node interpreter on the cloud artifacts deployment scripts (#162742)\n\nCloses https://github.com/elastic/kibana/issues/162756\r\n\r\nThis PR fixes a problem introduced after the merge of\r\nhttps://github.com//pull/160289\r\n\r\nLooks like the behaviour of node regarding the use of the `FORCE_COLOR`\r\nflag is now propagated differently when cashing the output of a given\r\nnode interpreter run in a bash variable which was affecting the script\r\nand making it to fail when casting a number string to a number.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"f98172291af44055f1e3ec7a8d55bbf4dacd5f18","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","backport:all-open","v8.10.0"],"number":162742,"url":"https://github.com/elastic/kibana/pull/162742","mergeCommit":{"message":"chore(NA): disables FORCE_COLOR temporarily when executing node interpreter on the cloud artifacts deployment scripts (#162742)\n\nCloses https://github.com/elastic/kibana/issues/162756\r\n\r\nThis PR fixes a problem introduced after the merge of\r\nhttps://github.com//pull/160289\r\n\r\nLooks like the behaviour of node regarding the use of the `FORCE_COLOR`\r\nflag is now propagated differently when cashing the output of a given\r\nnode interpreter run in a bash variable which was affecting the script\r\nand making it to fail when casting a number string to a number.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"f98172291af44055f1e3ec7a8d55bbf4dacd5f18"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162742","number":162742,"mergeCommit":{"message":"chore(NA): disables FORCE_COLOR temporarily when executing node interpreter on the cloud artifacts deployment scripts (#162742)\n\nCloses https://github.com/elastic/kibana/issues/162756\r\n\r\nThis PR fixes a problem introduced after the merge of\r\nhttps://github.com//pull/160289\r\n\r\nLooks like the behaviour of node regarding the use of the `FORCE_COLOR`\r\nflag is now propagated differently when cashing the output of a given\r\nnode interpreter run in a bash variable which was affecting the script\r\nand making it to fail when casting a number string to a number.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"f98172291af44055f1e3ec7a8d55bbf4dacd5f18"}}]}] BACKPORT--> Co-authored-by: Tiago Costa <[email protected]>
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
## Summary Bumps node.js to 18.17.0 (replacement for PR elastic#144012 which was later reverted) As a result, these categorical additions were needed: - `node` evocations will need the `--openssl-legacy-provider` flag, wherever it would use certain crypto functionalities - tests required updating of the expected HTTPS Agent call arguments, `noDelay` seems to be a default - `window.[NAME]` fields cannot be written directly - some stricter typechecks This is using our in-house built node.js 18 versions through the URLs the proxy-cache. (built with elastic/kibana-custom-nodejs-builds#4) These urls are served from a bucket, where the RHEL7/Centos7 compatible node distributables are. (see: elastic/kibana-ci-proxy-cache#7) Further todos: - [x] check docs wording and consistency - [ ] update the dependency report - [x] explain custom builds in documentation - [x] node_sass prebuilts --------- Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Tiago Costa <[email protected]> Co-authored-by: Thomas Watson <[email protected]>
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
…preter on the cloud artifacts deployment scripts (elastic#162742) Closes elastic#162756 This PR fixes a problem introduced after the merge of elastic#160289 Looks like the behaviour of node regarding the use of the `FORCE_COLOR` flag is now propagated differently when cashing the output of a given node interpreter run in a bash variable which was affecting the script and making it to fail when casting a number string to a number. --------- Co-authored-by: kibanamachine <[email protected]>
This was referenced Aug 4, 2023
delanni
added a commit
that referenced
this pull request
Aug 15, 2023
Closes #162695 # Backport This will backport the following commits from `main` to `7.17`: - [[Ops] Bump Node.js to version 18 (#160289)](#160289) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-27T12:12:48Z","message":"[Ops] Bump Node.js to version 18 (#160289)\n\n## Summary\r\n\r\nBumps node.js to 18.17.0 (replacement for PR #144012 which was later\r\nreverted)\r\n\r\nAs a result, these categorical additions were needed: \r\n- `node` evocations will need the `--openssl-legacy-provider` flag,\r\nwherever it would use certain crypto functionalities\r\n- tests required updating of the expected HTTPS Agent call arguments,\r\n`noDelay` seems to be a default\r\n - `window.[NAME]` fields cannot be written directly\r\n - some stricter typechecks\r\n\r\nThis is using our in-house built node.js 18 versions through the URLs\r\nthe proxy-cache. (built with\r\nhttps://github.com/elastic/kibana-custom-nodejs-builds/pull/4)\r\n\r\nThese urls are served from a bucket, where the RHEL7/Centos7 compatible\r\nnode distributables are. (see:\r\nhttps://github.com/elastic/kibana-ci-proxy-cache/pull/7)\r\n\r\nFurther todos: \r\n - [x] check docs wording and consistency\r\n - [ ] update the dependency report\r\n - [x] explain custom builds in documentation\r\n - [x] node_sass prebuilts\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Tiago Costa <[email protected]>\r\nCo-authored-by: Thomas Watson <[email protected]>","sha":"8cf68dc6ba8f010e36538c1e7c92601a341efcf4","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","Team:uptime","backport:skip","release_note:feature","ci:all-cypress-suites","v8.10.0"],"number":160289,"url":"https://github.com/elastic/kibana/pull/160289","mergeCommit":{"message":"[Ops] Bump Node.js to version 18 (#160289)\n\n## Summary\r\n\r\nBumps node.js to 18.17.0 (replacement for PR #144012 which was later\r\nreverted)\r\n\r\nAs a result, these categorical additions were needed: \r\n- `node` evocations will need the `--openssl-legacy-provider` flag,\r\nwherever it would use certain crypto functionalities\r\n- tests required updating of the expected HTTPS Agent call arguments,\r\n`noDelay` seems to be a default\r\n - `window.[NAME]` fields cannot be written directly\r\n - some stricter typechecks\r\n\r\nThis is using our in-house built node.js 18 versions through the URLs\r\nthe proxy-cache. (built with\r\nhttps://github.com/elastic/kibana-custom-nodejs-builds/pull/4)\r\n\r\nThese urls are served from a bucket, where the RHEL7/Centos7 compatible\r\nnode distributables are. (see:\r\nhttps://github.com/elastic/kibana-ci-proxy-cache/pull/7)\r\n\r\nFurther todos: \r\n - [x] check docs wording and consistency\r\n - [ ] update the dependency report\r\n - [x] explain custom builds in documentation\r\n - [x] node_sass prebuilts\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Tiago Costa <[email protected]>\r\nCo-authored-by: Thomas Watson <[email protected]>","sha":"8cf68dc6ba8f010e36538c1e7c92601a341efcf4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160289","number":160289,"mergeCommit":{"message":"[Ops] Bump Node.js to version 18 (#160289)\n\n## Summary\r\n\r\nBumps node.js to 18.17.0 (replacement for PR #144012 which was later\r\nreverted)\r\n\r\nAs a result, these categorical additions were needed: \r\n- `node` evocations will need the `--openssl-legacy-provider` flag,\r\nwherever it would use certain crypto functionalities\r\n- tests required updating of the expected HTTPS Agent call arguments,\r\n`noDelay` seems to be a default\r\n - `window.[NAME]` fields cannot be written directly\r\n - some stricter typechecks\r\n\r\nThis is using our in-house built node.js 18 versions through the URLs\r\nthe proxy-cache. (built with\r\nhttps://github.com/elastic/kibana-custom-nodejs-builds/pull/4)\r\n\r\nThese urls are served from a bucket, where the RHEL7/Centos7 compatible\r\nnode distributables are. (see:\r\nhttps://github.com/elastic/kibana-ci-proxy-cache/pull/7)\r\n\r\nFurther todos: \r\n - [x] check docs wording and consistency\r\n - [ ] update the dependency report\r\n - [x] explain custom builds in documentation\r\n - [x] node_sass prebuilts\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Tiago Costa <[email protected]>\r\nCo-authored-by: Thomas Watson <[email protected]>","sha":"8cf68dc6ba8f010e36538c1e7c92601a341efcf4"}}]}] BACKPORT--> --------- Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Tiago Costa <[email protected]> Co-authored-by: Thomas Watson <[email protected]> Co-authored-by: Jonathan Budzenski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bumps node.js to 18.17.0 (replacement for PR #144012 which was later reverted)
Also closes: #134930
As a result, these categorical additions were needed:
nodeevocations will need the--openssl-legacy-providerflag, wherever it would use certain crypto functionalitiesnoDelayseems to be a defaultwindow.[NAME]fields cannot be written directlyThis is using our in-house built node.js 18 versions through the URLs the proxy-cache. (built with elastic/kibana-custom-nodejs-builds#4)
These urls are served from a bucket, where the RHEL7/Centos7 compatible node distributables are. (see: https://github.com/elastic/kibana-ci-proxy-cache/pull/7)
Further todos: