elastic · delanni · Jul 27, 2023 · Jun 22, 2023 · Jun 23, 2023 · Jun 23, 2023
diff --git a/.ci/Dockerfile b/.ci/Dockerfile
@@ -1,7 +1,7 @@
 # NOTE: This Dockerfile is ONLY used to run certain tasks in CI. It is not used to run Kibana or as a distributable.
 # If you're looking for the Kibana Docker image distributable, please see: src/dev/build/tasks/os_packages/docker_generator/templates/dockerfile.template.ts
 
-ARG NODE_VERSION=16.20.1
+ARG NODE_VERSION=18.16.1
 
 FROM node:${NODE_VERSION} AS base
 

diff --git a/.node-version b/.node-version
@@ -1 +1 @@
-16.20.1
+18.16.1
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-16.20.1
+18.16.1
@@ -22,13 +22,13 @@ load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "yarn_install
 # Setup the Node.js toolchain for the architectures we want to support
 node_repositories(
   node_repositories = {
-    "16.20.1-darwin_amd64": ("node-v16.20.1-darwin-x64.tar.gz", "node-v16.20.1-darwin-x64", "d1f9c2a7c3a0fe09860f701af5fb8ff9ac72d72faa7ebabfeb5794503e79f955"),
-    "16.20.1-darwin_arm64": ("node-v16.20.1-darwin-arm64.tar.gz", "node-v16.20.1-darwin-arm64", "5f6b31c5a75567d382ba67220f3d7a2d9bb0c03d8af9307cd35a9cb32a6fde9d"),
-    "16.20.1-linux_arm64": ("node-v16.20.1-linux-arm64.tar.xz", "node-v16.20.1-linux-arm64", "7fce19f3d1c2952599a0b47f9f5d8f497265ad577f37f256a8c6a03be6353234"),
-    "16.20.1-linux_amd64": ("node-v16.20.1-linux-x64.tar.xz", "node-v16.20.1-linux-x64", "b6c60e1e106ad7d8881e83945a5208c1b1d1b63e6901c04b9dafa607aff3a154"),
-    "16.20.1-windows_amd64": ("node-v16.20.1-win-x64.zip", "node-v16.20.1-win-x64", "2a7fde996c57a969f0498742f99385a520eb14aac864e0eff9c32e3f3633ff0a"),
+    "18.16.1-darwin_amd64": ("node-v18.16.1-darwin-x64.tar.gz", "node-v18.16.1-darwin-x64", "3040210287a0b8d05af49f57de191afa783e497abbb10c340bae9158cb51fdd4"),
+    "18.16.1-darwin_arm64": ("node-v18.16.1-darwin-arm64.tar.gz", "node-v18.16.1-darwin-arm64", "2ccb24e9211f4d17d8d8cfc0ea521198bb6a54e2f779f8feda952dbd3bb651ac"),
+    "18.16.1-linux_arm64": ("node-v18.16.1-linux-arm64.tar.xz", "node-v18.16.1-linux-arm64", "144eb4103e0193de8a41187817261d35970f1a13a11e779e16a4f1d9c99bcc82"),
+    "18.16.1-linux_amd64": ("node-v18.16.1-linux-x64.tar.xz", "node-v18.16.1-linux-x64", "ecfe263dbd9c239f37b5adca823b60be1bb57feabbccd25db785e647ebc5ff5e"),
+    "18.16.1-windows_amd64": ("node-v18.16.1-win-x64.zip", "node-v18.16.1-win-x64", "145bd2f79eaa50b76559bd78266f4585e57b88dbb94613698a9514a601f84e7f"),
   },
-  node_version = "16.20.1",
+  node_version = "18.16.1",
   node_urls = [
     "https://nodejs.org/dist/v{version}/{filename}",
   ],

diff --git a/docs/developer/advanced/upgrading-nodejs.asciidoc b/docs/developer/advanced/upgrading-nodejs.asciidoc
@@ -17,7 +17,7 @@ These files must be updated when upgrading Node.js:
   - {kib-repo}blob/{branch}/WORKSPACE.bazel[`WORKSPACE.bazel`] - The version is specified in the `node_version` property.
     Besides this property, the list of files under `node_repositories` must be updated along with their respective SHA256 hashes.
     These can be found on the https://nodejs.org[nodejs.org] website.
-    Example for Node.js v16.20.1: https://nodejs.org/dist/v16.20.1/SHASUMS256.txt.asc
+    Example for Node.js v18.16.1: https://nodejs.org/dist/v18.16.1/SHASUMS256.txt.asc
 
 See PR {kib-repo}pull/128123[#128123] for an example of how the Node.js version has been upgraded previously.
 

diff --git a/kbn_pm/src/lib/bazel.mjs b/kbn_pm/src/lib/bazel.mjs
@@ -165,7 +165,7 @@ export async function installYarnDeps(log, opts = undefined) {
  * @param {{ offline?: boolean, quiet?: boolean } | undefined} opts
  */
 export async function buildWebpackBundles(log, opts = undefined) {
-  await runBazel(log, ['build', ...BAZEL_TARGETS, '--show_result=1'], {
+  await runBazel(log, ['build', ...BAZEL_TARGETS, '--show_result=1', '--sandbox_debug=true'], {
     offline: opts?.offline,
     quiet: opts?.quiet,
   });

diff --git a/package.json b/package.json
@@ -61,7 +61,7 @@
     "serverless-security": "node scripts/kibana --dev --serverless=security",
     "spec_to_console": "node scripts/spec_to_console",
     "start": "node scripts/kibana --dev",
-    "storybook": "node scripts/storybook",
+    "storybook": "node --openssl-legacy-provider scripts/storybook",
     "test:ftr": "node scripts/functional_tests",
     "test:ftr:runner": "node scripts/functional_test_runner",
     "test:ftr:server": "node scripts/functional_tests_server",
@@ -73,11 +73,11 @@
     "url": "https://github.com/elastic/kibana.git"
   },
   "engines": {
-    "node": "16.20.1",
+    "node": "18.16.1",
     "yarn": "^1.22.19"
   },
   "resolutions": {
-    "**/@types/node": "16.11.68",
+    "**/@types/node": "18",
     "**/chokidar": "^3.5.3",
     "**/globule/minimatch": "^3.1.2",
     "**/hoist-non-react-statics": "^3.3.2",
@@ -775,7 +775,6 @@
     "@turf/length": "^6.0.2",
     "@xstate/react": "^3.2.2",
     "JSONStream": "1.3.5",
-    "abort-controller": "^3.0.0",
     "adm-zip": "^0.5.9",
     "ajv": "^8.12.0",
     "antlr4ts": "^0.5.0-alpha.3",
@@ -916,7 +915,7 @@
     "query-string": "^6.13.2",
     "rbush": "^3.0.1",
     "re-resizable": "^6.9.9",
-    "re2": "1.17.4",
+    "re2": "1.17.7",
     "react": "^17.0.2",
     "react-ace": "^7.0.5",
     "react-beautiful-dnd": "^13.1.0",
@@ -1285,8 +1284,8 @@
     "@types/multistream": "^4.1.0",
     "@types/mustache": "^0.8.31",
     "@types/nock": "^10.0.3",
-    "@types/node": "16.11.68",
-    "@types/node-fetch": "^2.6.0",
+    "@types/node": "18.16.18",
+    "@types/node-fetch": "2.6.4",
     "@types/node-forge": "^1.3.1",
     "@types/nodemailer": "^6.4.0",
     "@types/normalize-path": "^3.0.0",

diff --git a/packages/core/chrome/core-chrome-browser-internal/src/chrome_service.test.tsx b/packages/core/chrome/core-chrome-browser-internal/src/chrome_service.test.tsx
@@ -36,11 +36,14 @@ class FakeApp implements App {
 const store = new Map();
 const originalLocalStorage = window.localStorage;
 
-(window as any).localStorage = {
-  setItem: (key: string, value: string) => store.set(String(key), String(value)),
-  getItem: (key: string) => store.get(String(key)),
-  removeItem: (key: string) => store.delete(String(key)),
-};
+Object.defineProperty(window, 'localStorage', {
+  value: {
+    setItem: (key: string, value: string) => store.set(String(key), String(value)),
+    getItem: (key: string) => store.get(String(key)),
+    removeItem: (key: string) => store.delete(String(key)),
+  },
+  writable: true,
+});
 
 function defaultStartDeps(availableApps?: App[]) {
   const deps = {

diff --git a/...rome/core-chrome-browser-internal/src/recently_accessed/recently_accessed_service.test.ts b/...rome/core-chrome-browser-internal/src/recently_accessed/recently_accessed_service.test.ts
@@ -44,7 +44,10 @@ describe('RecentlyAccessed#start()', () => {
   let originalLocalStorage: Storage;
   beforeAll(() => {
     originalLocalStorage = window.localStorage;
-    window.localStorage = new LocalStorageMock();
+    Object.defineProperty(window, 'localStorage', {
+      value: new LocalStorageMock(),
+      writable: true,
+    });
   });
   beforeEach(() => localStorage.clear());
   afterAll(() => (window.localStorage = originalLocalStorage));

@@ -14,7 +14,6 @@ import { pipeline, Transform } from 'stream';
 import { setTimeout } from 'timers/promises';
 
 import fetch, { Headers } from 'node-fetch';
-import AbortController from 'abort-controller';
 import chalk from 'chalk';
 import { ToolingLog } from '@kbn/tooling-log';
 

diff --git a/packages/kbn-monaco/BUILD.bazel b/packages/kbn-monaco/BUILD.bazel
@@ -56,9 +56,11 @@ webpack_cli(
   env = select({
     "//:dist": {
       "NODE_ENV": "production",
+      "NODE_OPTIONS": "--openssl-legacy-provider",
     },
     "//conditions:default": {
       "NODE_ENV": "development",
+      "NODE_OPTIONS": "--openssl-legacy-provider",
     },
   }),
   visibility = ["//visibility:public"],

@@ -61,6 +61,7 @@ function usingWorkerProc<T>(config: OptimizerConfig, fn: (proc: ChildProcess) =>
       const proc = fork(require.resolve('../worker/run_worker'), [], {
         execArgv: [
           `--require=@kbn/babel-register/install`,
+          '--openssl-legacy-provider',
           ...(inspectFlag && config.inspectWorkers
             ? [`${inspectFlag}=${inspectPortCounter++}`]
             : []),

@@ -39,6 +39,9 @@ it('builds a generated plugin into a viable archive', async () => {
     process.execPath,
     ['scripts/generate_plugin', '-y', '--name', 'fooTestPlugin'],
     {
+      env: {
+        NODE_OPTIONS: '--openssl-legacy-provider',
+      },
       cwd: REPO_ROOT,
       all: true,
     }
@@ -61,6 +64,9 @@ it('builds a generated plugin into a viable archive', async () => {
     process.execPath,
     ['../../scripts/plugin_helpers', 'build', '--kibana-version', '7.5.0'],
     {
+      env: {
+        NODE_OPTIONS: '--openssl-legacy-provider',
+      },
       cwd: PLUGIN_DIR,
       all: true,
     }

diff --git a/packages/kbn-ui-shared-deps-npm/BUILD.bazel b/packages/kbn-ui-shared-deps-npm/BUILD.bazel
@@ -86,9 +86,11 @@ webpack_cli(
   env = select({
     "//:dist": {
       "NODE_ENV": "production",
+      "NODE_OPTIONS": "--openssl-legacy-provider",
     },
     "//conditions:default": {
       "NODE_ENV": "development",
+      "NODE_OPTIONS": "--openssl-legacy-provider",
     },
   })
 )

diff --git a/packages/kbn-ui-shared-deps-src/BUILD.bazel b/packages/kbn-ui-shared-deps-src/BUILD.bazel
@@ -45,9 +45,11 @@ webpack_cli(
   env = select({
     "//:dist": {
       "NODE_ENV": "production",
+      "NODE_OPTIONS": "--openssl-legacy-provider",
     },
     "//conditions:default": {
       "NODE_ENV": "development",
+      "NODE_OPTIONS": "--openssl-legacy-provider",
     },
   }),
   visibility = ["//visibility:public"],

@@ -112,7 +112,7 @@ export async function downloadToDisk({
         const downloadedSha = hash.digest('hex');
         if (downloadedSha !== shaChecksum) {
           throw new Error(
-            `Downloaded checksum ${downloadedSha} does not match the expected ${shaAlgorithm} checksum.`
+            `Downloaded checksum ${downloadedSha} does not match the expected (${shaAlgorithm}) checksum ${shaChecksum}, for file: ${url}.`
           );
         }
       }

@@ -113,7 +113,7 @@ describe('downloadToDisk', () => {
       shaAlgorithm: 'sha256',
     });
     await expect(promise).rejects.toMatchInlineSnapshot(
-      `[Error: Downloaded checksum 2c26b46b68ffc68ff99b453c1d30413413422d706483bfa0f98a5e886266e7ae does not match the expected sha256 checksum.]`
+      `[Error: Downloaded checksum ${FOO_SHA256} does not match the expected (sha256) checksum bar, for file: ${serverUrl}.]`
     );
 
     try {
@@ -175,7 +175,7 @@ describe('downloadToDisk', () => {
           " info Retrying in 0.1 seconds",
           " debg [2/3] Attempting download of TEST_SERVER_URL sha256",
           " debg Downloaded 3 bytes to TMP_DIR/__tmp_download_js_test_file__",
-          " debg Download failed: Downloaded checksum fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9 does not match the expected sha256 checksum.",
+          " debg Download failed: Downloaded checksum fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9 does not match the expected (sha256) checksum 2c26b46b68ffc68ff99b453c1d30413413422d706483bfa0f98a5e886266e7ae, for file: TEST_SERVER_URL.",
           " debg Deleting downloaded data at TMP_DIR/__tmp_download_js_test_file__",
           " info Retrying in 0.2 seconds",
           " debg [3/3] Attempting download of TEST_SERVER_URL sha256",

@@ -41,17 +41,13 @@ interface Package {
 const packages: Package[] = [
   {
     name: 're2',
-    version: '1.17.4',
+    version: '1.17.7',
     destinationPath: 'node_modules/re2/build/Release/re2.node',
     extractMethod: 'gunzip',
     archives: {
-      'darwin-x64': {
-        url: 'https://us-central1-elastic-kibana-184716.cloudfunctions.net/kibana-ci-proxy-cache/node-re2/uhop/node-re2/releases/download/1.17.4/darwin-x64-93.gz',
-        sha256: '9558c5cb39622e9b3653203e772b129d6c634e7dbd7af1b244352fc1d704601f',
-      },
       'linux-x64': {
-        url: 'https://us-central1-elastic-kibana-184716.cloudfunctions.net/kibana-ci-proxy-cache/node-re2/uhop/node-re2/releases/download/1.17.4/linux-x64-93.gz',
-        sha256: '4d06747b266c75b6f7ced93977692c0586ce6a52924cabb569bd966378941aa1',
+        url: 'https://us-central1-elastic-kibana-184716.cloudfunctions.net/kibana-ci-proxy-cache/node-re2/uhop/node-re2/releases/download/1.17.7/linux-x64-108.gz',
+        sha256: '197a617ca2965f220848561afed71ff6df653f6d79910cf38e866c84ab38a236',
       },
 
       // ARM builds are currently done manually as Github Actions used in upstream project
@@ -67,8 +63,13 @@ const packages: Package[] = [
       // * capture the sha256 with: `shasum -a 256 linux-arm64-*`
       // * upload the `linux-arm64-*.gz` artifact to the `yarn-prebuilt-artifacts` bucket in GCS using the correct version number
       'linux-arm64': {
-        url: 'https://us-central1-elastic-kibana-184716.cloudfunctions.net/kibana-ci-proxy-cache/node-re2/uhop/node-re2/releases/download/1.17.4/linux-arm64-93.gz',
-        sha256: '25409584f76f3d6ed85463d84adf094eb6e256ed1cb0b754b95bcbda6691fc26',
+        url: 'https://us-central1-elastic-kibana-184716.cloudfunctions.net/kibana-ci-proxy-cache/node-re2/uhop/node-re2/releases/download/1.17.7/linux-arm64-108.gz',
+        sha256: 'a690087a1a1fd9887aac1abdab68d1992600e218be10783da6d3381cca950c1a',
+      },
+
+      'darwin-x64': {
+        url: 'https://us-central1-elastic-kibana-184716.cloudfunctions.net/kibana-ci-proxy-cache/node-re2/uhop/node-re2/releases/download/1.17.7/darwin-x64-108.gz',
+        sha256: '4ed378c5a7fe6134b717afe7642254aff1ed7a881cbcaa53a012ac3efab49f99',
       },
 
       // A similar process is necessary for building on ARM macs:
@@ -78,13 +79,13 @@ const packages: Package[] = [
       // * capture the sha256 with: `shasum -a 256 darwin-arm64-*`
       // * upload the `darwin-arm64-*.gz` artifact to the `yarn-prebuilt-artifacts` bucket in GCS using the correct version number
       'darwin-arm64': {
-        url: 'https://us-central1-elastic-kibana-184716.cloudfunctions.net/kibana-ci-proxy-cache/node-re2/uhop/node-re2/releases/download/1.17.4/darwin-arm64-93.gz',
-        sha256: 'd4b708749ddef1c87019f6b80e051ed0c29ccd1de34f233c47d8dcaddf803872',
+        url: 'https://us-central1-elastic-kibana-184716.cloudfunctions.net/kibana-ci-proxy-cache/node-re2/uhop/node-re2/releases/download/1.17.7/darwin-arm64-108.gz',
+        sha256: '42afc32137ff5c5bebae5d68347a9786906748c2f28e06194d8950707f2ae90e',
       },
 
       'win32-x64': {
-        url: 'https://us-central1-elastic-kibana-184716.cloudfunctions.net/kibana-ci-proxy-cache/node-re2/uhop/node-re2/releases/download/1.17.4/win32-x64-93.gz',
-        sha256: '0320d0c0385432944c6fb3c8c8fcd78d440ce5626f7618f9ec71d88e44820674',
+        url: 'https://us-central1-elastic-kibana-184716.cloudfunctions.net/kibana-ci-proxy-cache/node-re2/uhop/node-re2/releases/download/1.17.7/win32-x64-108.gz',
+        sha256: 'ff72fe02de652262659c8e17e44a932f3c873362233756b40d1a97538d05de92',
       },
     },
   },

diff --git a/src/plugins/console/public/application/models/sense_editor/sense_editor.test.js b/src/plugins/console/public/application/models/sense_editor/sense_editor.test.js
@@ -39,7 +39,10 @@ describe('Editor', () => {
     oldUrl = global.URL;
     olldWindow = { ...global.window };
     global.URL = URL;
-    global.window = Object.create(window);
+    Object.defineProperty(global, 'window', {
+      value: Object.create(window),
+      writable: true,
+    });
     Object.defineProperty(window, 'location', {
       value: {
         origin: 'http://localhost:5620',

diff --git a/src/plugins/kibana_usage_collection/server/collectors/cloud/cloud_provider_collector.ts b/src/plugins/kibana_usage_collection/server/collectors/cloud/cloud_provider_collector.ts
@@ -7,7 +7,6 @@
  */
 
 import { firstValueFrom, type Observable } from 'rxjs';
-import AbortController from 'abort-controller';
 import { UsageCollectionSetup } from '@kbn/usage-collection-plugin/server';
 import { CloudDetector } from './detector';
 

diff --git a/src/plugins/kibana_usage_collection/server/collectors/cloud/detector/aws.ts b/src/plugins/kibana_usage_collection/server/collectors/cloud/detector/aws.ts
@@ -9,7 +9,6 @@
 import { readFile } from 'fs/promises';
 import { get, omit } from 'lodash';
 import fetch from 'node-fetch';
-import { AbortSignal } from 'abort-controller';
 import { CloudService } from './cloud_service';
 import { CloudServiceResponse } from './cloud_response';
 

diff --git a/src/plugins/kibana_usage_collection/server/collectors/cloud/detector/azure.ts b/src/plugins/kibana_usage_collection/server/collectors/cloud/detector/azure.ts
@@ -8,7 +8,6 @@
 
 import { get, omit } from 'lodash';
 import fetch from 'node-fetch';
-import { AbortSignal } from 'abort-controller';
 import { CloudService } from './cloud_service';
 import { CloudServiceResponse } from './cloud_response';
 

diff --git a/src/plugins/kibana_usage_collection/server/collectors/cloud/detector/cloud_detector.ts b/src/plugins/kibana_usage_collection/server/collectors/cloud/detector/cloud_detector.ts
@@ -6,7 +6,6 @@
  * Side Public License, v 1.
  */
 
-import { AbortSignal } from 'abort-controller';
 import type { CloudService } from './cloud_service';
 import type { CloudServiceResponseJson } from './cloud_response';
 

diff --git a/src/plugins/kibana_usage_collection/server/collectors/cloud/detector/cloud_service.ts b/src/plugins/kibana_usage_collection/server/collectors/cloud/detector/cloud_service.ts
@@ -6,7 +6,6 @@
  * Side Public License, v 1.
  */
 
-import { AbortSignal } from 'abort-controller';
 import { isObject, isPlainObject } from 'lodash';
 import { CloudServiceResponse } from './cloud_response';
 

diff --git a/src/plugins/kibana_usage_collection/server/collectors/cloud/detector/gcp.ts b/src/plugins/kibana_usage_collection/server/collectors/cloud/detector/gcp.ts
@@ -7,7 +7,6 @@
  */
 
 import fetch, { Response } from 'node-fetch';
-import { AbortSignal } from 'abort-controller';
 import { CloudService } from './cloud_service';
 import { CloudServiceResponse } from './cloud_response';
 

diff --git a/x-pack/plugins/actions/server/lib/request_oauth_client_credentials_token.test.ts b/x-pack/plugins/actions/server/lib/request_oauth_client_credentials_token.test.ts
@@ -74,6 +74,7 @@ describe('requestOAuthClientCredentialsToken', () => {
             "maxSockets": Infinity,
             "maxTotalSockets": Infinity,
             "options": Object {
+              "noDelay": true,
               "path": null,
               "rejectUnauthorized": true,
             },

diff --git a/x-pack/plugins/actions/server/lib/request_oauth_jwt_token.test.ts b/x-pack/plugins/actions/server/lib/request_oauth_jwt_token.test.ts
@@ -75,6 +75,7 @@ describe('requestOAuthJWTToken', () => {
             "maxSockets": Infinity,
             "maxTotalSockets": Infinity,
             "options": Object {
+              "noDelay": true,
               "path": null,
               "rejectUnauthorized": true,
             },

diff --git a/x-pack/plugins/actions/server/lib/request_oauth_token.test.ts b/x-pack/plugins/actions/server/lib/request_oauth_token.test.ts
@@ -82,6 +82,7 @@ describe('requestOAuthToken', () => {
             "maxSockets": Infinity,
             "maxTotalSockets": Infinity,
             "options": Object {
+              "noDelay": true,
               "path": null,
               "rejectUnauthorized": true,
             },

diff --git a/x-pack/plugins/canvas/scripts/shareable_runtime.js b/x-pack/plugins/canvas/scripts/shareable_runtime.js
@@ -55,6 +55,7 @@ run(
       execa.sync(
         process.execPath,
         [
+          '--openssl-legacy-provider',
           require.resolve('webpack-dev-server/bin/webpack-dev-server'),
           '--config',
           webpackConfig,
@@ -88,6 +89,7 @@ run(
     execa.sync(
       process.execPath,
       [
+        '--openssl-legacy-provider',
         require.resolve('webpack/bin/webpack'),
         '--config',
         webpackConfig,

diff --git a/x-pack/plugins/enterprise_search/server/lib/enterprise_search_config_api.ts b/x-pack/plugins/enterprise_search/server/lib/enterprise_search_config_api.ts
@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import AbortController from 'abort-controller';
 import fetch from 'node-fetch';
 
 import { KibanaRequest, Logger } from '@kbn/core/server';
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,7 +5,6 @@ @@
      * 2.0.
      */
-    import AbortController from 'abort-controller';
     import fetch from 'node-fetch';
     import { KibanaRequest, Logger } from '@kbn/core/server';
@@ Expand Down @@