-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport node.js 18 to 7.17 #162695
Labels
Comments
Pinging @elastic/kibana-operations (Team:Operations) |
delanni
added a commit
that referenced
this issue
Aug 15, 2023
Closes #162695 # Backport This will backport the following commits from `main` to `7.17`: - [[Ops] Bump Node.js to version 18 (#160289)](#160289) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-27T12:12:48Z","message":"[Ops] Bump Node.js to version 18 (#160289)\n\n## Summary\r\n\r\nBumps node.js to 18.17.0 (replacement for PR #144012 which was later\r\nreverted)\r\n\r\nAs a result, these categorical additions were needed: \r\n- `node` evocations will need the `--openssl-legacy-provider` flag,\r\nwherever it would use certain crypto functionalities\r\n- tests required updating of the expected HTTPS Agent call arguments,\r\n`noDelay` seems to be a default\r\n - `window.[NAME]` fields cannot be written directly\r\n - some stricter typechecks\r\n\r\nThis is using our in-house built node.js 18 versions through the URLs\r\nthe proxy-cache. (built with\r\nhttps://github.com/elastic/kibana-custom-nodejs-builds/pull/4)\r\n\r\nThese urls are served from a bucket, where the RHEL7/Centos7 compatible\r\nnode distributables are. (see:\r\nhttps://github.com/elastic/kibana-ci-proxy-cache/pull/7)\r\n\r\nFurther todos: \r\n - [x] check docs wording and consistency\r\n - [ ] update the dependency report\r\n - [x] explain custom builds in documentation\r\n - [x] node_sass prebuilts\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Tiago Costa <[email protected]>\r\nCo-authored-by: Thomas Watson <[email protected]>","sha":"8cf68dc6ba8f010e36538c1e7c92601a341efcf4","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","Team:uptime","backport:skip","release_note:feature","ci:all-cypress-suites","v8.10.0"],"number":160289,"url":"https://github.com/elastic/kibana/pull/160289","mergeCommit":{"message":"[Ops] Bump Node.js to version 18 (#160289)\n\n## Summary\r\n\r\nBumps node.js to 18.17.0 (replacement for PR #144012 which was later\r\nreverted)\r\n\r\nAs a result, these categorical additions were needed: \r\n- `node` evocations will need the `--openssl-legacy-provider` flag,\r\nwherever it would use certain crypto functionalities\r\n- tests required updating of the expected HTTPS Agent call arguments,\r\n`noDelay` seems to be a default\r\n - `window.[NAME]` fields cannot be written directly\r\n - some stricter typechecks\r\n\r\nThis is using our in-house built node.js 18 versions through the URLs\r\nthe proxy-cache. (built with\r\nhttps://github.com/elastic/kibana-custom-nodejs-builds/pull/4)\r\n\r\nThese urls are served from a bucket, where the RHEL7/Centos7 compatible\r\nnode distributables are. (see:\r\nhttps://github.com/elastic/kibana-ci-proxy-cache/pull/7)\r\n\r\nFurther todos: \r\n - [x] check docs wording and consistency\r\n - [ ] update the dependency report\r\n - [x] explain custom builds in documentation\r\n - [x] node_sass prebuilts\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Tiago Costa <[email protected]>\r\nCo-authored-by: Thomas Watson <[email protected]>","sha":"8cf68dc6ba8f010e36538c1e7c92601a341efcf4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160289","number":160289,"mergeCommit":{"message":"[Ops] Bump Node.js to version 18 (#160289)\n\n## Summary\r\n\r\nBumps node.js to 18.17.0 (replacement for PR #144012 which was later\r\nreverted)\r\n\r\nAs a result, these categorical additions were needed: \r\n- `node` evocations will need the `--openssl-legacy-provider` flag,\r\nwherever it would use certain crypto functionalities\r\n- tests required updating of the expected HTTPS Agent call arguments,\r\n`noDelay` seems to be a default\r\n - `window.[NAME]` fields cannot be written directly\r\n - some stricter typechecks\r\n\r\nThis is using our in-house built node.js 18 versions through the URLs\r\nthe proxy-cache. (built with\r\nhttps://github.com/elastic/kibana-custom-nodejs-builds/pull/4)\r\n\r\nThese urls are served from a bucket, where the RHEL7/Centos7 compatible\r\nnode distributables are. (see:\r\nhttps://github.com/elastic/kibana-ci-proxy-cache/pull/7)\r\n\r\nFurther todos: \r\n - [x] check docs wording and consistency\r\n - [ ] update the dependency report\r\n - [x] explain custom builds in documentation\r\n - [x] node_sass prebuilts\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Tiago Costa <[email protected]>\r\nCo-authored-by: Thomas Watson <[email protected]>","sha":"8cf68dc6ba8f010e36538c1e7c92601a341efcf4"}}]}] BACKPORT--> --------- Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Tiago Costa <[email protected]> Co-authored-by: Thomas Watson <[email protected]> Co-authored-by: Jonathan Budzenski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Backport the node.js bump (#160289) to the v7 branch.
The text was updated successfully, but these errors were encountered: