Upgrade eslint-plugin-jest from v24.5.0 to v27.2.3 #162689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Jul 28, 2023
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @watson |
jloleysens
approved these changes
Jul 31, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 31, 2023
(cherry picked from commit 0e081d8)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
watson
pushed a commit
to watson/kibana
that referenced
this pull request
Jul 31, 2023
(cherry picked from commit 0e081d8) # Conflicts: # yarn.lock
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 31, 2023
…162771) # Backport This will backport the following commits from `main` to `8.9`: - [Upgrade eslint-plugin-jest from v24.5.0 to v27.2.3 (#162689)](#162689) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Thomas Watson","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-31T08:34:49Z","message":"Upgrade eslint-plugin-jest from v24.5.0 to v27.2.3 (#162689)","sha":"0e081d84f27e462a01a6902345c453040b123d1a","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","v8.10.0"],"number":162689,"url":"https://github.com/elastic/kibana/pull/162689","mergeCommit":{"message":"Upgrade eslint-plugin-jest from v24.5.0 to v27.2.3 (#162689)","sha":"0e081d84f27e462a01a6902345c453040b123d1a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162689","number":162689,"mergeCommit":{"message":"Upgrade eslint-plugin-jest from v24.5.0 to v27.2.3 (#162689)","sha":"0e081d84f27e462a01a6902345c453040b123d1a"}}]}] BACKPORT--> Co-authored-by: Thomas Watson <[email protected]>
watson
pushed a commit
that referenced
this pull request
Jul 31, 2023
…162778) # Backport This will backport the following commits from `main` to `7.17`: - [Upgrade eslint-plugin-jest from v24.5.0 to v27.2.3 (#162689)](#162689) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Thomas Watson","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-31T08:34:49Z","message":"Upgrade eslint-plugin-jest from v24.5.0 to v27.2.3 (#162689)","sha":"0e081d84f27e462a01a6902345c453040b123d1a","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","v8.10.0"],"number":162689,"url":"https://github.com/elastic/kibana/pull/162689","mergeCommit":{"message":"Upgrade eslint-plugin-jest from v24.5.0 to v27.2.3 (#162689)","sha":"0e081d84f27e462a01a6902345c453040b123d1a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162689","number":162689,"mergeCommit":{"message":"Upgrade eslint-plugin-jest from v24.5.0 to v27.2.3 (#162689)","sha":"0e081d84f27e462a01a6902345c453040b123d1a"}},{"url":"https://github.com/elastic/kibana/pull/162771","number":162771,"branch":"8.9","state":"OPEN"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in preparation for Upgrading ESLint to the next major version: #162309
Here are the list of braking changes in
eslint-plugin-jestbetween v24.5.0 and v27.2.3:27.0.0: https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md#2700-2022-08-2826.0.0: https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md#2600-2022-01-2425.0.0: https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md#2500-2021-10-10As far as I can see, the only one affecting us is the rename of
valid-describetovalid-describe-callbackwhich I've included in this PR.