Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ESLint to v8 #162309

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Upgrade ESLint to v8 #162309

merged 5 commits into from
Aug 10, 2023

Conversation

watson
Copy link
Contributor

@watson watson commented Jul 20, 2023 •
edited
Loading

For details of breaking changes, see ESLint blog post Migrate to v8.0.0. For a full list of changes see their CHANGELOG.md.

The newer version comes with various performance improvements, but I haven't tested if it's significant in a project like ours.

The PR also upgrades a bunch of ESLint plugins and related packages at the same time. Some of these upgrades probably wasn't required to complete the v8 upgrade, though I haven't verified - but YOLO 😅

Updated direct dependencies

Package From To Changes
@types/eslint 7.28.0 8.44.2
eslint 7.32.0 8.46.0 CHANGELOG.md
eslint-config-prettier 8.5.0 9.0.0 CHANGELOG.md
eslint-module-utils 2.6.2 2.8.0 CHANGELOG.md
eslint-plugin-ban 1.5.2 1.6.0 diff
eslint-plugin-cypress 2.13.2 2.14.0 Release notes
eslint-plugin-import 2.24.2 2.28.0 CHANGELOG.md
eslint-plugin-jsx-a11y 6.4.1 6.7.1 CHANGELOG.md
eslint-plugin-mocha 10.0.5 10.1.0 CHANGELOG.md
eslint-plugin-no-unsanitized 3.1.5 4.0.2 diff

Note to reviewers

The vast majority of files touched by this PR is changes to the import order due to minor fixes in the import/order rule.

Blocked by

Tasks
Preview Give feedback
  1. Clean up imports of ESLint types #162436
    Team:Operations backport:skip release_note:skip v8.10.0 v8.9.1
    watson
  2. Remove eslint-plugin-prefer-object-spread dependency #162439
    Team:Operations release_note:skip v7.17.13 v8.10.0 v8.9.1
    watson
  3. Upgrade ESLint React plugins #162464
    Team:Operations Team:Uptime - DEPRECATED auto-backport release_note:skip v7.17.13 v8.10.0
    watson
  4. Upgrade eslint-plugin-jest from v24.5.0 to v27.2.3 #162689
    Team:Operations backport:all-open release_note:skip v7.17.13 v8.10.0 v8.9.1
    watson

@watson watson added release_note:skip Skip the PR/issue when compiling release notes v8.10.0 v7.17.12 labels Jul 20, 2023
@watson watson self-assigned this Jul 20, 2023
@watson watson force-pushed the bump-eslint branch 10 times, most recently from 31f130d to b2dd5b6 Compare July 24, 2023 19:25
@watson watson mentioned this pull request Jul 24, 2023
Merged
@watson watson force-pushed the bump-eslint branch 3 times, most recently from c7a6418 to e4b607d Compare July 25, 2023 11:43
@watson watson mentioned this pull request Jul 25, 2023
Merged
@kpatticha kpatticha added the apm:cypress-record cypress test runs will be recorded to the cypress dashboard label Jul 25, 2023
@watson watson force-pushed the bump-eslint branch 2 times, most recently from f1a567b to 02f6c5c Compare July 28, 2023 08:55
@watson watson mentioned this pull request Jul 28, 2023
Merged
@watson watson force-pushed the bump-eslint branch 2 times, most recently from 2d86e72 to 13acf2e Compare July 31, 2023 11:04
@watson watson added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 9, 2023
@watson watson requested a review from a team as a code owner August 10, 2023 07:57
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 1.0MB 1.0MB -28.0B
security 567.8KB 567.8KB +60.0B
spaces 173.8KB 173.8KB +28.0B
total +60.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 6.0MB 6.0MB -4.0B
security 69.7KB 69.7KB +1.0B
spaces 26.0KB 26.0KB +10.0B
total +7.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
security 54 53 -1
securitySolution 462 464 +2
total +1

Total ESLint disabled count

id before after diff
security 56 55 -1
securitySolution 525 527 +2
total +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @watson

@watson watson mentioned this pull request Aug 10, 2023
Draft
achyutjhunjhunwala
achyutjhunjhunwala approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@achyutjhunjhunwala achyutjhunjhunwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes are good to go 👍🏼

tomsonpl
tomsonpl approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defend Workflows LGTM, impressive effort, good luck with merging 🤞

patrykkopycinski
patrykkopycinski approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @watson 🙇

@paul-tavares paul-tavares requested review from patrykkopycinski and tomsonpl and removed request for paul-tavares August 10, 2023 14:22
@paul-tavares
Copy link
Contributor

Hey @tomsonpl , @patrykkopycinski ,
I added you to this PR since the files impacted for our team are OSQuery related. Can you take a look when you get a chance and 👍 it?

🙏

sphilipse
sphilipse approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ent-search changes LGTM

stephmilovic
stephmilovic approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for explore changes

@watson watson merged commit 99db840 into elastic:main Aug 10, 2023
@watson watson deleted the bump-eslint branch August 10, 2023 22:32
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 7.17:
- Upgrade re2 from v1.17.7 to v1.20.1 (#162880)

Manual backport

To create the backport manually run:

node scripts/backport --pr 162309

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@watson watson mentioned this pull request Aug 14, 2023
Draft
@watson watson removed auto-backport Deprecated - use backport:version if exact versions are needed v7.17.13 labels Aug 14, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 14, 2023
@watson
Copy link
Contributor Author

watson commented Aug 14, 2023

Removed automatic backport labels due to manual backport in #163792

This was referenced Aug 15, 2023
Merged
Merged
@kibanamachine kibanamachine mentioned this pull request Jan 26, 2024
Merged
@kibanamachine kibanamachine mentioned this pull request Mar 13, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphilipse sphilipse sphilipse approved these changes

@Ikuni17 Ikuni17 Ikuni17 approved these changes

@achyutjhunjhunwala achyutjhunjhunwala achyutjhunjhunwala approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

@thomheymann thomheymann thomheymann approved these changes

@dasansol92 dasansol92 Awaiting requested review from dasansol92 dasansol92 is a code owner automatically assigned from elastic/security-defend-workflows

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski

@tomsonpl tomsonpl Awaiting requested review from tomsonpl

Assignees

@watson watson

Labels
apm:cypress-record cypress test runs will be recorded to the cypress dashboard backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.