[7.17] Upgrade ESLint to v8 (#162309) #163792
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
added
release_note:skip
watson
changed the title
This reverts commit 2238fb6.
watson
force-pushed
the
backport-eslint
branch
from
e4759ca to
5843834
Compare
watson
commented
Aug 14, 2023
Comment on lines
-1681
to
-1682
| ...require('eslint-config-prettier/react').rules, | ||
| ...require('eslint-config-prettier/@typescript-eslint').rules, |
There was a problem hiding this comment.
These two rule-sets are now included in the base rule-set, so no need to manually require them anymore
watson
commented
Aug 14, 2023
| @@ -6,7 +6,7 @@ | |||
| const semver = require('semver'); | |||
| const { kibanaPackageJson: PKG } = require('@kbn/dev-utils'); | |||
|
|
|||
| const eslintConfigPrettierTypescriptEslintRules = require('eslint-config-prettier/@typescript-eslint').rules; | |||
There was a problem hiding this comment.
The @typescript-eslint rule-set is now included in the base rule-set
watson
added
backport
and removed
release_note:skip
watson
changed the title
Merged
watson
force-pushed
the
backport-eslint
branch
from
afa1179 to
909f8ae
Compare
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @watson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual backport of "Upgrade ESLint to v8" (PR #162309). To avoid conflicts, this PR also backports the following 3 commits from
main:Updated direct dependencies
@types/eslinteslintCHANGELOG.mdeslint-config-prettierCHANGELOG.mdeslint-import-resolver-nodeCHANGELOG.mdeslint-import-resolver-webpackCHANGELOG.mdeslint-module-utilsCHANGELOG.mdeslint-plugin-baneslint-plugin-cypresseslint-plugin-importCHANGELOG.mdeslint-plugin-jsx-a11yCHANGELOG.mdeslint-plugin-mochaCHANGELOG.mdeslint-plugin-no-unsanitizedNote to reviewers
The vast majority of files touched by this PR is changes to the
importorder due to minor fixes in theimport/orderrule.In reality there are so many differences between
mainand7.17, that the commit for "Upgrade ESLint to v8" couldn't easily be backported. It was quicker to copy over what made sense manually, and recreate the rest. The main changes are (besides the 3 commits above), in the following separate commits in this PR for easier reviewing: