Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Node.js to 18.17.1 #163710

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Upgrade Node.js to 18.17.1 #163710

merged 3 commits into from
Aug 14, 2023

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Aug 11, 2023 •
edited by kibanamachine
Loading

@jbudz jbudz added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes labels Aug 11, 2023
@github-actions
Copy link
Contributor

Documentation preview:

@jbudz
Copy link
Member Author

jbudz commented Aug 11, 2023

ed66aa9 fixed the workspace.bazel checksums. I was referencing our glibc 2.17 node builds instead of the default distribution.

@jbudz jbudz marked this pull request as ready for review August 11, 2023 15:43
@jbudz jbudz requested a review from a team as a code owner August 11, 2023 15:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit 41d8296 into elastic:main Aug 14, 2023
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Aug 14, 2023
@delanni delanni added v7.17.13 backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development and removed backport:skip This commit does not require backporting labels Aug 15, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 7.17:
- Upgrade ESLint to v8 (#162309)
❌ 8.9 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 163710

Questions ?

Please refer to the Backport tool documentation

@delanni delanni mentioned this pull request Aug 15, 2023
Merged
@delanni
Copy link
Contributor

delanni commented Aug 15, 2023

💚 All backports created successfully

Status Branch Result
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

delanni pushed a commit to delanni/kibana that referenced this pull request Aug 15, 2023
@jbudz @delanni
Upgrade Node.js to 18.17.1 (elastic#163710)
43e157e 
https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#18.17.1
(cherry picked from commit 41d8296)

# Conflicts:
#	docs/developer/advanced/upgrading-nodejs.asciidoc
#	package.json
delanni added a commit that referenced this pull request Aug 15, 2023
@delanni @jbudz
[7.17] Upgrade Node.js to 18.17.1 (#163710) (#163916)
21e122e 
# Backport

This will backport the following commits from `main` to `7.17`:
- [Upgrade Node.js to 18.17.1
(#163710)](#163710)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-14T17:08:27Z","message":"Upgrade
Node.js to 18.17.1
(#163710)\n\nhttps://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#18.17.1","sha":"41d8296db7a1d6548f11403b73797d34472c4b39","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:prev-MAJOR","v8.10.0","v7.17.13"],"number":163710,"url":"https://github.com/elastic/kibana/pull/163710","mergeCommit":{"message":"Upgrade
Node.js to 18.17.1
(#163710)\n\nhttps://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#18.17.1","sha":"41d8296db7a1d6548f11403b73797d34472c4b39"}},"sourceBranch":"main","suggestedTargetBranches":["7.17"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163710","number":163710,"mergeCommit":{"message":"Upgrade
Node.js to 18.17.1
(#163710)\n\nhttps://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#18.17.1","sha":"41d8296db7a1d6548f11403b73797d34472c4b39"}},{"branch":"7.17","label":"v7.17.13","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jon <[email protected]>
bryce-b pushed a commit that referenced this pull request Aug 17, 2023
@jbudz @bryce-b
Upgrade Node.js to 18.17.1 (#163710)
f191578 
https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#18.17.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ikuni17 Ikuni17 Ikuni17 approved these changes

Assignees
No one assigned
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.13 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jbudz @elasticmachine @kibana-ci @kibanamachine @delanni @Ikuni17