chore(NA): disables FORCE_COLOR temporarily when executing node interpreter on the cloud artifacts deployment scripts #162742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
mistic
added
chore
Team:Operations
mistic
changed the title
|
Pinging @elastic/kibana-operations (Team:Operations) |
mistic
changed the title
mistic
changed the title
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
HistoryTo update your PR or re-run it, just comment with: |
watson
reviewed
Jul 31, 2023
jbudz
approved these changes
Jul 31, 2023
mistic
added
backport:prev-minor
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 31, 2023
…preter on the cloud artifacts deployment scripts (elastic#162742) Closes elastic#162756 This PR fixes a problem introduced after the merge of elastic#160289 Looks like the behaviour of node regarding the use of the `FORCE_COLOR` flag is now propagated differently when cashing the output of a given node interpreter run in a bash variable which was affecting the script and making it to fail when casting a number string to a number. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit f981722)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mistic
added a commit
that referenced
this pull request
Jul 31, 2023
… interpreter on the cloud artifacts deployment scripts (#162742) (#162843) # Backport This will backport the following commits from `main` to `8.9`: - [chore(NA): disables FORCE_COLOR temporarily when executing node interpreter on the cloud artifacts deployment scripts (#162742)](#162742) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Costa","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-31T19:57:21Z","message":"chore(NA): disables FORCE_COLOR temporarily when executing node interpreter on the cloud artifacts deployment scripts (#162742)\n\nCloses https://github.com/elastic/kibana/issues/162756\r\n\r\nThis PR fixes a problem introduced after the merge of\r\nhttps://github.com//pull/160289\r\n\r\nLooks like the behaviour of node regarding the use of the `FORCE_COLOR`\r\nflag is now propagated differently when cashing the output of a given\r\nnode interpreter run in a bash variable which was affecting the script\r\nand making it to fail when casting a number string to a number.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"f98172291af44055f1e3ec7a8d55bbf4dacd5f18","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","backport:all-open","v8.10.0"],"number":162742,"url":"https://github.com/elastic/kibana/pull/162742","mergeCommit":{"message":"chore(NA): disables FORCE_COLOR temporarily when executing node interpreter on the cloud artifacts deployment scripts (#162742)\n\nCloses https://github.com/elastic/kibana/issues/162756\r\n\r\nThis PR fixes a problem introduced after the merge of\r\nhttps://github.com//pull/160289\r\n\r\nLooks like the behaviour of node regarding the use of the `FORCE_COLOR`\r\nflag is now propagated differently when cashing the output of a given\r\nnode interpreter run in a bash variable which was affecting the script\r\nand making it to fail when casting a number string to a number.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"f98172291af44055f1e3ec7a8d55bbf4dacd5f18"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162742","number":162742,"mergeCommit":{"message":"chore(NA): disables FORCE_COLOR temporarily when executing node interpreter on the cloud artifacts deployment scripts (#162742)\n\nCloses https://github.com/elastic/kibana/issues/162756\r\n\r\nThis PR fixes a problem introduced after the merge of\r\nhttps://github.com//pull/160289\r\n\r\nLooks like the behaviour of node regarding the use of the `FORCE_COLOR`\r\nflag is now propagated differently when cashing the output of a given\r\nnode interpreter run in a bash variable which was affecting the script\r\nand making it to fail when casting a number string to a number.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"f98172291af44055f1e3ec7a8d55bbf4dacd5f18"}}]}] BACKPORT--> Co-authored-by: Tiago Costa <[email protected]>
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
…preter on the cloud artifacts deployment scripts (elastic#162742) Closes elastic#162756 This PR fixes a problem introduced after the merge of elastic#160289 Looks like the behaviour of node regarding the use of the `FORCE_COLOR` flag is now propagated differently when cashing the output of a given node interpreter run in a bash variable which was affecting the script and making it to fail when casting a number string to a number. --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #162756
This PR fixes a problem introduced after the merge of #160289
Looks like the behaviour of node regarding the use of the
FORCE_COLORflag is now propagated differently when cashing the output of a given node interpreter run in a bash variable which was affecting the script and making it to fail when casting a number string to a number.