Upgrade Typescript to 4.3.5 #104470

tylersmalley · 2021-07-06T14:39:59Z

Closes #100563

Blockers:

PRs:

Release Notes:

microsoft/TypeScript#43194

TODO after merge:

Create issues for added ts-ignore/ts-expect-error for teams
Create issues for removal of resize-observer-polyfill

tylersmalley · 2021-07-20T23:25:20Z

@dgieselaar mind taking a look at this? Looks like you added last week.

16:22:29   info [bazel] packages/kbn-typed-react-router-config/src/create_router.ts:148:3 - error TS2589: Type instantiation is excessively deep and possibly infinite.
16:22:29   info [bazel] 
16:22:29   info [bazel] 148   return {
16:22:29   info [bazel]       ~~~~~~~~
16:22:29   info [bazel] 149     link: (path, ...args) => {
16:22:29   info [bazel]     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
16:22:29   info [bazel] ... 
16:22:29   info [bazel] 163     },
16:22:29   info [bazel]     ~~~~~~
16:22:29   info [bazel] 164   };
16:22:29   info [bazel]     ~~~~

dgieselaar · 2021-07-21T10:12:16Z

@tylersmalley fixed the errors in @kbn/typed-react-router-config and some other APM-related type errors. I'll probably have to do a few more passes as other teams start fixing theirs.

tylersmalley · 2021-08-02T18:44:34Z

@elasticmachine merge upstream

mistic · 2021-08-03T01:41:05Z

@elasticmachine merge upstream

Signed-off-by: Tyler Smalley <[email protected]>

tylersmalley · 2021-08-12T21:32:42Z

Someone from @elastic/kibana-core mind taking a look at these failures from bootstrap/build_ts_refs?

view errors

[ts refs]  proc [tsc] src/core/server/http/router/response_adapter.ts:102:36 - error TS2339: Property 'location' does not exist on type 'ResponseHeaders'.
[ts refs]  proc [tsc]   Property 'location' does not exist on type 'Record<never, string | string[]>'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 102     if (!headers || typeof headers.location !== 'string') {
[ts refs]  proc [tsc]                                        ~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] src/core/server/http/router/response_adapter.ts:108:25 - error TS2339: Property 'location' does not exist on type 'ResponseHeaders'.
[ts refs]  proc [tsc]   Property 'location' does not exist on type 'Record<never, string | string[]>'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 108       .redirect(headers.location)
[ts refs]  proc [tsc]                             ~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] src/core/public/http/fetch.ts:184:5 - error TS2322: Type '(pathOrOptions: string | HttpFetchOptionsWithPath, options?: HttpFetchOptions | undefined) => Promise<TResponseBody>' is not assignable to type 'HttpHandler'.
[ts refs]  proc [tsc]   Type 'Promise<TResponseBody>' is not assignable to type 'Promise<HttpResponse<any>>'.
[ts refs]  proc [tsc]     Type 'TResponseBody' is not assignable to type 'HttpResponse<any>'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 184     return (pathOrOptions: string | HttpFetchOptionsWithPath, options?: HttpFetchOptions) => {
[ts refs]  proc [tsc]         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 185       const optionsWithPath = validateFetchArguments(pathOrOptions, options);
[ts refs]  proc [tsc]     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 186       return this.fetch({ ...optionsWithPath, method });
[ts refs]  proc [tsc]     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 187     };
[ts refs]  proc [tsc]     ~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] src/core/server/http/http_service.mock.ts:82:9 - error TS2322: Type '{ registerRoutes: jest.Mock<any, any>; registerRouteHandlerContext: jest.Mock<any, any>; registerStaticDir: jest.Mock<any, any>; basePath: BasePathMocked; csp: CspConfig; externalUrl: ExternalUrlConfig; auth: AuthMocked; }' is not assignable to type 'InternalHttpServicePrebootMock'.
[ts refs]  proc [tsc]   Property 'server' is missing in type '{ registerRoutes: jest.Mock<any, any>; registerRouteHandlerContext: jest.Mock<any, any>; registerStaticDir: jest.Mock<any, any>; basePath: BasePathMocked; csp: CspConfig; externalUrl: ExternalUrlConfig; auth: AuthMocked; }' but required in type '{ registerRouteHandlerContext: MockInstance<IContextContainer, [pluginOpaqueId: symbol, contextName: "core", provider: RequestHandlerContextProvider<RequestHandlerContext, "core">]>; ... 5 more ...; registerRoutes: MockInstance<...>; }'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 82   const mock: InternalHttpServicePrebootMock = {
[ts refs]  proc [tsc]            ~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc]   src/core/server/http/types.ts:387:3
[ts refs]  proc [tsc]     387   server: HttpServerSetup['server'];
[ts refs]  proc [tsc]           ~~~~~~
[ts refs]  proc [tsc]     'server' is declared here.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] src/core/server/http/http_service.mock.ts:106:9 - error TS2322: Type '{ server: jest.MockedClass<Server>; createCookieSessionStorageFactory: jest.Mock<any, any>; registerOnPreRouting: jest.Mock<any, any>; registerOnPreAuth: jest.Mock<...>; ... 12 more ...; registerPrebootRoutes: jest.Mock<...>; }' is not assignable to type 'InternalHttpServiceSetupMock'.
[ts refs]  proc [tsc]   Property 'registerRouterAfterListening' is missing in type '{ server: jest.MockedClass<Server>; createCookieSessionStorageFactory: jest.Mock<any, any>; registerOnPreRouting: jest.Mock<any, any>; registerOnPreAuth: jest.Mock<...>; ... 12 more ...; registerPrebootRoutes: jest.Mock<...>; }' but required in type '{ registerRouteHandlerContext: MockInstance<IContextContainer, [pluginOpaqueId: symbol, contextName: "core", provider: RequestHandlerContextProvider<RequestHandlerContext, "core">]>; ... 14 more ...; registerPrebootRoutes: MockInstance<...>; }'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 106   const mock: InternalHttpServiceSetupMock = {
[ts refs]  proc [tsc]             ~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc]   src/core/server/http/types.ts:393:3
[ts refs]  proc [tsc]     393   registerRouterAfterListening: (router: IRouter) => void;
[ts refs]  proc [tsc]           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc]     'registerRouterAfterListening' is declared here.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] Found 5 errors.
[ts refs]  proc [tsc]

mshustov · 2021-08-13T08:46:55Z

src/core/server/http/router/headers.ts


 /**
 * Http response headers to set.
 * @public
 */
-export type ResponseHeaders =
-  | Record<KnownHeaders, string | string[]>


KnownHeaders helper is broken, I didn't manage to fix it quickly. Its only purpose is to improve autocomplete in IDE, so I removed it for time being. I will fix it later.

Ran into the same issue in Fleet. Just replacing with a string[] for now.

kibana/x-pack/plugins/fleet/server/routes/epm/handlers.ts

Line 164 in 3a434d7

const headersToProxy: KnownHeaders[] = ['content-type', 'cache-control'];

mshustov · 2021-08-13T08:47:49Z

@tylersmalley fixed the Core errors

Signed-off-by: Tyler Smalley <[email protected]>

tylersmalley · 2021-08-26T20:33:50Z

@elastic/kibana-app can you please assist with the following errors in your plugins while bootstrapping? Thanks

view errors

[ts refs]  proc [tsc] src/plugins/kibana_legacy/public/angular/angular_config.tsx:86:30 - error TS2345: Argument of type 'CoreStart | { core: CoreStart; readonly env: { mode: Readonly<EnvironmentMode>; packageInfo: Readonly<PackageInfo>; }; }' is not assignable to parameter of type 'CoreStart'.
[ts refs]  proc [tsc]   Type '{ core: CoreStart; readonly env: { mode: Readonly<EnvironmentMode>; packageInfo: Readonly<PackageInfo>; }; }' is missing the following properties from type 'CoreStart': application, chrome, docLinks, http, and 8 more.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 86     .value('esUrl', getEsUrl(core))
[ts refs]  proc [tsc]                                 ~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] src/plugins/kibana_legacy/public/angular/angular_config.tsx:87:35 - error TS2339: Property 'application' does not exist on type 'CoreStart | { core: CoreStart; readonly env: { mode: Readonly<EnvironmentMode>; packageInfo: Readonly<PackageInfo>; }; }'.
[ts refs]  proc [tsc]   Property 'application' does not exist on type '{ core: CoreStart; readonly env: { mode: Readonly<EnvironmentMode>; packageInfo: Readonly<PackageInfo>; }; }'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 87     .value('uiCapabilities', core.application.capabilities)
[ts refs]  proc [tsc]                                      ~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] src/plugins/kibana_legacy/public/angular/angular_config.tsx:91:35 - error TS2345: Argument of type 'CoreStart | { core: CoreStart; readonly env: { mode: Readonly<EnvironmentMode>; packageInfo: Readonly<PackageInfo>; }; }' is not assignable to parameter of type 'CoreStart'.
[ts refs]  proc [tsc]   Type '{ core: CoreStart; readonly env: { mode: Readonly<EnvironmentMode>; packageInfo: Readonly<PackageInfo>; }; }' is not assignable to type 'CoreStart'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 91     .run(capture$httpLoadingCount(core))
[ts refs]  proc [tsc]                                      ~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] src/plugins/kibana_legacy/public/angular/angular_config.tsx:93:37 - error TS2345: Argument of type 'CoreStart | { core: CoreStart; readonly env: { mode: Readonly<EnvironmentMode>; packageInfo: Readonly<PackageInfo>; }; }' is not assignable to parameter of type 'CoreStart'.
[ts refs]  proc [tsc]   Type '{ core: CoreStart; readonly env: { mode: Readonly<EnvironmentMode>; packageInfo: Readonly<PackageInfo>; }; }' is not assignable to type 'CoreStart'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 93     .run($setupBreadcrumbsAutoClear(core, isLocalAngular))
[ts refs]  proc [tsc]                                        ~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] src/plugins/kibana_legacy/public/angular/angular_config.tsx:94:31 - error TS2345: Argument of type 'CoreStart | { core: CoreStart; readonly env: { mode: Readonly<EnvironmentMode>; packageInfo: Readonly<PackageInfo>; }; }' is not assignable to parameter of type 'CoreStart'.
[ts refs]  proc [tsc]   Type '{ core: CoreStart; readonly env: { mode: Readonly<EnvironmentMode>; packageInfo: Readonly<PackageInfo>; }; }' is not assignable to type 'CoreStart'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 94     .run($setupBadgeAutoClear(core, isLocalAngular))
[ts refs]  proc [tsc]                                  ~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] src/plugins/kibana_legacy/public/angular/angular_config.tsx:95:39 - error TS2345: Argument of type 'CoreStart | { core: CoreStart; readonly env: { mode: Readonly<EnvironmentMode>; packageInfo: Readonly<PackageInfo>; }; }' is not assignable to parameter of type 'CoreStart'.
[ts refs]  proc [tsc]   Type '{ core: CoreStart; readonly env: { mode: Readonly<EnvironmentMode>; packageInfo: Readonly<PackageInfo>; }; }' is not assignable to type 'CoreStart'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 95     .run($setupHelpExtensionAutoClear(core, isLocalAngular))
[ts refs]  proc [tsc]                                          ~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] src/plugins/kibana_legacy/public/angular/angular_config.tsx:96:37 - error TS2345: Argument of type 'CoreStart | { core: CoreStart; readonly env: { mode: Readonly<EnvironmentMode>; packageInfo: Readonly<PackageInfo>; }; }' is not assignable to parameter of type 'CoreStart'.
[ts refs]  proc [tsc]   Type '{ core: CoreStart; readonly env: { mode: Readonly<EnvironmentMode>; packageInfo: Readonly<PackageInfo>; }; }' is not assignable to type 'CoreStart'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 96     .run($setupUICapabilityRedirect(core));
[ts refs]  proc [tsc]                                        ~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/index.ts:349:20 - error TS2590: Expression produces a union type that is too complex to represent.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 349     columnParams?: (IndexPatternColumn & C)['params']
[ts refs]  proc [tsc]                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/index.ts:390:20 - error TS2590: Expression produces a union type that is too complex to represent.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 390     columnParams?: (IndexPatternColumn & C)['params'] & {

tylersmalley · 2021-08-26T20:34:23Z

@elastic/kibana-app-services can you please assist with the following errors in your plugins while bootstrapping? Thanks

view errors

[ts refs]  proc [tsc] src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx:80:12 - error TS7053: Element implicitly has an 'any' type because expression of type '"attributes"' can't be used to index type 'ValType | RefType'.
[ts refs]  proc [tsc]   Property 'attributes' does not exist on type 'ValType | RefType'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 80     return input[ATTRIBUTE_SERVICE_KEY];
[ts refs]  proc [tsc]               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx:127:7 - error TS2322: Type 'ValType | RefType' is not assignable to type 'ValType'.
[ts refs]  proc [tsc]   'ValType' could be instantiated with an arbitrary type which could be unrelated to 'ValType | RefType'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 127       return input;
[ts refs]  proc [tsc]           ~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx:148:38 - error TS7053: Element implicitly has an 'any' type because expression of type '"attributes"' can't be used to index type 'ValType | RefType'.
[ts refs]  proc [tsc]   Property 'attributes' does not exist on type 'ValType | RefType'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 148           const newAttributes = { ...input[ATTRIBUTE_SERVICE_KEY] };
[ts refs]  proc [tsc]                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx:168:55 - error TS7053: Element implicitly has an 'any' type because expression of type '"attributes"' can't be used to index type 'ValType | RefType'.
[ts refs]  proc [tsc]   Property 'attributes' does not exist on type 'ValType | RefType'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 168             title={get(saveOptions, 'saveModalTitle', input[ATTRIBUTE_SERVICE_KEY].title)}
[ts refs]  proc [tsc]                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/number/number.tsx:29:3 - error TS2612: Property 'context' will overwrite the base property in 'DefaultFormatEditor<NumberFormatEditorParams, {}>'. If this is intentional, add an initializer. Otherwise, add a 'declare' modifier or remove the redundant declaration.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 29   context!: React.ContextType<typeof contextType>;
[ts refs]  proc [tsc]      ~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] src/plugins/index_pattern_management/public/components/field_editor/components/scripting_help/test_script.tsx:54:19 - error TS2612: Property 'context' will overwrite the base property in 'Component<TestScriptProps, TestScriptState, any>'. If this is intentional, add an initializer. Otherwise, add a 'declare' modifier or remove the redundant declaration.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 54   public readonly context!: IndexPatternManagmentContextValue;
[ts refs]  proc [tsc]                      ~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] src/plugins/index_pattern_management/public/components/field_editor/field_editor.tsx:131:19 - error TS2612: Property 'context' will overwrite the base property in 'PureComponent<FieldEdiorProps, FieldEditorState, any>'. If this is intentional, add an initializer. Otherwise, add a 'declare' modifier or remove the redundant declaration.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 131   public readonly context!: IndexPatternManagmentContextValue;
[ts refs]  proc [tsc]                       ~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/containers/drilldown_state_form/drilldown_state_form.tsx:45:9 - error TS2322: Type '{ config: SerializableRecord; onConfig: (config: SerializableRecord) => void; context: BaseActionFactoryContext; }' is not assignable to type 'IntrinsicAttributes & { children?: ReactNode; }'.
[ts refs]  proc [tsc]   Property 'config' does not exist on type 'IntrinsicAttributes & { children?: ReactNode; }'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 45         config={config}
[ts refs]  proc [tsc]            ~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/containers/form_drilldown_wizard/create_drilldown_form.tsx:39:9 - error TS2322: Type '{ config: SerializableRecord; onConfig: (config: SerializableRecord) => void; context: BaseActionFactoryContext; }' is not assignable to type 'IntrinsicAttributes & { children?: ReactNode; }'.
[ts refs]  proc [tsc]   Property 'config' does not exist on type 'IntrinsicAttributes & { children?: ReactNode; }'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 39         config={config}
[ts refs]  proc [tsc]            ~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/ui_actions_enhanced/public/components/action_wizard/action_wizard.tsx:301:11 - error TS2322: Type '{ config: SerializableRecord; onConfig: (config: SerializableRecord) => void; context: BaseActionFactoryContext; }' is not assignable to type 'IntrinsicAttributes & { children?: ReactNode; }'.
[ts refs]  proc [tsc]   Property 'config' does not exist on type 'IntrinsicAttributes & { children?: ReactNode; }'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 301           config={config}
[ts refs]  proc [tsc]               ~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/containers/form_drilldown_wizard/edit_drilldown_form.tsx:49:11 - error TS2322: Type '{ config: SerializableRecord; onConfig: (config: SerializableRecord) => void; context: BaseActionFactoryContext; }' is not assignable to type 'IntrinsicAttributes & { children?: ReactNode; }'.
[ts refs]  proc [tsc]   Property 'config' does not exist on type 'IntrinsicAttributes & { children?: ReactNode; }'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 49           config={config}
[ts refs]  proc [tsc]              ~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/examples/ui_actions_enhanced_examples/public/drilldowns/dashboard_to_discover_drilldown/drilldown.tsx:53:59 - error TS2729: Property 'ReactCollectConfig' is used before its initialization.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 53   public readonly CollectConfig = reactToUiComponent(this.ReactCollectConfig);
[ts refs]  proc [tsc]                                                              ~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc]   x-pack/examples/ui_actions_enhanced_examples/public/drilldowns/dashboard_to_discover_drilldown/drilldown.tsx:51:20
[ts refs]  proc [tsc]     51   private readonly ReactCollectConfig: React.FC<CollectConfigProps>;
[ts refs]  proc [tsc]                           ~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc]     'ReactCollectConfig' is declared here.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/examples/ui_actions_enhanced_examples/public/drilldowns/dashboard_to_discover_drilldown/drilldown.tsx:53:59 - error TS2729: Property 'ReactCollectConfig' is used before its initialization.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 53   public readonly CollectConfig = reactToUiComponent(this.ReactCollectConfig);
[ts refs]  proc [tsc]                                                              ~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc]   x-pack/examples/ui_actions_enhanced_examples/public/drilldowns/dashboard_to_discover_drilldown/drilldown.tsx:51:20
[ts refs]  proc [tsc]     51   private readonly ReactCollectConfig: React.FC<CollectConfigProps>;
[ts refs]  proc [tsc]                           ~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc]     'ReactCollectConfig' is declared here.

tylersmalley · 2021-08-26T20:34:54Z

@elastic/kibana-presentation can you please assist with the following errors in your plugins while bootstrapping? Thanks

view errors

[ts refs]  proc [tsc] src/plugins/dashboard/public/application/embeddable/viewport/dashboard_viewport.tsx:33:19 - error TS2612: Property 'context' will overwrite the base property in 'Component<DashboardViewportProps, State, any>'. If this is intentional, add an initializer. Otherwise, add a 'declare' modifier or remove the redundant declaration.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 33   public readonly context!: DashboardReactContextValue;
[ts refs]  proc [tsc]                      ~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] src/plugins/input_control_vis/public/components/vis/input_control_vis.tsx:93:60 - error TS2339: Property 'type' does not exist on type 'never'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 93         throw new Error(`Unhandled control type ${control!.type}`)

tylersmalley · 2021-08-26T20:36:09Z

@elastic/security-solution can you please assist with the following errors in your plugins while bootstrapping? Thanks

view errors

[ts refs]  proc [tsc] x-pack/plugins/timelines/public/components/t_grid/body/column_headers/actions/index.tsx:57:29 - error TS2769: No overload matches this call.
[ts refs]  proc [tsc]   Overload 1 of 2, '(props: Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | "css" | keyof HTMLAttributes<...>> & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }): ReactElement<...>', gave the following error.
[ts refs]  proc [tsc]     Type '"siemEventsHeading__extra--loading"' is not assignable to type '(string & `siemEventsHeading__extra ${string}`) | undefined'.
[ts refs]  proc [tsc]   Overload 2 of 2, '(props: StyledComponentPropsWithAs<"div", any, { className: `siemEventsHeading__extra ${string}`; }, "className">): ReactElement<StyledComponentPropsWithAs<"div", any, { className: `siemEventsHeading__extra ${string}`; }, "className">, string | JSXElementConstructor<...>>', gave the following error.
[ts refs]  proc [tsc]     Type '"siemEventsHeading__extra--loading"' is not assignable to type '(string & `siemEventsHeading__extra ${string}`) | undefined'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 57         <EventsHeadingExtra className="siemEventsHeading__extra--loading">
[ts refs]  proc [tsc]                                ~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc]   node_modules/@types/react/index.d.ts:1749:9
[ts refs]  proc [tsc]     1749         className?: string;
[ts refs]  proc [tsc]                  ~~~~~~~~~
[ts refs]  proc [tsc]     The expected type comes from property 'className' which is declared here on type 'IntrinsicAttributes & Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | ... 1 more ... | keyof HTMLAttributes<...>> & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }'
[ts refs]  proc [tsc]   node_modules/@types/react/index.d.ts:1749:9
[ts refs]  proc [tsc]     1749         className?: string;
[ts refs]  proc [tsc]                  ~~~~~~~~~
[ts refs]  proc [tsc]     The expected type comes from property 'className' which is declared here on type 'IntrinsicAttributes & Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | ... 1 more ... | keyof HTMLAttributes<...>> & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }'
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/timelines/public/components/t_grid/body/column_headers/actions/index.tsx:61:29 - error TS2769: No overload matches this call.
[ts refs]  proc [tsc]   Overload 1 of 2, '(props: Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | "css" | keyof HTMLAttributes<...>> & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }): ReactElement<...>', gave the following error.
[ts refs]  proc [tsc]     Type '"siemEventsHeading__extra--close"' is not assignable to type '(string & `siemEventsHeading__extra ${string}`) | undefined'.
[ts refs]  proc [tsc]   Overload 2 of 2, '(props: StyledComponentPropsWithAs<"div", any, { className: `siemEventsHeading__extra ${string}`; }, "className">): ReactElement<StyledComponentPropsWithAs<"div", any, { className: `siemEventsHeading__extra ${string}`; }, "className">, string | JSXElementConstructor<...>>', gave the following error.
[ts refs]  proc [tsc]     Type '"siemEventsHeading__extra--close"' is not assignable to type '(string & `siemEventsHeading__extra ${string}`) | undefined'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 61         <EventsHeadingExtra className="siemEventsHeading__extra--close">
[ts refs]  proc [tsc]                                ~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc]   node_modules/@types/react/index.d.ts:1749:9
[ts refs]  proc [tsc]     1749         className?: string;
[ts refs]  proc [tsc]                  ~~~~~~~~~
[ts refs]  proc [tsc]     The expected type comes from property 'className' which is declared here on type 'IntrinsicAttributes & Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | ... 1 more ... | keyof HTMLAttributes<...>> & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }'
[ts refs]  proc [tsc]   node_modules/@types/react/index.d.ts:1749:9
[ts refs]  proc [tsc]     1749         className?: string;
[ts refs]  proc [tsc]                  ~~~~~~~~~
[ts refs]  proc [tsc]     The expected type comes from property 'className' which is declared here on type 'IntrinsicAttributes & Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | ... 1 more ... | keyof HTMLAttributes<...>> & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }'
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/timelines/public/components/t_grid/body/renderers/row_renderer.tsx:17:23 - error TS2769: No overload matches this call.
[ts refs]  proc [tsc]   Overload 1 of 2, '(props: Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | "css" | keyof HTMLAttributes<...>> & { ...; } & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }): ReactElement<...>', gave the following error.
[ts refs]  proc [tsc]     Type '"siemEventsTable__trSupplement--summary"' is not assignable to type '(string & `siemEventsTable__trSupplement ${string}`) | undefined'.
[ts refs]  proc [tsc]   Overload 2 of 2, '(props: StyledComponentPropsWithAs<"div", any, { className: `siemEventsTable__trSupplement ${string}`; } & { className: string; }, "className">): ReactElement<StyledComponentPropsWithAs<"div", any, { className: `siemEventsTable__trSupplement ${string}`; } & { ...; }, "className">, string | JSXElementConstructor<...>>', gave the following error.
[ts refs]  proc [tsc]     Type '"siemEventsTable__trSupplement--summary"' is not assignable to type '(string & `siemEventsTable__trSupplement ${string}`) | undefined'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 17   <EventsTrSupplement className="siemEventsTable__trSupplement--summary">
[ts refs]  proc [tsc]                          ~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc]   node_modules/@types/react/index.d.ts:1749:9
[ts refs]  proc [tsc]     1749         className?: string;
[ts refs]  proc [tsc]                  ~~~~~~~~~
[ts refs]  proc [tsc]     The expected type comes from property 'className' which is declared here on type 'IntrinsicAttributes & Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | ... 1 more ... | keyof HTMLAttributes<...>> & { ...; } & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }'
[ts refs]  proc [tsc]   node_modules/@types/react/index.d.ts:1749:9
[ts refs]  proc [tsc]     1749         className?: string;
[ts refs]  proc [tsc]                  ~~~~~~~~~
[ts refs]  proc [tsc]     The expected type comes from property 'className' which is declared here on type 'IntrinsicAttributes & Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | ... 1 more ... | keyof HTMLAttributes<...>> & { ...; } & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }'
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/security_solution/public/timelines/components/timeline/body/renderers/row_renderer.tsx:16:23 - error TS2769: No overload matches this call.
[ts refs]  proc [tsc]   Overload 1 of 2, '(props: Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | "css" | keyof HTMLAttributes<...>> & { ...; } & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }): ReactElement<...>', gave the following error.
[ts refs]  proc [tsc]     Type '"siemEventsTable__trSupplement--summary"' is not assignable to type '(string & `siemEventsTable__trSupplement ${string}`) | undefined'.
[ts refs]  proc [tsc]   Overload 2 of 2, '(props: StyledComponentPropsWithAs<"div", any, { className: `siemEventsTable__trSupplement ${string}`; } & { className: string; }, "className">): ReactElement<StyledComponentPropsWithAs<"div", any, { className: `siemEventsTable__trSupplement ${string}`; } & { ...; }, "className">, string | JSXElementConstructor<...>>', gave the following error.
[ts refs]  proc [tsc]     Type '"siemEventsTable__trSupplement--summary"' is not assignable to type '(string & `siemEventsTable__trSupplement ${string}`) | undefined'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 16   <EventsTrSupplement className="siemEventsTable__trSupplement--summary">
[ts refs]  proc [tsc]                          ~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc]   node_modules/@types/react/index.d.ts:1749:9
[ts refs]  proc [tsc]     1749         className?: string;
[ts refs]  proc [tsc]                  ~~~~~~~~~
[ts refs]  proc [tsc]     The expected type comes from property 'className' which is declared here on type 'IntrinsicAttributes & Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | ... 1 more ... | keyof HTMLAttributes<...>> & { ...; } & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }'
[ts refs]  proc [tsc]   node_modules/@types/react/index.d.ts:1749:9
[ts refs]  proc [tsc]     1749         className?: string;
[ts refs]  proc [tsc]                  ~~~~~~~~~
[ts refs]  proc [tsc]     The expected type comes from property 'className' which is declared here on type 'IntrinsicAttributes & Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | ... 1 more ... | keyof HTMLAttributes<...>> & { ...; } & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }'
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/security_solution/public/timelines/components/timeline/body/column_headers/actions/index.tsx:58:29 - error TS2769: No overload matches this call.
[ts refs]  proc [tsc]   Overload 1 of 2, '(props: Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | "css" | keyof HTMLAttributes<...>> & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }): ReactElement<...>', gave the following error.
[ts refs]  proc [tsc]     Type '"siemEventsHeading__extra--loading"' is not assignable to type '(string & `siemEventsHeading__extra ${string}`) | undefined'.
[ts refs]  proc [tsc]   Overload 2 of 2, '(props: StyledComponentPropsWithAs<"div", any, { className: `siemEventsHeading__extra ${string}`; }, "className">): ReactElement<StyledComponentPropsWithAs<"div", any, { className: `siemEventsHeading__extra ${string}`; }, "className">, string | JSXElementConstructor<...>>', gave the following error.
[ts refs]  proc [tsc]     Type '"siemEventsHeading__extra--loading"' is not assignable to type '(string & `siemEventsHeading__extra ${string}`) | undefined'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 58         <EventsHeadingExtra className="siemEventsHeading__extra--loading">
[ts refs]  proc [tsc]                                ~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc]   node_modules/@types/react/index.d.ts:1749:9
[ts refs]  proc [tsc]     1749         className?: string;
[ts refs]  proc [tsc]                  ~~~~~~~~~
[ts refs]  proc [tsc]     The expected type comes from property 'className' which is declared here on type 'IntrinsicAttributes & Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | ... 1 more ... | keyof HTMLAttributes<...>> & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }'
[ts refs]  proc [tsc]   node_modules/@types/react/index.d.ts:1749:9
[ts refs]  proc [tsc]     1749         className?: string;
[ts refs]  proc [tsc]                  ~~~~~~~~~
[ts refs]  proc [tsc]     The expected type comes from property 'className' which is declared here on type 'IntrinsicAttributes & Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | ... 1 more ... | keyof HTMLAttributes<...>> & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }'
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/security_solution/public/timelines/components/timeline/body/column_headers/actions/index.tsx:62:29 - error TS2769: No overload matches this call.
[ts refs]  proc [tsc]   Overload 1 of 2, '(props: Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | "css" | keyof HTMLAttributes<...>> & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }): ReactElement<...>', gave the following error.
[ts refs]  proc [tsc]     Type '"siemEventsHeading__extra--close"' is not assignable to type '(string & `siemEventsHeading__extra ${string}`) | undefined'.
[ts refs]  proc [tsc]   Overload 2 of 2, '(props: StyledComponentPropsWithAs<"div", any, { className: `siemEventsHeading__extra ${string}`; }, "className">): ReactElement<StyledComponentPropsWithAs<"div", any, { className: `siemEventsHeading__extra ${string}`; }, "className">, string | JSXElementConstructor<...>>', gave the following error.
[ts refs]  proc [tsc]     Type '"siemEventsHeading__extra--close"' is not assignable to type '(string & `siemEventsHeading__extra ${string}`) | undefined'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 62         <EventsHeadingExtra className="siemEventsHeading__extra--close">
[ts refs]  proc [tsc]                                ~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc]   node_modules/@types/react/index.d.ts:1749:9
[ts refs]  proc [tsc]     1749         className?: string;
[ts refs]  proc [tsc]                  ~~~~~~~~~
[ts refs]  proc [tsc]     The expected type comes from property 'className' which is declared here on type 'IntrinsicAttributes & Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | ... 1 more ... | keyof HTMLAttributes<...>> & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }'
[ts refs]  proc [tsc]   node_modules/@types/react/index.d.ts:1749:9
[ts refs]  proc [tsc]     1749         className?: string;
[ts refs]  proc [tsc]                  ~~~~~~~~~
[ts refs]  proc [tsc]     The expected type comes from property 'className' which is declared here on type 'IntrinsicAttributes & Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | ... 1 more ... | keyof HTMLAttributes<...>> & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }'
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/security_solution/public/timelines/components/timeline/body/events/stateful_event.tsx:300:13 - error TS2769: No overload matches this call.
[ts refs]  proc [tsc]   Overload 1 of 2, '(props: Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | "css" | keyof HTMLAttributes<...>> & { ...; } & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }): ReactElement<...>', gave the following error.
[ts refs]  proc [tsc]     Type '"siemEventsTable__trSupplement--notes"' is not assignable to type '(string & `siemEventsTable__trSupplement ${string}`) | undefined'.
[ts refs]  proc [tsc]   Overload 2 of 2, '(props: StyledComponentPropsWithAs<"div", any, { className: `siemEventsTable__trSupplement ${string}`; } & { className: string; }, "className">): ReactElement<StyledComponentPropsWithAs<"div", any, { className: `siemEventsTable__trSupplement ${string}`; } & { ...; }, "className">, string | JSXElementConstructor<...>>', gave the following error.
[ts refs]  proc [tsc]     Type '"siemEventsTable__trSupplement--notes"' is not assignable to type '(string & `siemEventsTable__trSupplement ${string}`) | undefined'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 300             className="siemEventsTable__trSupplement--notes"
[ts refs]  proc [tsc]                 ~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc]   node_modules/@types/react/index.d.ts:1749:9
[ts refs]  proc [tsc]     1749         className?: string;
[ts refs]  proc [tsc]                  ~~~~~~~~~
[ts refs]  proc [tsc]     The expected type comes from property 'className' which is declared here on type 'IntrinsicAttributes & Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | ... 1 more ... | keyof HTMLAttributes<...>> & { ...; } & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }'
[ts refs]  proc [tsc]   node_modules/@types/react/index.d.ts:1749:9
[ts refs]  proc [tsc]     1749         className?: string;
[ts refs]  proc [tsc]                  ~~~~~~~~~
[ts refs]  proc [tsc]     The expected type comes from property 'className' which is declared here on type 'IntrinsicAttributes & Omit<Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | ... 1 more ... | keyof HTMLAttributes<...>> & { ...; } & { ...; } & { ...; }, "className"> & Partial<...>, "theme"> & { ...; } & { ...; }'
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/security_solution/public/management/index.ts:51:18 - error TS2352: Conversion of type '{ management: ImmutableReducer<CombinedState<{ policyDetails: PolicyDetailsState; endpoints: never; trustedApps: ImmutableObject<TrustedAppsListPageState>; eventFilters: ImmutableObject<...>; }>, ServerReturnedEndpointList | ... 71 more ... | EventFiltersForceRefresh>; }' to type 'ManagementPluginReducer' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
[ts refs]  proc [tsc]   The types returned by 'management(...)' are incompatible between these types.
[ts refs]  proc [tsc]     Type 'CombinedState<{ policyDetails: PolicyDetailsState; endpoints: never; trustedApps: ImmutableObject<TrustedAppsListPageState>; eventFilters: ImmutableObject<...>; }> | ImmutableObject<...>' is not comparable to type 'CombinedState<ManagementState>'.
[ts refs]  proc [tsc]       Type 'ImmutableObject<CombinedState<{ policyDetails: PolicyDetailsState; endpoints: never; trustedApps: ImmutableObject<TrustedAppsListPageState>; eventFilters: ImmutableObject<...>; }>>' is not comparable to type 'CombinedState<ManagementState>'.
[ts refs]  proc [tsc]         Type 'ImmutableObject<CombinedState<{ policyDetails: PolicyDetailsState; endpoints: never; trustedApps: ImmutableObject<TrustedAppsListPageState>; eventFilters: ImmutableObject<...>; }>>' is not comparable to type '{ policyDetails: PolicyDetailsState; endpoints: EndpointState; trustedApps: TrustedAppsListPageState; eventFilters: EventFiltersListPageState; }'.
[ts refs]  proc [tsc]           The types of 'eventFilters.entries' are incompatible between these types.
[ts refs]  proc [tsc]             The type 'readonly ImmutableObject<ImmutableObject<{ _version: string | undefined; comments: ({ comment: string; created_at: string; created_by: string; id: string; } & { updated_at?: string | undefined; updated_by?: string | undefined; })[]; ... 15 more ...; updated_by: string; }>>[]' is 'readonly' and cannot be assigned to the mutable type '{ _version: string | undefined; comments: ({ comment: string; created_at: string; created_by: string; id: string; } & { updated_at?: string | undefined; updated_by?: string | undefined; })[]; ... 15 more ...; updated_by: string; }[]'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 51         reducer: { management: managementReducer } as ManagementPluginReducer,
[ts refs]  proc [tsc]                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/security_solution/public/common/mock/utils.ts:64:15 - error TS2352: Conversion of type 'ImmutableReducer<CombinedState<{ policyDetails: PolicyDetailsState; endpoints: never; trustedApps: ImmutableObject<TrustedAppsListPageState>; eventFilters: ImmutableObject<...>; }>, ServerReturnedEndpointList | ... 71 more ... | EventFiltersForceRefresh>' to type 'Reducer<CombinedState<ManagementState>, AppAction>' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 64   management: managementReducer as ManagementPluginReducer['management'],
[ts refs]  proc [tsc]                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/security_solution/public/resolver/view/side_effect_simulator_factory.ts:103:49 - error TS2739: Type '{ target: Element; contentRect: DOMRect; }' is missing the following properties from type 'ResizeObserverEntry': borderBoxSize, contentBoxSize
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 103         const entries: ResizeObserverEntry[] = [{ target, contentRect }];
[ts refs]  proc [tsc]                                                     ~~~~~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/security_solution/server/lib/detection_engine/rule_execution_log/rule_registry_log_client/rule_registry_log_client.ts:149:7 - error TS2590: Expression produces a union type that is too complex to represent.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 149       result.aggregations.rules.buckets.map((bucket) => [
[ts refs]  proc [tsc]           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 150         bucket.key,
[ts refs]  proc [tsc]     ~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] ... 
[ts refs]  proc [tsc] 217         }),
[ts refs]  proc [tsc]     ~~~~~~~~~~~
[ts refs]  proc [tsc] 218       ])
[ts refs]  proc [tsc]     ~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/security_solution/server/endpoint/routes/trusted_apps/service.ts:187:76 - error TS2345: Argument of type 'PutTrustedAppUpdateRequest' is not assignable to parameter of type 'UpdateTrustedApp'.
[ts refs]  proc [tsc]   Type 'Readonly<{ description?: string | undefined; version?: unknown; } & { os: OperatingSystem; name: string; effectScope: Readonly<{} & { type: "global"; }> | Readonly<{} & { type: "policy"; policies: string[]; }>; entries: Readonly<...>[] | ... 1 more ... | Readonly<...>[]; }> & MacosLinuxConditionEntries' is not assignable to type 'UpdateTrustedApp'.
[ts refs]  proc [tsc]     Type 'Readonly<{ description?: string | undefined; version?: unknown; } & { os: OperatingSystem; name: string; effectScope: Readonly<{} & { type: "global"; }> | Readonly<{} & { type: "policy"; policies: string[]; }>; entries: Readonly<...>[] | ... 1 more ... | Readonly<...>[]; }> & MacosLinuxConditionEntries' is not assignable to type '{ name: string; description?: string | undefined; effectScope: EffectScope; } & MacosLinuxConditionEntries & { version?: string | undefined; }'.
[ts refs]  proc [tsc]       Type 'Readonly<{ description?: string | undefined; version?: unknown; } & { os: OperatingSystem; name: string; effectScope: Readonly<{} & { type: "global"; }> | Readonly<{} & { type: "policy"; policies: string[]; }>; entries: Readonly<...>[] | ... 1 more ... | Readonly<...>[]; }> & MacosLinuxConditionEntries' is not assignable to type '{ version?: string | undefined; }'.
[ts refs]  proc [tsc]         Types of property 'version' are incompatible.
[ts refs]  proc [tsc]           Type 'unknown' is not assignable to type 'string | undefined'.
[ts refs]  proc [tsc]             Type 'unknown' is not assignable to type 'string'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 187       updatedTrustedAppToUpdateExceptionListItemOptions(currentTrustedApp, updatedTrustedApp)
[ts refs]  proc [tsc]                                                                                ~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/security_solution/server/search_strategy/security_solution/index.ts:32:19 - error TS2339: Property 'factoryQueryType' does not exist on type 'StrategyRequestType<T>'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 32       if (request.factoryQueryType == null) {
[ts refs]  proc [tsc]                      ~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/security_solution/server/search_strategy/security_solution/index.ts:36:9 - error TS7053: Element implicitly has an 'any' type because expression of type 'any' can't be used to index type 'Record<FactoryQueryTypes, SecuritySolutionFactory<FactoryQueryTypes>>'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 36         securitySolutionFactory[request.factoryQueryType];
[ts refs]  proc [tsc]            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/security_solution/server/search_strategy/security_solution/index.ts:36:41 - error TS2339: Property 'factoryQueryType' does not exist on type 'StrategyRequestType<T>'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 36         securitySolutionFactory[request.factoryQueryType];

tylersmalley · 2021-08-26T20:36:43Z

~~@elastic/fleet can you please assist with the following errors in your plugins while bootstrapping? Thanks~~ done

view errors

[ts refs]  proc [tsc] x-pack/plugins/fleet/public/applications/fleet/sections/agents/error_pages/components/no_data_layout.tsx:21:3 - error TS2345: Argument of type '({ actionSection, title, modalClosePath, children }: { actionSection: any; title: any; modalClosePath: any; children: any; }) => Element' is not assignable to parameter of type 'FunctionComponent<LayoutProps> & ComponentType<any>'.
[ts refs]  proc [tsc]   Type '({ actionSection, title, modalClosePath, children }: { actionSection: any; title: any; modalClosePath: any; children: any; }) => Element' is not assignable to type 'FunctionComponent<LayoutProps> & ComponentClass<any, any>'.
[ts refs]  proc [tsc]     Type '({ actionSection, title, modalClosePath, children }: { actionSection: any; title: any; modalClosePath: any; children: any; }) => Element' is not assignable to type 'FunctionComponent<LayoutProps>'.
[ts refs]  proc [tsc]       Types of parameters '__0' and 'props' are incompatible.
[ts refs]  proc [tsc]         Type 'PropsWithChildren<LayoutProps>' is not assignable to type '{ actionSection: any; title: any; modalClosePath: any; children: any; }'.
[ts refs]  proc [tsc]           Property 'actionSection' is optional in type 'PropsWithChildren<LayoutProps>' but required in type '{ actionSection: any; title: any; modalClosePath: any; children: any; }'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 21 >(({ actionSection, title, modalClosePath, children }) => {
[ts refs]  proc [tsc]      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/fleet/public/applications/fleet/sections/agents/error_pages/components/no_data_layout.tsx:21:6 - error TS7031: Binding element 'actionSection' implicitly has an 'any' type.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 21 >(({ actionSection, title, modalClosePath, children }) => {
[ts refs]  proc [tsc]         ~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/fleet/public/applications/fleet/sections/agents/error_pages/components/no_data_layout.tsx:21:21 - error TS7031: Binding element 'title' implicitly has an 'any' type.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 21 >(({ actionSection, title, modalClosePath, children }) => {
[ts refs]  proc [tsc]                        ~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/fleet/public/applications/fleet/sections/agents/error_pages/components/no_data_layout.tsx:21:28 - error TS7031: Binding element 'modalClosePath' implicitly has an 'any' type.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 21 >(({ actionSection, title, modalClosePath, children }) => {
[ts refs]  proc [tsc]                               ~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/fleet/public/applications/fleet/sections/agents/error_pages/components/no_data_layout.tsx:21:44 - error TS7031: Binding element 'children' implicitly has an 'any' type.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 21 >(({ actionSection, title, modalClosePath, children }) => {
[ts refs]  proc [tsc]                                               ~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/fleet/server/routes/epm/handlers.ts:164:47 - error TS2322: Type 'string' is not assignable to type 'never'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 164       const headersToProxy: KnownHeaders[] = ['content-type', 'cache-control'];
[ts refs]  proc [tsc]                                                   ~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/fleet/server/routes/epm/handlers.ts:164:63 - error TS2322: Type 'string' is not assignable to type 'never'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 164       const headersToProxy: KnownHeaders[] = ['content-type', 'cache-control'];

tylersmalley · 2021-08-26T20:39:33Z

~~@elastic/apm-ui can you please assist with the following errors in your plugins while bootstrapping? Thanks~~

view errors

[ts refs]  proc [tsc] x-pack/plugins/apm/server/lib/service_map/get_service_anomalies.ts:121:9 - error TS2590: Expression produces a union type that is too complex to represent.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 121         serviceBuckets.filter((bucket) =>
[ts refs]  proc [tsc]             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 122           jobIds.includes(bucket.key.jobId as string)
[ts refs]  proc [tsc]     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 123         ),
[ts refs]  proc [tsc]     ~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/apm/server/lib/settings/agent_configuration/create_agent_config_index.ts:42:11 - error TS2322: Type '{ type: "keyword"; ignore_above: number; }' is not assignable to type 'MappingPropertyBase'.
[ts refs]  proc [tsc]   Object literal may only specify known properties, and 'type' does not exist in type 'MappingPropertyBase'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 42           type: 'keyword' as const,
[ts refs]  proc [tsc]              ~~~~~~~~~~~~~~~~~~~~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc]   node_modules/@elastic/elasticsearch/api/types.d.ts:3731:3
[ts refs]  proc [tsc]     3731   mapping?: MappingPropertyBase
[ts refs]  proc [tsc]            ~~~~~~~
[ts refs]  proc [tsc]     The expected type comes from property 'mapping' which is declared here on type 'MappingDynamicTemplate'
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/apm/server/lib/transaction_groups/fetcher.ts:202:71 - error TS2345: Argument of type 'JoinedReturnType<{ key: BucketKey; avg: number | null; } | { key: BucketKey; count: number; transactionType: string; } | { key: BucketKey; sum: number | null; }, { key: BucketKey; avg: number | null; } & { ...; } & { ...; }>' is not assignable to parameter of type '{ sum?: number | null | undefined; key: Key; avg?: number | null | undefined; count?: number | null | undefined; transactionType?: string | undefined; }[]'.
[ts refs]  proc [tsc]   Type 'Partial<{ key: BucketKey; avg: number | null; } & { key: BucketKey; count: number; transactionType: string; } & { key: BucketKey; sum: number | null; }> & ({ ...; } | ... 1 more ... | { ...; })' is not assignable to type '{ sum?: number | null | undefined; key: Key; avg?: number | null | undefined; count?: number | null | undefined; transactionType?: string | undefined; }'.
[ts refs]  proc [tsc]     Type 'Partial<{ key: BucketKey; avg: number | null; } & { key: BucketKey; count: number; transactionType: string; } & { key: BucketKey; sum: number | null; }> & { ...; }' is not assignable to type '{ sum?: number | null | undefined; key: Key; avg?: number | null | undefined; count?: number | null | undefined; transactionType?: string | undefined; }'.
[ts refs]  proc [tsc]       Types of property 'key' are incompatible.
[ts refs]  proc [tsc]         Type 'BucketKey' is missing the following properties from type 'Key': "service.name", "transaction.name"
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 202     const itemsWithRelativeImpact = getItemsWithRelativeImpact(setup, items);
[ts refs]  proc [tsc]                                                                           ~~~~~
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] x-pack/plugins/apm/public/components/shared/managed_table/index.tsx:131:6 - error TS2322: Type '{ pagination?: { hidePerPageOptions: boolean; totalItemCount: number; pageIndex: number; pageSize: number; } | undefined; loading: boolean; noItemsMessage: ReactNode; items: T[]; columns: EuiBasicTableColumn<...>[]; sorting: { ...; }; onChange: (options: { ...; }) => void; }' is not assignable to type 'IntrinsicAttributes & (IntrinsicClassAttributes<EuiBasicTable<T>> & ((Pick<Readonly<CommonProps & Omit<...> & BasicTableProps<...>> & Readonly<...>, "error" | ... 274 more ... | "textOnly"> & Partial<...> & Partial<...>) | (Pick<...> & ... 1 more ... & Partial<...>)))'.
[ts refs]  proc [tsc]   Type '{ pagination?: { hidePerPageOptions: boolean; totalItemCount: number; pageIndex: number; pageSize: number; } | undefined; loading: boolean; noItemsMessage: ReactNode; items: T[]; columns: EuiBasicTableColumn<...>[]; sorting: { ...; }; onChange: (options: { ...; }) => void; }' is not assignable to type 'Pick<Readonly<CommonProps & Omit<HTMLAttributes<HTMLDivElement>, "onChange"> & Omit<BasicTableProps<T>, "onChange" | "pagination"> & { ...; }> & Readonly<...>, "error" | ... 272 more ... | "textOnly">'.
[ts refs]  proc [tsc]     Types of property 'pagination' are incompatible.
[ts refs]  proc [tsc]       Type '{ hidePerPageOptions: boolean; totalItemCount: number; pageIndex: number; pageSize: number; } | undefined' is not assignable to type 'Pagination'.
[ts refs]  proc [tsc]         Type 'undefined' is not assignable to type 'Pagination'.
[ts refs]  proc [tsc] 
[ts refs]  proc [tsc] 131     <EuiBasicTable

jen-huang

Fleet changes LGTM

weltenwort

infra plugin changes LGTM, thank you

Signed-off-by: Tyler Smalley <[email protected]>

stephmilovic

LGTM for threat hunting! thank you

Signed-off-by: Tyler Smalley <[email protected]>

kertal

LGTM for data-discovery-team

justinkambic

Uptime changes LGTM.

Signed-off-by: Tyler Smalley <[email protected]>

dgieselaar

Stuff breaks, but we'll follow up separately in #120272

kibana-ci · 2021-12-02T20:44:51Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`core`	1039	997	-42
`expressions`	1656	1658	+2
`fieldFormats`	240	239	-1
`fleet`	1145	1144	-1
`lists`	148	147	-1
`reporting`	163	162	-1
`timelines`	879	877	-2
`usageCollection`	17	15	-2
total			-48

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.7MB	2.7MB	-134.0B
`dataViewFieldEditor`	142.4KB	142.3KB	-81.0B
`dataViewManagement`	79.9KB	79.8KB	-54.0B
`discover`	312.4KB	312.5KB	+25.0B
`indexManagement`	513.4KB	513.3KB	-62.0B
`ingestPipelines`	452.7KB	452.7KB	+16.0B
`maps`	2.6MB	2.6MB	+9.0B
`security`	491.0KB	491.0KB	+17.0B
total			-264.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/analytics`	4	2	-2
`@kbn/config-schema`	18	19	+1
`@kbn/io-ts-utils`	2	3	+1
`@kbn/logging`	37	36	-1
`@kbn/optimizer`	9	10	+1
`@kbn/securitysolution-es-utils`	0	1	+1
`@kbn/server-route-repository`	1	2	+1
`@kbn/test`	9	10	+1
`@kbn/tinymath`	3	1	-2
`@kbn/typed-react-router-config`	1	0	-1
`actions`	8	11	+3
`apm`	43	44	+1
`bar`	2	3	+1
`core`	30	32	+2
`dashboard`	12	13	+1
`dataViews`	5	6	+1
`eventLog`	4	5	+1
`kibana`	895	851	-44
`kibanaUtils`	8	9	+1
`lens`	25	31	+6
`licensing`	8	10	+2
`lists`	39	38	-1
`management`	5	6	+1
`maps`	29	30	+1
`observability`	19	25	+6
`presentationUtil`	12	14	+2
`reporting`	15	14	-1
`savedObjects`	4	5	+1
`security`	9	10	+1
`securitySolution`	33	29	-4
`timelines`	25	19	-6
`visualizations`	15	16	+1
total			-24

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`dashboardEnhanced`	14.1KB	14.2KB	+55.0B
`data`	438.5KB	438.5KB	-11.0B
`embeddable`	63.7KB	63.8KB	+27.0B
`expressions`	82.3KB	82.3KB	+59.0B
`reporting`	42.0KB	42.0KB	+24.0B
total			+154.0B

Unknown metric groups

API count

id	before	after	diff
`expressions`	2102	2104	+2
`fleet`	1251	1250	-1
`lists`	155	154	-1
`reporting`	166	165	-1
`timelines`	1013	1011	-2
total			-3

References to deprecated APIs

id	before	after	diff
`canvas`	70	72	+2
`dashboard`	244	254	+10
`data`	475	477	+2
`discover`	1830	1835	+5
`graph`	168	178	+10
`reporting`	26	27	+1
`visualizations`	72	82	+10
total			+40

History

💔 Build #10743 failed 417d703
💚 Build #10711 succeeded ae216ef
💔 Build #10707 failed 47068e2
💚 Build #10560 succeeded 921bfc1
💔 Build #10480 failed dc24afd
💚 Build #10406 succeeded f54f6b1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tylersmalley @brianseeders

cjcenizal

Stack Management changes LGTM:

Console change is a code style change
Mappings editor change removes unreachable code branch
Ingest Pipelines change doesn't affect behavior (tested locally to verify)
Upgrade Assistant test change retains coverage of behavior intended to be tested

jportner

Thanks for addressing Thomas's comments!

Co-authored-by: Mikhail Shustov <[email protected]> Co-authored-by: Dario Gieselaar <[email protected]> Co-authored-by: CJ Cenizal <[email protected]> Co-authored-by: Justin Kambic <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]> Co-authored-by: Jean-Louis Leysens <[email protected]> Co-authored-by: Kyle Pollich <[email protected]> Co-authored-by: Xavier Mouligneau <[email protected]> Co-authored-by: Kevin Qualters <[email protected]> Co-authored-by: Candace Park <[email protected]> Co-authored-by: Brian Seeders <[email protected]> Co-authored-by: spalger <[email protected]>

Co-authored-by: Mikhail Shustov <[email protected]> Co-authored-by: Dario Gieselaar <[email protected]> Co-authored-by: CJ Cenizal <[email protected]> Co-authored-by: Justin Kambic <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]> Co-authored-by: Jean-Louis Leysens <[email protected]> Co-authored-by: Kyle Pollich <[email protected]> Co-authored-by: Xavier Mouligneau <[email protected]> Co-authored-by: Kevin Qualters <[email protected]> Co-authored-by: Candace Park <[email protected]> Co-authored-by: Brian Seeders <[email protected]> Co-authored-by: spalger <[email protected]> (cherry picked from commit 92a8636) # Conflicts: # package.json # packages/kbn-alerts/BUILD.bazel # packages/kbn-babel-register/BUILD.bazel # packages/kbn-babel-register/tsconfig.json # packages/kbn-pm/dist/index.js # packages/kbn-test/src/jest/run.ts # src/core/public/public.api.md # src/core/public/theme/theme_service.ts # src/core/types/elasticsearch/search.ts # src/plugins/discover/public/build_services.ts # src/plugins/presentation_util/public/components/controls/control_group/embeddable/control_group_container_factory.ts # x-pack/plugins/apm/server/lib/helpers/create_es_client/create_apm_event_client/index.ts # x-pack/plugins/apm/server/lib/helpers/setup_request.ts # x-pack/plugins/apm/server/lib/services/get_service_error_groups/get_service_error_group_main_statistics.ts # x-pack/plugins/apm/server/lib/transaction_groups/get_transaction_group_stats.ts # x-pack/plugins/apm/server/types.ts # x-pack/plugins/data_visualizer/public/application/index_data_visualizer/utils/saved_search_utils.test.ts # x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/crawl_details_flyout/accordion_list.test.tsx # x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/crawl_requests_table.test.tsx # x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/crawl_requests_table.tsx # x-pack/plugins/infra/public/alerting/log_threshold/components/expression_editor/criterion.tsx # x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_create/pipelines_create.tsx # x-pack/plugins/rule_registry/server/utils/create_lifecycle_rule_type.test.ts # x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/helpers.test.tsx # x-pack/plugins/security_solution/server/lib/detection_engine/routes/signals/query_signals_route.test.ts # x-pack/plugins/security_solution/server/lib/detection_engine/signals/utils.test.ts # x-pack/plugins/uptime/public/state/effects/journey.ts # x-pack/plugins/uptime/server/lib/requests/get_ping_histogram.ts # yarn.lock

# Backport This will backport the following commits from `main` to `7.17`: - [Upgrade Typescript to 4.3.5 (#104470)](#104470)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  --------- Co-authored-by: Tyler Smalley <[email protected]>

tylersmalley force-pushed the ts-4-3-4 branch from 786bd98 to 72a7c32 Compare July 6, 2021 21:15

tylersmalley force-pushed the ts-4-3-4 branch from 72a7c32 to 671e747 Compare July 20, 2021 23:17

tylersmalley changed the title ~~Upgrade Typescript to 4.3.4~~ Upgrade Typescript to 4.3.5 Jul 20, 2021

tylersmalley force-pushed the ts-4-3-4 branch from b82f37d to 4573210 Compare August 9, 2021 05:28

mshustov and others added 6 commits August 12, 2021 14:25

update ts version to 4.3.5

67b2548

Fix some typed-react-router/apm ts errors

c49094d

Fix: apm ts error

7892e6f

[@kbn/monaco] Transpile for web

29044a3

Signed-off-by: Tyler Smalley <[email protected]>

Resolve property used before initialization

5c0d31c

Signed-off-by: Tyler Smalley <[email protected]>

Update snapshot

9d69f94

Signed-off-by: Tyler Smalley <[email protected]>

tylersmalley force-pushed the ts-4-3-4 branch from 4573210 to 9d69f94 Compare August 12, 2021 21:37

mshustov added 2 commits August 13, 2021 11:38

dont use broken KnownHeaders helper

3837610

fix errors in Core

5d384f5

mshustov reviewed Aug 13, 2021

View reviewed changes

Tyler Smalley added 4 commits August 23, 2021 22:04

Merge remote-tracking branch 'upstream/master' into ts-4-3-4

e2c53d5

More fixes

9e8e7df

Signed-off-by: Tyler Smalley <[email protected]>

Revert accidental change

b041686

Signed-off-by: Tyler Smalley <[email protected]>

More fixes

801ce46

Signed-off-by: Tyler Smalley <[email protected]>

jen-huang approved these changes Dec 2, 2021

View reviewed changes

JasonStoltz approved these changes Dec 2, 2021

View reviewed changes

jbudz approved these changes Dec 2, 2021

View reviewed changes

vadimkibana approved these changes Dec 2, 2021

View reviewed changes

weltenwort self-requested a review December 2, 2021 16:05

academo approved these changes Dec 2, 2021

View reviewed changes

weltenwort approved these changes Dec 2, 2021

View reviewed changes

Restore Headers definition

47068e2

Signed-off-by: Tyler Smalley <[email protected]>

stephmilovic approved these changes Dec 2, 2021

View reviewed changes

Update associated API docs

ae216ef

Signed-off-by: Tyler Smalley <[email protected]>

kertal approved these changes Dec 2, 2021

View reviewed changes

justinkambic approved these changes Dec 2, 2021

View reviewed changes

Tyler Smalley added 4 commits December 2, 2021 10:07

Removed unnecessary change

65adb76

Signed-off-by: Tyler Smalley <[email protected]>

Add link to Github issue

cb0f129

Signed-off-by: Tyler Smalley <[email protected]>

Bump globby/fast-glob to consolidate fast-glob

417d703

Signed-off-by: Tyler Smalley <[email protected]>

Update @kbn/pm dist

c82a4de

Signed-off-by: Tyler Smalley <[email protected]>

dgieselaar mentioned this pull request Dec 2, 2021

[APM] Fix broken types in typed-react-router-config #120272

Closed

dgieselaar approved these changes Dec 2, 2021

View reviewed changes

cjcenizal approved these changes Dec 2, 2021

View reviewed changes

jportner approved these changes Dec 3, 2021

View reviewed changes

tylersmalley merged commit 92a8636 into elastic:main Dec 3, 2021

tylersmalley deleted the ts-4-3-4 branch December 3, 2021 00:27

kibanamachine added the backport:skip This commit does not require backporting label Dec 3, 2021

mistic mentioned this pull request May 31, 2023

[7.17] Upgrade Typescript to 4.3.5 (#104470) #158788

Merged

kibanamachine added the v7.17.11 label Jun 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Typescript to 4.3.5 #104470

Upgrade Typescript to 4.3.5 #104470

tylersmalley commented Jul 6, 2021 •

edited

Loading

tylersmalley commented Jul 20, 2021

dgieselaar commented Jul 21, 2021

tylersmalley commented Aug 2, 2021

mistic commented Aug 3, 2021

tylersmalley commented Aug 12, 2021 •

edited

Loading

mshustov Aug 13, 2021

kpollich Sep 1, 2021

mshustov commented Aug 13, 2021

tylersmalley commented Aug 26, 2021 •

edited

Loading

tylersmalley commented Aug 26, 2021 •

edited

Loading

tylersmalley commented Aug 26, 2021 •

edited

Loading

tylersmalley commented Aug 26, 2021 •

edited

Loading

tylersmalley commented Aug 26, 2021 •

edited by joshdover

Loading

tylersmalley commented Aug 26, 2021 •

edited

Loading

jen-huang left a comment

weltenwort left a comment

stephmilovic left a comment

kertal left a comment •

edited

Loading

justinkambic left a comment

dgieselaar left a comment

kibana-ci commented Dec 2, 2021

API count

References to deprecated APIs

cjcenizal left a comment

jportner left a comment

Upgrade Typescript to 4.3.5 #104470

Upgrade Typescript to 4.3.5 #104470

Conversation

tylersmalley commented Jul 6, 2021 • edited Loading

tylersmalley commented Jul 20, 2021

dgieselaar commented Jul 21, 2021

tylersmalley commented Aug 2, 2021

mistic commented Aug 3, 2021

tylersmalley commented Aug 12, 2021 • edited Loading

mshustov Aug 13, 2021

Choose a reason for hiding this comment

kpollich Sep 1, 2021

Choose a reason for hiding this comment

mshustov commented Aug 13, 2021

tylersmalley commented Aug 26, 2021 • edited Loading

tylersmalley commented Aug 26, 2021 • edited Loading

tylersmalley commented Aug 26, 2021 • edited Loading

tylersmalley commented Aug 26, 2021 • edited Loading

tylersmalley commented Aug 26, 2021 • edited by joshdover Loading

tylersmalley commented Aug 26, 2021 • edited Loading

jen-huang left a comment

Choose a reason for hiding this comment

weltenwort left a comment

Choose a reason for hiding this comment

stephmilovic left a comment

Choose a reason for hiding this comment

kertal left a comment • edited Loading

Choose a reason for hiding this comment

justinkambic left a comment

Choose a reason for hiding this comment

dgieselaar left a comment

Choose a reason for hiding this comment

kibana-ci commented Dec 2, 2021

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

References to deprecated APIs

History

cjcenizal left a comment

Choose a reason for hiding this comment

jportner left a comment

Choose a reason for hiding this comment

tylersmalley commented Jul 6, 2021 •

edited

Loading

tylersmalley commented Aug 12, 2021 •

edited

Loading

tylersmalley commented Aug 26, 2021 •

edited

Loading

tylersmalley commented Aug 26, 2021 •

edited

Loading

tylersmalley commented Aug 26, 2021 •

edited

Loading

tylersmalley commented Aug 26, 2021 •

edited

Loading

tylersmalley commented Aug 26, 2021 •

edited by joshdover

Loading

tylersmalley commented Aug 26, 2021 •

edited

Loading

kertal left a comment •

edited

Loading