[Lens] Get rid of giant union type #118848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Team:Visualizations
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
patrykkopycinski
approved these changes
Nov 17, 2021
mbondyra
approved these changes
Nov 18, 2021
|
👏 ❤️ verified it resolves the issue in the TS bump. |
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Nov 18, 2021
Signed-off-by: Tyler Smalley <[email protected]>
2 tasks
|
@elasticmachine merge upstream |
|
expected head sha didn’t match current head ref. |
peteharverson
approved these changes
Nov 19, 2021
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Public APIs missing exports
History
To update your PR or re-run it, just comment with: |
💔 Backport failedThe backport operation could not be completed due to the following error: The backport PRs will be merged automatically after passing CI. To backport manually run: |
mbondyra
removed
the
auto-backport
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Nov 20, 2021
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
mistic
added a commit
to mistic/kibana
that referenced
this pull request
May 31, 2023
(cherry picked from commit 8398d53) # Conflicts: # x-pack/plugins/lens/public/indexpattern_datasource/indexpattern.tsx # x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/index.ts # x-pack/plugins/lens/public/indexpattern_datasource/utils.ts
mistic
added a commit
that referenced
this pull request
May 31, 2023
# Backport This will backport the following commits from `main` to `7.17`: - [[Lens] Get rid of giant union type (#118848)](#118848) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Joe Reuter","email":"[email protected]"},"sourceCommit":{"committedDate":"2021-11-19T12:00:35Z","message":"[Lens] Get rid of giant union type (#118848)","sha":"8398d53da4542c0673861d07ce565515318114ea","branchLabelMapping":{"^v8.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","backport:skip","v8.1.0"],"number":118848,"url":"https://github.com/elastic/kibana/pull/118848","mergeCommit":{"message":"[Lens] Get rid of giant union type (#118848)","sha":"8398d53da4542c0673861d07ce565515318114ea"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.1.0","labelRegex":"^v8.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/118848","number":118848,"mergeCommit":{"message":"[Lens] Get rid of giant union type (#118848)","sha":"8398d53da4542c0673861d07ce565515318114ea"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lens has been using a large union type of all possible column types in a lot of places. However, typescript is struggling to compute it and it's currently blocking a TS upgrade as it's "too complex to analyze".
This PR gets rid of the union type and replaces is with a generic
GenericIndexPatternColumntype which doesn't allow to access the specific params of the various columns directly. In places where this is necessary, the newly introduced helperisColumnOfType<SpecificColumnType>('specificOperationType', column)can be used as a type guard.Most of the changes in this PR are caused by tests because we can't just provide matching params now - instead, the literal object has to be casted to the right type manually.
This change shouldn't hurt our type safety much in practice - the biggest impact is that the explicit
isColumnOfTypehas to be used now instead of implicit type guards andcolumn.operationTypechecks.