Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Fix broken types in typed-react-router-config #120272

Closed
dgieselaar opened this issue Dec 2, 2021 · 1 comment · Fixed by #120581
Closed

[APM] Fix broken types in typed-react-router-config #120272

dgieselaar opened this issue Dec 2, 2021 · 1 comment · Fixed by #120581
Assignees
@dgieselaar
Labels
Team:APM All issues that need APM UI Team support

Comments

@dgieselaar
Copy link
Member

#104470 will break our router types, we should not block that PR but fix the types as fast as possible (which seem to fall back to any now).
@dgieselaar dgieselaar added the Team:APM All issues that need APM UI Team support label Dec 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

dgieselaar added a commit to dgieselaar/kibana that referenced this issue Dec 7, 2021
@dgieselaar
[APM] Revert kbn/typed-react-router-config changes
a86659a 
Closes elastic#120272.
@dgieselaar dgieselaar mentioned this issue Dec 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgieselaar dgieselaar

Labels
Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Revert kbn/typed-react-router-config changes dgieselaar/kibana
3 participants
@dannycroft @dgieselaar @elasticmachine