-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DX] Upgrade prettier to v2.4.0 #112359
[DX] Upgrade prettier to v2.4.0 #112359
Conversation
1ae4a84
to
ccd911a
Compare
Pinging @elastic/kibana-operations (Team:Operations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alerting changes LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spot-checked some of the Stack Management plugins. Changes LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uptime changes LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enterprise Search (shared) and Workplace Search changes LGTM. Thanks for doing this!
Since this change affects so much of the repository, I will be merging this over the three-day weekend when there are fewer commits. This will give me time to run CI and merge without any merge conflicts in the PR itself. I will follow up on this thread once that happens. If you have ESLint failures after the merge, it can be resolved by running one of the following commands based on the marge you're targeting:
Please let me know if there are any concerns merging this without all code owner signoff. |
9e724a5
to
9553c7c
Compare
9553c7c
to
7089be9
Compare
Signed-off-by: Tyler Smalley <[email protected]>
Signed-off-by: Tyler Smalley <[email protected]>
Signed-off-by: Tyler Smalley <[email protected]>
Signed-off-by: Tyler Smalley <[email protected]>
7089be9
to
df0e928
Compare
💛 Build succeeded, but was flaky
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Signed-off-by: Tyler Smalley <[email protected]>
Release notes:
Most updates are caused by: Prevent wrapping object properties with short keys
Reviews:
Actions: