Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX] Upgrade prettier to v2.4.0 #112359

Merged
merged 4 commits into from
Sep 20, 2021
Merged

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Sep 15, 2021

Release notes:

Most updates are caused by: Prevent wrapping object properties with short keys

Reviews:

  • All changes were automatically applied by prettier except those in 42b4c57a898cff802d78192b1368ae9762a7000a

Actions:

git cherry-pick 15222fd2acc9fff8f42bc505eaeb105c553b14cb
yarn kbn bootstrap
node scripts/eslint.js --fix
git add . && git commit -sm 'eslint auto-fix'
git cherry-pick 42b4c57a898cff802d78192b1368ae9762a7000a
node scripts/check_published_api_changes.js --accept
git add . && git commit -sm 'api docs'

@tylersmalley tylersmalley force-pushed the bump-prettier branch 2 times, most recently from 1ae4a84 to ccd911a Compare September 16, 2021 04:11
@tylersmalley tylersmalley added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.16.0 v8.0.0 labels Sep 16, 2021
@tylersmalley tylersmalley changed the title Bump prettier [DX] Upgrade prettier to v2.4.0 Sep 16, 2021
@tylersmalley tylersmalley marked this pull request as ready for review September 16, 2021 16:02
@tylersmalley tylersmalley requested a review from a team as a code owner September 16, 2021 16:02
@tylersmalley tylersmalley requested review from a team September 16, 2021 16:02
@tylersmalley tylersmalley requested review from a team as code owners September 16, 2021 16:02
@tylersmalley tylersmalley requested review from a team September 16, 2021 16:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley tylersmalley requested review from a team, pzl and dasansol92 September 16, 2021 16:02
@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Sep 16, 2021
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting changes LGTM!

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot-checked some of the Stack Management plugins. Changes LGTM.

@pzl pzl removed their request for review September 16, 2021 16:33
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM.

Copy link
Contributor

@scottybollinger scottybollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enterprise Search (shared) and Workplace Search changes LGTM. Thanks for doing this!

@tylersmalley
Copy link
Contributor Author

tylersmalley commented Sep 16, 2021

Since this change affects so much of the repository, I will be merging this over the three-day weekend when there are fewer commits. This will give me time to run CI and merge without any merge conflicts in the PR itself. I will follow up on this thread once that happens.

If you have ESLint failures after the merge, it can be resolved by running one of the following commands based on the marge you're targeting:

  • master: node scripts/precommit_hook.js --ref master
  • 7.x: node scripts/precommit_hook.js --ref 7.x

Please let me know if there are any concerns merging this without all code owner signoff.

Signed-off-by: Tyler Smalley <[email protected]>
Tyler Smalley added 3 commits September 19, 2021 20:04
Signed-off-by: Tyler Smalley <[email protected]>
Signed-off-by: Tyler Smalley <[email protected]>
Signed-off-by: Tyler Smalley <[email protected]>
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Metrics [docs]

✅ unchanged

History

  • 💚 Build #154113 succeeded 7089be9c1e6791f343bfdfd84d2ce14c016be65c
  • 💔 Build #154108 failed 9553c7cfe9fcf8bbe2ecaa63c09111b692efa14f
  • 💚 Build #153918 succeeded 9e724a550e2c5236dbae2262216f4b7e128f8b7a
  • 💚 Build #153739 succeeded ccd911aba5ac00c63a719f95d744cd33531a1aba
  • 💛 Build #153711 was flaky 9d760a9431200be0bfb41ab9b1e227923a52731f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley merged commit 4681a80 into elastic:master Sep 20, 2021
tylersmalley pushed a commit that referenced this pull request Sep 20, 2021
@tylersmalley tylersmalley mentioned this pull request Oct 7, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.