Upgrade Typescript to 4.3.5

package.json

@@ -85,7 +85,7 @@
     "**/react-syntax-highlighter/**/highlight.js": "^10.4.1",
     "**/request": "^2.88.2",
     "**/trim": "1.0.1",
-    "**/typescript": "4.1.3",
+    "**/typescript": "4.3.5",
     "**/underscore": "^1.13.1"
   },
   "engines": {
@@ -654,8 +654,8 @@
     "@types/xml2js": "^0.4.5",
     "@types/yauzl": "^2.9.1",
     "@types/zen-observable": "^0.8.0",
-    "@typescript-eslint/eslint-plugin": "^4.14.1",
-    "@typescript-eslint/parser": "^4.14.1",
+    "@typescript-eslint/eslint-plugin": "^4.28.4",
+    "@typescript-eslint/parser": "^4.28.4",
     "@yarnpkg/lockfile": "^1.1.0",
     "abab": "^2.0.4",
     "aggregate-error": "^3.1.0",
@@ -834,7 +834,7 @@
     "ts-loader": "^7.0.5",
     "ts-morph": "^9.1.0",
     "tsd": "^0.13.1",
-    "typescript": "4.1.3",
+    "typescript": "4.3.5",
     "unlazy-loader": "^0.1.3",
     "url-loader": "^2.2.0",
     "val-loader": "^1.1.1",

packages/kbn-cli-dev-mode/src/log.ts

@@ -20,16 +20,18 @@ export interface Log {
 }
 
 export class CliLog implements Log {
-  public toolingLog = new ToolingLog({
-    level: this.silent ? 'silent' : this.quiet ? 'error' : 'info',
-    writeTo: {
-      write: (msg) => {
-        this.write(msg);
+  public toolingLog: ToolingLog;
+
+  constructor(private readonly quiet: boolean, private readonly silent: boolean) {
+    this.toolingLog = new ToolingLog({
+      level: this.silent ? 'silent' : this.quiet ? 'error' : 'info',
+      writeTo: {
+        write: (msg) => {
+          this.write(msg);
+        },
       },
-    },
-  });
-
-  constructor(private readonly quiet: boolean, private readonly silent: boolean) {}
+    });
+  }
 
   good(label: string, ...args: any[]) {
     if (this.quiet || this.silent) {

packages/kbn-monaco/src/index.ts

@@ -11,14 +11,15 @@ import './register_globals';
 
 export { monaco } from './monaco_imports';
 export { XJsonLang } from './xjson';
-export { PainlessLang, PainlessContext, PainlessAutocompleteField } from './painless';
+export { PainlessLang } from './painless';
+export type { PainlessContext, PainlessAutocompleteField } from './painless';
 /* eslint-disable-next-line @kbn/eslint/module_migration */
 import * as BarePluginApi from 'monaco-editor/esm/vs/editor/editor.api';
 
 import { registerLanguage } from './helpers';
-import {
+export type {
   LangModule as LangModuleType,
   CompleteLangModule as CompleteLangModuleType,
 } from './types';
 
-export { BarePluginApi, registerLanguage, LangModuleType, CompleteLangModuleType };
+export { BarePluginApi, registerLanguage };

packages/kbn-monaco/src/painless/index.ts

@@ -19,4 +19,4 @@ export const PainlessLang: CompleteLangModuleType = {
   getSyntaxErrors,
 };
 
-export { PainlessContext, PainlessAutocompleteField } from './types';
+export type { PainlessContext, PainlessAutocompleteField } from './types';

packages/kbn-monaco/src/painless/worker/index.ts

@@ -8,4 +8,4 @@
 
 export { PainlessWorker } from './painless_worker';
 
-export { PainlessError } from './lib';
+export type { PainlessError } from './lib';

packages/kbn-monaco/src/painless/worker/lib/index.ts

@@ -8,6 +8,6 @@
 
 export { getAutocompleteSuggestions } from './autocomplete';
 
-export { PainlessError } from './error_listener';
+export type { PainlessError } from './error_listener';
 
 export { parseAndGetSyntaxErrors } from './parser';

packages/kbn-optimizer/src/worker/bundle_refs_plugin.ts

@@ -43,10 +43,12 @@ type ModuleFactory = (data: RequestData, callback: Callback<BundleRefModule>) =>
 export class BundleRefsPlugin {
   private readonly resolvedRefEntryCache = new Map<BundleRef, Promise<string>>();
   private readonly resolvedRequestCache = new Map<string, Promise<string | undefined>>();
-  private readonly ignorePrefix = Path.resolve(this.bundle.contextDir) + Path.sep;
+  private readonly ignorePrefix;
   private allowedBundleIds = new Set<string>();
 
-  constructor(private readonly bundle: Bundle, private readonly bundleRefs: BundleRefs) {}
+  constructor(private readonly bundle: Bundle, private readonly bundleRefs: BundleRefs) {
+    this.ignorePrefix = Path.resolve(this.bundle.contextDir) + Path.sep;
+  }
 
   /**
    * Called by webpack when the plugin is passed in the webpack config

packages/kbn-test/src/functional_test_runner/lib/lifecycle_event.ts

@@ -15,21 +15,23 @@ export type GetArgsType<T extends LifecycleEvent<any>> = T extends LifecycleEven
 export class LifecycleEvent<Args extends readonly any[]> {
   private readonly handlers: Array<(...args: Args) => Promise<void> | void> = [];
 
-  private readonly beforeSubj = this.options.singular
-    ? new Rx.BehaviorSubject(undefined)
-    : new Rx.Subject<void>();
-  public readonly before$ = this.beforeSubj.asObservable();
+  private readonly beforeSubj: Rx.Subject<void> | Rx.BehaviorSubject<undefined>;
+  public readonly before$: Rx.Observable<void>;
 
-  private readonly afterSubj = this.options.singular
-    ? new Rx.BehaviorSubject(undefined)
-    : new Rx.Subject<void>();
-  public readonly after$ = this.afterSubj.asObservable();
+  private readonly afterSubj: Rx.Subject<void> | Rx.BehaviorSubject<undefined>;
+  public readonly after$: Rx.Observable<void>;
 
   constructor(
     private readonly options: {
       singular?: boolean;
     } = {}
-  ) {}
+  ) {
+    this.beforeSubj = options.singular ? new Rx.BehaviorSubject(undefined) : new Rx.Subject<void>();
+    this.before$ = this.beforeSubj.asObservable();
+
+    this.afterSubj = options.singular ? new Rx.BehaviorSubject(undefined) : new Rx.Subject<void>();
+    this.after$ = this.afterSubj.asObservable();
+  }
 
   public add(fn: (...args: Args) => Promise<void> | void) {
     this.handlers.push(fn);

packages/kbn-test/src/functional_test_runner/lib/lifecycle_phase.test.ts

@@ -133,6 +133,12 @@ describe('without randomness', () => {
           "kind": "N",
           "value": undefined,
         },
+        Notification {
+          "error": undefined,
+          "hasValue": true,
+          "kind": "N",
+          "value": undefined,
+        },
         Notification {
           "error": undefined,
           "hasValue": false,
@@ -149,6 +155,12 @@ describe('without randomness', () => {
           "kind": "N",
           "value": undefined,
         },
+        Notification {
+          "error": undefined,
+          "hasValue": true,
+          "kind": "N",
+          "value": undefined,
+        },
         Notification {
           "error": undefined,
           "hasValue": false,
@@ -183,12 +195,6 @@ describe('without randomness', () => {
     await expect(phase.after$.pipe(materialize(), toArray()).toPromise()).resolves
       .toMatchInlineSnapshot(`
             Array [
-              Notification {
-                "error": undefined,
-                "hasValue": true,
-                "kind": "N",
-                "value": undefined,
-              },
               Notification {
                 "error": undefined,
                 "hasValue": false,

packages/kbn-test/src/functional_test_runner/lib/lifecycle_phase.ts

@@ -19,19 +19,23 @@ export class LifecyclePhase<Args extends readonly any[]> {
 
   public triggered = false;
 
-  private readonly beforeSubj = new Rx.Subject<void>();
-  public readonly before$ = this.beforeSubj.asObservable();
+  private readonly beforeSubj: Rx.Subject<void> | Rx.BehaviorSubject<undefined>;
+  public readonly before$: Rx.Observable<void>;
 
-  private readonly afterSubj = this.options.singular
-    ? new Rx.ReplaySubject<void>(1)
-    : new Rx.Subject<void>();
-  public readonly after$ = this.afterSubj.asObservable();
+  private readonly afterSubj: Rx.Subject<void> | Rx.BehaviorSubject<undefined>;
+  public readonly after$: Rx.Observable<void>;
 
   constructor(
     private readonly options: {
       singular?: boolean;
     } = {}
-  ) {}
+  ) {
+    this.beforeSubj = options.singular ? new Rx.BehaviorSubject(undefined) : new Rx.Subject<void>();
+    this.before$ = this.beforeSubj.asObservable();
+
+    this.afterSubj = options.singular ? new Rx.BehaviorSubject(undefined) : new Rx.Subject<void>();
+    this.after$ = this.afterSubj.asObservable();
+  }
 
   public add(fn: (...args: Args) => Promise<void> | void) {
     this.handlers.push(fn);

packages/kbn-typed-react-router-config/src/create_router.ts

@@ -18,7 +18,9 @@ import { deepExactRt } from '@kbn/io-ts-utils/target/deep_exact_rt';
 import { mergeRt } from '@kbn/io-ts-utils/target/merge_rt';
 import { Route, Router } from './types';
 
-export function createRouter<TRoutes extends Route[]>(routes: TRoutes): Router<TRoutes> {
+export function createRouter<TRoutes extends Route[]>(routes: TRoutes): Router<TRoutes>;
+
+export function createRouter(routes: Route[]) {
   const routesByReactRouterConfig = new Map<ReactRouterConfig, Route>();
   const reactRouterConfigsByRoute = new Map<Route, ReactRouterConfig>();
 
@@ -157,10 +159,8 @@ export function createRouter<TRoutes extends Route[]>(routes: TRoutes): Router<T
     });
   };
 
-  return {
-    link: (path, ...args) => {
-      return link(path, ...args);
-    },
+  const router = {
+    link,
     getParams: (...args: any[]) => {
       const matches = matchRoutes(...args);
       return matches.length
@@ -173,8 +173,11 @@ export function createRouter<TRoutes extends Route[]>(routes: TRoutes): Router<T
     matchRoutes: (...args: any[]) => {
       return matchRoutes(...args) as any;
     },
-    getRoutePath: (route) => {
+    getRoutePath: (route: Route) => {
       return reactRouterConfigsByRoute.get(route)!.path as string;
     },
   };
+
+  // prevent "Type instantation is excessively deep"
+  return router as any;
 }

packages/kbn-typed-react-router-config/src/types/index.ts

@@ -13,7 +13,9 @@ import { RequiredKeys, ValuesType } from 'utility-types';
 // import { unconst } from '../unconst';
 import { NormalizePath } from './utils';
 
-export type PathsOf<TRoutes extends Route[]> = keyof MapRoutes<TRoutes> & string;
+export type PathsOf<TRoutes extends Route[]> = [keyof MapRoutes<TRoutes>] extends [never]
+  ? string
+  : keyof MapRoutes<TRoutes> & string;
 
 export interface RouteMatch<TRoute extends Route = Route> {
   route: TRoute;

src/core/public/chrome/chrome_service.test.ts

@@ -21,9 +21,11 @@ import { ChromeService } from './chrome_service';
 import { getAppInfo } from '../application/utils';
 
 class FakeApp implements App {
-  public title = `${this.id} App`;
+  public title: string;
   public mount = () => () => {};
-  constructor(public id: string, public chromeless?: boolean) {}
+  constructor(public id: string, public chromeless?: boolean) {
+    this.title = `${this.id} App`;
+  }
 }
 const store = new Map();
 const originalLocalStorage = window.localStorage;

src/core/public/chrome/chrome_service.tsx

@@ -44,7 +44,7 @@ interface ConstructorParams {
   kibanaVersion: string;
 }
 
-interface StartDeps {
+export interface StartDeps {
   application: InternalApplicationStart;
   docLinks: DocLinksStart;
   http: HttpStart;

src/core/public/core_app/core_app.ts

@@ -26,14 +26,14 @@ import {
 import { renderApp as renderStatusApp } from './status';
 import { DocLinksStart } from '../doc_links';
 
-interface SetupDeps {
+export interface SetupDeps {
   application: InternalApplicationSetup;
   http: HttpSetup;
   injectedMetadata: InjectedMetadataSetup;
   notifications: NotificationsSetup;
 }
 
-interface StartDeps {
+export interface StartDeps {
   application: InternalApplicationStart;
   docLinks: DocLinksStart;
   http: HttpStart;

src/core/public/doc_links/doc_links_service.ts

@@ -9,7 +9,7 @@
 import { deepFreeze } from '@kbn/std';
 import { InjectedMetadataSetup } from '../injected_metadata';
 
-interface StartDeps {
+export interface StartDeps {
   injectedMetadata: InjectedMetadataSetup;
 }
 

src/core/public/fatal_errors/fatal_errors_service.tsx

@@ -16,7 +16,7 @@ import { InjectedMetadataSetup } from '../injected_metadata';
 import { FatalErrorsScreen } from './fatal_errors_screen';
 import { FatalErrorInfo, getErrorInfo } from './get_error_info';
 
-interface Deps {
+export interface Deps {
   i18n: I18nStart;
   injectedMetadata: InjectedMetadataSetup;
 }

src/core/public/injected_metadata/injected_metadata_service.ts

@@ -69,11 +69,13 @@ export interface InjectedMetadataParams {
  * @internal
  */
 export class InjectedMetadataService {
-  private state = deepFreeze(
-    this.params.injectedMetadata
-  ) as InjectedMetadataParams['injectedMetadata'];
+  private state: InjectedMetadataParams['injectedMetadata'];
 
-  constructor(private readonly params: InjectedMetadataParams) {}
+  constructor(private readonly params: InjectedMetadataParams) {
+    this.state = deepFreeze(
+      this.params.injectedMetadata
+    ) as InjectedMetadataParams['injectedMetadata'];
+  }
 
   public start(): InjectedMetadataStart {
     return this.setup();

src/core/public/integrations/integrations_service.ts

@@ -12,7 +12,7 @@ import { CoreService } from '../../types';
 import { MomentService } from './moment';
 import { StylesService } from './styles';
 
-interface Deps {
+export interface Deps {
   uiSettings: IUiSettingsClient;
 }
 

src/core/public/notifications/notifications_service.ts

@@ -14,11 +14,11 @@ import { ToastsService, ToastsSetup, ToastsStart } from './toasts';
 import { IUiSettingsClient } from '../ui_settings';
 import { OverlayStart } from '../overlays';
 
-interface SetupDeps {
+export interface SetupDeps {
   uiSettings: IUiSettingsClient;
 }
 
-interface StartDeps {
+export interface StartDeps {
   i18n: I18nStart;
   overlays: OverlayStart;
   targetDomElement: HTMLElement;

src/core/public/rendering/rendering_service.tsx

@@ -16,7 +16,7 @@ import { InternalApplicationStart } from '../application';
 import { OverlayStart } from '../overlays';
 import { AppWrapper } from './app_containers';
 
-interface StartDeps {
+export interface StartDeps {
   application: InternalApplicationStart;
   chrome: InternalChromeStart;
   overlays: OverlayStart;

src/core/public/ui_settings/ui_settings_service.ts

@@ -15,7 +15,7 @@ import { UiSettingsApi } from './ui_settings_api';
 import { UiSettingsClient } from './ui_settings_client';
 import { IUiSettingsClient } from './types';
 
-interface UiSettingsServiceDeps {
+export interface UiSettingsServiceDeps {
   http: HttpSetup;
   injectedMetadata: InjectedMetadataSetup;
 }

src/core/server/context/container/context.mock.ts

@@ -12,7 +12,6 @@ export type ContextContainerMock = jest.Mocked<IContextContainer>;
 
 const createContextMock = (mockContext: any = {}) => {
   const contextMock: ContextContainerMock = {
-    // @ts-expect-error since ContextContainerMock cannot infer ContextName and fallsback to never
     registerContext: jest.fn(),
     createHandler: jest.fn(),
   };

src/core/server/context/context_service.ts

@@ -12,7 +12,7 @@ import { CoreContext } from '../core_context';
 
 type PrebootDeps = SetupDeps;
 
-interface SetupDeps {
+export interface SetupDeps {
   pluginDependencies: ReadonlyMap<PluginOpaqueId, PluginOpaqueId[]>;
 }