Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] Upgrade Typescript to 4.3.5 (#104470) #158788

Merged
merged 5 commits into from
Jun 1, 2023

Conversation

mistic
Copy link
Member

@mistic mistic commented May 31, 2023

Backport

This will backport the following commits from main to 7.17:

Questions ?

Please refer to the Backport tool documentation

Co-authored-by: Mikhail Shustov <[email protected]>
Co-authored-by: Dario Gieselaar <[email protected]>
Co-authored-by: CJ Cenizal <[email protected]>
Co-authored-by: Justin Kambic <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Co-authored-by: Jean-Louis Leysens <[email protected]>
Co-authored-by: Kyle Pollich <[email protected]>
Co-authored-by: Xavier Mouligneau <[email protected]>
Co-authored-by: Kevin Qualters <[email protected]>
Co-authored-by: Candace Park <[email protected]>
Co-authored-by: Brian Seeders <[email protected]>
Co-authored-by: spalger <[email protected]>
(cherry picked from commit 92a8636)

# Conflicts:
#	package.json
#	packages/kbn-alerts/BUILD.bazel
#	packages/kbn-babel-register/BUILD.bazel
#	packages/kbn-babel-register/tsconfig.json
#	packages/kbn-pm/dist/index.js
#	packages/kbn-test/src/jest/run.ts
#	src/core/public/public.api.md
#	src/core/public/theme/theme_service.ts
#	src/core/types/elasticsearch/search.ts
#	src/plugins/discover/public/build_services.ts
#	src/plugins/presentation_util/public/components/controls/control_group/embeddable/control_group_container_factory.ts
#	x-pack/plugins/apm/server/lib/helpers/create_es_client/create_apm_event_client/index.ts
#	x-pack/plugins/apm/server/lib/helpers/setup_request.ts
#	x-pack/plugins/apm/server/lib/services/get_service_error_groups/get_service_error_group_main_statistics.ts
#	x-pack/plugins/apm/server/lib/transaction_groups/get_transaction_group_stats.ts
#	x-pack/plugins/apm/server/types.ts
#	x-pack/plugins/data_visualizer/public/application/index_data_visualizer/utils/saved_search_utils.test.ts
#	x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/crawl_details_flyout/accordion_list.test.tsx
#	x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/crawl_requests_table.test.tsx
#	x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/crawl_requests_table.tsx
#	x-pack/plugins/infra/public/alerting/log_threshold/components/expression_editor/criterion.tsx
#	x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_create/pipelines_create.tsx
#	x-pack/plugins/rule_registry/server/utils/create_lifecycle_rule_type.test.ts
#	x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/helpers.test.tsx
#	x-pack/plugins/security_solution/server/lib/detection_engine/routes/signals/query_signals_route.test.ts
#	x-pack/plugins/security_solution/server/lib/detection_engine/signals/utils.test.ts
#	x-pack/plugins/uptime/public/state/effects/journey.ts
#	x-pack/plugins/uptime/server/lib/requests/get_ping_histogram.ts
#	yarn.lock
@mistic mistic enabled auto-merge (squash) May 31, 2023 22:55
@elastic elastic deleted a comment from kibana-ci Jun 1, 2023
@mistic mistic disabled auto-merge June 1, 2023 01:35
@mistic mistic merged commit 98332db into elastic:7.17 Jun 1, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
core 1025 983 -42
expressions 1640 1642 +2
fieldFormats 246 245 -1
fleet 1136 1135 -1
lists 148 147 -1
reporting 161 160 -1
timelines 852 850 -2
usageCollection 17 15 -2
total -48

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.4MB 2.4MB -129.0B
discover 337.7KB 337.8KB +25.0B
indexManagement 525.1KB 525.0KB -62.0B
indexPatternFieldEditor 151.4KB 151.3KB -81.0B
indexPatternManagement 79.7KB 79.6KB -54.0B
ingestPipelines 452.7KB 452.7KB +16.0B
maps 2.6MB 2.6MB +9.0B
security 517.7KB 517.7KB +17.0B
total -259.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/analytics 4 2 -2
@kbn/config-schema 18 19 +1
@kbn/io-ts-utils 3 4 +1
@kbn/logging 37 36 -1
@kbn/optimizer 9 10 +1
@kbn/securitysolution-es-utils 0 1 +1
@kbn/server-route-repository 1 2 +1
@kbn/test 8 9 +1
@kbn/tinymath 3 1 -2
@kbn/typed-react-router-config 1 0 -1
actions 8 11 +3
apm 41 44 +3
bar 2 3 +1
core 30 32 +2
dashboard 10 11 +1
dataViews 5 6 +1
eventLog 5 6 +1
kibana 934 863 -71
kibanaUtils 8 9 +1
lens 23 31 +8
licensing 8 10 +2
lists 39 38 -1
management 5 6 +1
maps 29 30 +1
observability 17 22 +5
reporting 14 13 -1
savedObjects 4 5 +1
securitySolution 33 29 -4
timelines 25 18 -7
visualizations 16 17 +1
total -52

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboardEnhanced 44.0KB 44.0KB +55.0B
data 454.8KB 454.8KB -11.0B
embeddable 69.9KB 69.9KB +27.0B
expressions 118.4KB 118.5KB +59.0B
reporting 40.8KB 40.8KB +24.0B
total +154.0B
Unknown metric groups

API count

id before after diff
expressions 2086 2088 +2
fleet 1239 1238 -1
lists 155 154 -1
reporting 164 163 -1
timelines 975 973 -2
total -3

References to deprecated APIs

id before after diff
canvas 67 69 +2
dashboard 231 241 +10
data 465 467 +2
discover 1837 1842 +5
graph 168 178 +10
regionMap 4 14 +10
reporting 76 77 +1
securitySolution 991 994 +3
tileMap 4 14 +10
upgradeAssistant 7 12 +5
visualizations 102 114 +12
total +70

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants