-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[k7] Make breadcrumbs more consistent #25884
Comments
spalger
added
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Meta
labels
Nov 19, 2018
Pinging @elastic/kibana-platform |
This was referenced Nov 19, 2018
spalger
changed the title
[k7] Update breadcrumbs for k7
[k7] Make breadcrumbs more consistent
Nov 19, 2018
This was referenced Nov 19, 2018
This was referenced Dec 1, 2018
spalger
pushed a commit
that referenced
this issue
Dec 4, 2018
## Summary This PR updates the security management routes to provide k7Breadcrumbs used by the new header navigation. See #25884 for general information about the integration with the router and #25689 for the breadcrumb taxonomy ![2018-12-03 19 05 40](https://user-images.githubusercontent.com/1329312/49416328-764b4200-f72e-11e8-9db7-aeb1294d131b.gif) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
This was referenced Dec 4, 2018
spalger
pushed a commit
that referenced
this issue
Dec 6, 2018
## Summary This PR updates the reporting routes to provide k7Breadcrumbs used by the new header navigation. See #25884 for general information about the integration with the router and #25689 for the breadcrumb taxonomy ![image](https://user-images.githubusercontent.com/1329312/49533708-9127ce80-f874-11e8-8f60-ad76f4caafcd.png) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Breadcrumbs are an important navigational element in the new k7 redesign, and in an effort to have consistent and predictable breadcrumbs that users can rely on we need to re-evaluate which breadcrumbs we use in different applications. Many applications already use breadcrumbs, but in a way that violates the guidelines for breadcrumbs set out by the Breadcrumb taxonomy issue.
This issue represents the effort I'll be heading up to get the breadcrumbs in shape before 7.0.0-alpha2, which hopefully will give us some time to gather feedback from the community about the new navigation with more of it's components properly implemented before 7.0 GA.
Integrating with the breadcrumbs is pretty straightforward, to set the breadcrumbs use the
chrome.breadcrumbs
api:If your app uses the angular router then the breadcrumbs will be cleared after each route navigation completes, unless new breadcrumbs have been set since route navigation started. If you are not using the angular router then your app will be responsible for setting/clearing the breadcrumbs between pages. The easiest way to do this is with the
k7Breadcrumbs
property on your angular routes. This function is called at after your route'sresolve
functions have been called so they can be accessed with$route.current.locals
and should return the breadcrumbs to be used for this route:If your app already shows its own breadcrumbs you should conditionally render them by checking the
k7Design
uiSetting. When this setting istrue
you should stop rendering the breadcrumbs yourself and instead pass breadcrumbs to thechrome.breadcrumbs
API described above.In non-angular contexts, do this with the
uiSettingsClient
:In angular controllers/directives you can bind this config value to your scope with:
Issues:
The text was updated successfully, but these errors were encountered: