Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Align breadcrumbs with the Kibana breadcrumb taxonomy #26582

Closed
weltenwort opened this issue Dec 3, 2018 · 5 comments
Closed

[Infra UI] Align breadcrumbs with the Kibana breadcrumb taxonomy #26582

weltenwort opened this issue Dec 3, 2018 · 5 comments
Assignees
Labels
Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@weltenwort
Copy link
Member

weltenwort commented Dec 3, 2018

The breadcrumbs should follow the taxonomy laid out in #25689.

The current breadcrumbs are

  • Infrastructure
  • Infrastructure / ${nodeId}
  • Infrastructure / Logs
@weltenwort weltenwort added the Feature:Metrics UI Metrics UI feature label Dec 3, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/infrastructure-ui

@weltenwort
Copy link
Member Author

@elastic/kibana-design, do you think the above breadcrumb hierarchy needs any adjustment to adhere to the taxonomy? The only aspect I can think of would be to make the second case more descriptive by showing something like

Infrastructure / Metrics of ${nodeType} ${nodeName}

, where ${nodeType} is one of "host", "container" or "pod".

@snide
Copy link
Contributor

snide commented Dec 5, 2018

They should all be considered clickable on their own. So if it's just a filter of the node, then I think it's likely ok just to consider the Node as the top link, and leaving the filtering context as part of page controls.

If metrics is it's own district page separate from the node parent, then I'd use Infrastructure / {node} / metrics

@weltenwort
Copy link
Member Author

weltenwort commented Dec 5, 2018

There is no separate node page. So no changes are necessary here?

@snide
Copy link
Contributor

snide commented Dec 5, 2018

Yep. You're all good.

@zube zube bot added [zube]: Done and removed [zube]: Ready labels Dec 6, 2018
@alvarolobato alvarolobato added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

4 participants