Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k7/Monitoring] Make breadcrumbs more consistent #25903

Closed
spalger opened this issue Nov 20, 2018 · 1 comment
Closed

[k7/Monitoring] Make breadcrumbs more consistent #25903

spalger opened this issue Nov 20, 2018 · 1 comment
Labels
Team:Monitoring Stack Monitoring team

Comments

@spalger
Copy link
Contributor

spalger commented Nov 20, 2018

See the #25884 for more general information.

The breadcrumbs in Management look pretty good, but there are a number of cases where the breadcrumbs include things like tab names, don't change between different pages, or don't properly describe the current page. I've tried to set in and update the breadcrumb generation logic that exists but there are a lot of different things happening in one place and I'm not sure how to make the updates correctly. "Invalid" breadcrumbs are also used for navigation purposes in the functional tests, so rather than removing them and updating the functional tests in a way I don't understand I'd like to sit down with either @ycombinator or @chrisronline once they're back from vacation and figure out how to update things for k7.

@spalger spalger added the Team:Monitoring Stack Monitoring team label Nov 20, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-monitoring

@spalger spalger changed the title [ml/Monitoring] Make breadcrumbs more consistent [k7/Monitoring] Make breadcrumbs more consistent Nov 20, 2018
@alvarolobato alvarolobato changed the title [k7/Monitoring] Make breadcrumbs more consistent [ml/Monitoring] Make breadcrumbs more consistent Nov 21, 2018
@spalger spalger changed the title [ml/Monitoring] Make breadcrumbs more consistent [k7/Monitoring] Make breadcrumbs more consistent Dec 4, 2018
@spalger spalger closed this as completed Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Monitoring Stack Monitoring team
Projects
None yet
Development

No branches or pull requests

2 participants