Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[management/security] implement k7Breadcrumbs #26603

Merged
merged 6 commits into from
Dec 4, 2018
Merged

[management/security] implement k7Breadcrumbs #26603

merged 6 commits into from
Dec 4, 2018

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Dec 4, 2018

Summary

This PR updates the security management routes to provide k7Breadcrumbs used by the new header navigation. See #25884 for general information about the integration with the router and #25689 for the breadcrumb taxonomy

2018-12-03 19 05 40

Checklist

@spalger spalger added review v7.0.0 Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Dec 4, 2018
@spalger spalger requested review from cchaos and legrego December 4, 2018 03:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

This was referenced Dec 4, 2018
Closed
Merged
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

legrego
legrego approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested locally. Thanks @spalger! Consider my suggestions optional nits.

x-pack/plugins/security/public/views/management/breadcrumbs.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/public/views/management/breadcrumbs.ts Outdated Show resolved Hide resolved
@cchaos
Copy link
Contributor

cchaos commented Dec 4, 2018

The new/create pages for both roles and users are missing the "Create" breadcrumb.

image
image

@spalger
Copy link
Contributor Author

spalger commented Dec 4, 2018

Wow, yep, totally missed those @cchaos

image

image

cchaos
cchaos approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger merged commit f524e9e into elastic:master Dec 4, 2018
@spalger spalger deleted the implement/k7-breadcrumbs/security-management branch December 4, 2018 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legrego legrego legrego approved these changes

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
review Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spalger @elasticmachine @cchaos @legrego