[errors][dev tools] implement k7Breadcrumbs #26598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
review
v7.0.0
Team:Visualizations
|
Pinging @elastic/kibana-app |
💚 Build Succeeded |
timroes
added
Team:Kibana Management
cchaos
suggested changes
Dec 4, 2018
| @@ -1,17 +1,21 @@ | |||
| <div class="app-container error-multi-allow-explicit-index"> | |||
| <h3> | |||
| <h3 class="kuiVerticalRhythm"> | |||
There was a problem hiding this comment.
Can you remove these the old classes? I've got a PR for styling these errors.
This comment has been minimized.
This comment has been minimized.
|
jenkins, test this, failure is flaky and I'm skipping the test |
💚 Build Succeeded |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Dev Tools and Error handler routes to provide k7Breadcrumbs used by the new header navigation. See #25884 for general information about the integration with the router and #25689 for the breadcrumb taxonomy
These ones are super simple because there isn't really any hierarchy on these pages, unless we're planning to create a listing page for dev tools or something. The error pages look pretty bad, created #26597 to address those separately.
Checklist