-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chrome/breadcrumbs] migrate to the new platform #25914
Merged
spalger
merged 5 commits into
elastic:master
from
spalger:implement/new-platform-breadcrumbs
Nov 20, 2018
Merged
[chrome/breadcrumbs] migrate to the new platform #25914
spalger
merged 5 commits into
elastic:master
from
spalger:implement/new-platform-breadcrumbs
Nov 20, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/kibana-platform |
20 tasks
💚 Build Succeeded |
joshdover
approved these changes
Nov 20, 2018
…-platform-breadcrumbs
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 20, 2018
* [chrome/breadcrumbs] migrate to the new platform * expand some comments * typo * [apm] fix breadcrumbs tests
spalger
pushed a commit
that referenced
this pull request
Nov 21, 2018
6.x/6.6: 696c49b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of working to make some changes to the way that breadcrumbs work so they are more unified across the k7 design I figured it was a good time to migrate the breadcrumbs to the new platform, and along the way eliminate the angular-specific wrapper (while keeping the angular integration that clears the breadcrumbs via angular router navigation events).
The primary breadcrumbs state is now in the
core.chrome
service, along with the type definition forBreadcrumb
. The following changes were made for consistency with other new platform code:ui/chrome/api/breadcrumbs
receives thechrome
start contract like otherui/chrome/api/*
modulesui/chrome/services/breadcrumb_state
was moved tochrome.breadcrumbs
, so:breadcrumbs
referring to the stream of breadcrumbs tobreadcrumbs$
inline with our loosely held convention.