Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chrome/breadcrumbs] migrate to the new platform #25914

Merged
merged 5 commits into from
Nov 20, 2018

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Nov 20, 2018

As a part of working to make some changes to the way that breadcrumbs work so they are more unified across the k7 design I figured it was a good time to migrate the breadcrumbs to the new platform, and along the way eliminate the angular-specific wrapper (while keeping the angular integration that clears the breadcrumbs via angular router navigation events).

The primary breadcrumbs state is now in the core.chrome service, along with the type definition for Breadcrumb. The following changes were made for consistency with other new platform code:

  • ui/chrome/api/breadcrumbs receives the chrome start contract like other ui/chrome/api/* modules
  • ui/chrome/services/breadcrumb_state was moved to chrome.breadcrumbs, so:
    import { set, breadcrumbs } from 'ui/chrome/services/breadcrumb_state'
    set([]);
    breadcrumbs.subscribe(...)
    is now
    import chrome from 'ui/chrome'
    chrome.breadcrumbs.set([]);
    chrome.breadcrumbs.get$().subscribe();
  • renamed instances of breadcrumbs referring to the stream of breadcrumbs to breadcrumbs$ inline with our loosely held convention.

@spalger spalger added review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 v6.6.0 labels Nov 20, 2018
@spalger spalger requested a review from joshdover November 20, 2018 04:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@elastic elastic deleted a comment from elasticmachine Nov 20, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger merged commit 88af88c into elastic:master Nov 20, 2018
spalger pushed a commit to spalger/kibana that referenced this pull request Nov 20, 2018
* [chrome/breadcrumbs] migrate to the new platform

* expand some comments

* typo

* [apm] fix breadcrumbs tests
spalger pushed a commit that referenced this pull request Nov 21, 2018
* [chrome/breadcrumbs] migrate to the new platform (#25914)

* [chrome/breadcrumbs] migrate to the new platform

* expand some comments

* typo

* [apm] fix breadcrumbs tests

* fix bad merge
@spalger
Copy link
Contributor Author

spalger commented Nov 21, 2018

6.x/6.6: 696c49b

@spalger spalger deleted the implement/new-platform-breadcrumbs branch November 21, 2018 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.6.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants