Update develop-ref after #2247 #2261

JohnHalleyGotway · 2022-09-14T16:58:32Z

Expected Differences

PR Feature 2206 fair crps to ecnt #2247 for issue Add the fair CRPS statistic to the ECNT line type in a new CRPS_EMP_FAIR column #2206 adds a new CRPS_EMP_FAIR column to the end of the ECNT line type.
This GitHub actions run flags differences in 36 output files.

egrep -i "ERROR:|file1:" comp_dir.log | egrep -B 1 ERROR: | grep file1 | wc -l
36

All of the differences exist in _ecnt.txt or .stat files generated by the MET tools:
Updating develop-ref to get past this expected differences.

Co-authored-by: Julie Prestopnik <[email protected]>

…rection Feature 2027 grid stat wind direction

…ar entry should really be obs_bufr_map and not commented out.

Feature 2044 pb2nc config

Co-authored-by: Howard Soh <[email protected]>

#1824 ci-run-test Reset itype to 1 for regular CAPE

…i-skip-all

* found and made three changes replacing [email protected] with the MetPlus gitub discussions page * Update met/docs/Users_Guide/appendixA.rst Thanks, a typo plus I am completely neutral as to the exact wording. Co-authored-by: jprestop <[email protected]> * Update met/src/libcode/vx_data2d_grib2/data2d_grib2.cc Co-authored-by: jprestop <[email protected]> * Update met/README Co-authored-by: jprestop <[email protected]> Co-authored-by: jprestop <[email protected]>

Feature 1996 sonarqube findings

* Updated set_job_controls.sh to add a check for the skip all keyword * Added a space to check keyword ci-skip-all Co-authored-by: Julie Prestopnik <[email protected]>

…cond return

…default dotsize if 1.0 rather than 10.

* Per issue #2055, in read_grib2_record_list() added new PDS numbers 6, 10, 15 (for NBM data). SL * Per issue #2055: in read_grib2_record_list(), in section that validates PDS number changed, for undefined PDS numbers, changed Error to Warning and continue (instead of exit). SL * Per issue #2055, created new entries for NBM grib2 data fields. SL * Per issue #2055. Added more NBM fields based on a 12z, f003 file. SL * Per issue #2055, after interogating several NBM lead-time files, added TMAX field. SL * Per issue #2055, added grib2_nbm.txt to the list. SL * Per #2055, update the grib2_nbm.txt file entries in the table_files Makefiles. * Per issue #2055, fixed syntax entry for TSTM field. SL * Per issue #2055, fixed a few more syntax errors for some of the fields. SL * Per issue #2055, in read_grib2_record_list(), added section to set level values for template number 6 (NBM data). Also added some temporary print statements. SL * Per issue #2055, in read_grib2_record_list(), added code to set levels for table number 10 (like 6). SL * Per #2055, adding support for new GRIB2_perc_val configuration option to filter records based on the forecast percentile value used by GRIB2 product definition templates 6 and 10. Seth, note that I also included the probability filtering logic tweak we discussed, since it was already present in that same file. * Per issue #2055: in find_record_matches(), in section that resolves Prob fields, changed 'break' to 'continue' for non Probs. SL * Per issue #2055, in read_grib2_record_list() cleaned up some commented out code. SL * Per issue #2055, in read_grib2_record_list() cleaned up all print statements. SL * Per issue #2055, added 5 new unit tests for NBM data. SL * Update data2d_grib2.cc * Update data2d_grib2.cc Co-authored-by: Seth Linden <[email protected]> Co-authored-by: John Halley Gotway <[email protected]>

feature_2225_level_string_with_at

…id_stat, gribtab_dat_to_flat, and gsidens2orank). Also removed commented out code from main.cc.

* Per #2198, adding Seth Linden and Dave Albo to the Author List * Per #2198, updated Dave Albo to David Albo * Per #2198, added three new authors based on submitted AMS abstract * Per #2198, adding .zenodo.json file * Per #2198, adding orcids for all based on Tatiana's suggestion * Update .zenodo.json Co-authored-by: johnhg <[email protected]> * Update .zenodo.json Co-authored-by: johnhg <[email protected]> * Update .zenodo.json Co-authored-by: johnhg <[email protected]> Co-authored-by: johnhg <[email protected]>

* Per #2196, update for upgrade to Python 3.8.6 * Updated based on new structure of METbaseimage * Changed MET_BASE_IMAGE references to MET_BASE_TAG; Added information to the README.md file * Changed MET_BASE_IMAGE references to MET_BASE_TAG; Updated the version from v1.0 to v1.1 * Update internal/scripts/docker/README.md Based on suggestion from John HG. Co-authored-by: johnhg <[email protected]> * Update internal/scripts/docker/README.md Based on suggestion from John HG. Co-authored-by: johnhg <[email protected]> * Update internal/scripts/docker/README.md Based on suggestion from John HG. Co-authored-by: johnhg <[email protected]> * Update internal/scripts/docker/README.md Based on suggestion from John HG. Co-authored-by: johnhg <[email protected]> * Per #2196, updating README.md based on suggestions from John HG Co-authored-by: johnhg <[email protected]>

* creating chapter files * putting a space in to work through the git add and commit process. * Changed formatting of one header Co-authored-by: Lisa Goodrich <[email protected]> Co-authored-by: jprestop <[email protected]>

* Per issue #2206, for the ECNT line type, added CRPS_EMP_FAIR. SL * Per issue #2206, for ECNT line type, added CRPS_EMP_FAIR. SL * Per issue #2206, for ecnt_columns, added CRPS_EMP_FAIR. SL * Per issue #2206, in write_ecnt_cols(), added crps_emp_fair. SL * Per issue #2206, in ECNTInfo, added crps_emp_fair. SL * Per issue #2206, started stubbing code pieced to calculate crps_emp_fair. SL * Per issue #2206, added new function mean_abs_diff(). SL * Per issue #2206, in compute_pair_vals() updated the code to calculate crps_emp and crps_emp_fair. SL * Per issue #2206, added crps_emp_fair (CRPS_EMP_FAIR) to relevant code pieces. SL * Per issue #2206, added wording for CRPS_EMP_FAIR, also added it to last column of ECNT line type. SL * Per issue #2206, added info for CRPS_EMP_FAIR and also added the math equation for this. SL * Per issue #2206, update the math equation for CRPS_EMP_FAIR. SL * Per issue #2206, added new function weighted_mean_absolute_diff(). SL * Per issue #2206, updated the crps_emp_fair calculation to subtract the weighted_mean_abs_diff. SL * Per issue #2206, in aggr_orank_lines(), updated calculation for crps_emp_fair to use weighted_mean_abs_diff. SL * Per issue #2206, renamed weighted_mean_abs_diff() to wmean_abs_diff(). SL * Per issue #2206, for the crps_emp_fair calculation, changed weighted_mean_abs_diff() to wmean_abs_diff(). SL * Per issue #2206, in aggr_orank_lines(), for the crps_emp_fair calculation, changed weighted_mean_abs_diff() to wmean_abs_diff(). SL * Per issue #2206, updated the math equation for the CRPS_EMP_FAIR calculation. SL * Per issue #2206, fixed a bug in the wmean_abs_diff() function. SL * Per issue #2206, added code for crps_emp_fair. SL * Per issue #2206, in set() function, added checks for crps_emp and crps_emp_fair, for values of 0.0. SL Co-authored-by: Seth Linden <[email protected]>

…r image that it used in the METplus automated tests

…elopment.docker file (apparently unused or rarely previously) to include changes for Python 3.8 including setting the LDFLAG to include -rpath to prevent needing LD_LIBRARY_PATH set to run the tools. Source the env file in the build MET docker script instead of setting the env vars in the configure command

…ck to 3.6. This is done by rolling back the base image in the MET Dockerfiles to dtcenter/met-base:v1.0. Using 3.8 caused the downstream METplus python embedding examples to fail via GHA in the METplus repo. Will write up an issue to investigate more during the MET-11.0.0-beta4 development cycle.

…BASE_IMAGE and MET_BASE_TAG since those variables are hard-coded in the Dockerfiles themselves and this script includes no logic to handle them.

… to MET_BASE_IMAGE and MET_BASE_TAG since those variables are hard-coded in the Dockerfiles themselves and this script includes no logic to handle them." This reverts commit 5efc65e.

…should really revisit having this setting spread across so many locations.

JohnHalleyGotway and others added 30 commits February 11, 2022 15:45

Feature 2040 parse timing (#2048)

67b484c

Co-authored-by: Julie Prestopnik <[email protected]>

Merge pull request #2047 from dtcenter/feature_2027_grid_stat_wind_di…

0f25d3c

…rection Feature 2027 grid stat wind direction

#2033 ci-run-test Initial release

ae13219

CI: Add logic to auto update input data (#2046)

1d56b26

Bugfix 2045 develop hira (#2049)

39a50c1

#2044 ci-run-test merge again

ce3582d

Feature 2040 patch (#2053)

fd95301

For #2044, fix a typo in PB2NCConfig_G212. A commented out obs_bufr_v…

1852dae

…ar entry should really be obs_bufr_map and not commented out.

Merge pull request #2050 from dtcenter/feature_2044_pb2nc_config

6b2134d

Feature 2044 pb2nc config

print docker build log to GHA log if build fails

418ebe7

Feature 1824 pb2nc mlcape (#2057)

0d04d0d

Co-authored-by: Howard Soh <[email protected]>

Feature 1583 es hira (#2056)

a2a7372

Merge branch 'develop-ref' into develop

e1160cf

#1824 ci-run-test Reset itype to 1 for regular CAPE

10ca15c

Merge pull request #2060 from dtcenter/feature_1824_pb2nc_MLCAPE2

fd9e63c

#1824 ci-run-test Reset itype to 1 for regular CAPE

SonarQube: check if pd_ptr is null

6b78a89

#1824 Initialize cape_cnt_surface_msgs

1d58705

ci-run-test Removed trailing spaces

946e4ec

Modified the PR template to add review of the source issue metadata c…

f74ac2a

…i-skip-all

Merge pull request #2065 from dtcenter/feature_1824_pb2nc_MLCAPE2

ba71e4c

Feature 1996 sonarqube findings

Feature set job controls (#2066)

36bdf26

* Updated set_job_controls.sh to add a check for the skip all keyword * Added a space to check keyword ci-skip-all Co-authored-by: Julie Prestopnik <[email protected]>

Feature 1918 std climo (#2061)

ab26b48

Merge branch 'develop-ref' into develop

005da64

Feature 2070 obs_prepbufr_map (#2071)

30ad6b6

#1996 simplify the retrun statement (no effect with tf_left at the se…

eccbb38

…cond return

#1996 Add null terminator only if the pointer is not NULL

37aef73

#1996 Reduced duplicated for loops

543370e

#1996 Removed IsSet which is defined at the base class

4471c4a

#1996 Initialize the variable

c5a80d5

jprestop and others added 28 commits August 13, 2022 15:59

Updating installation files for Orion

d00d857

Removed beta2 references

f6bd643

Adding configuration and modulefiles for gaea installation

8f50cc8

Changing METdatadb references to METdataio

70b52c6

Documentation-only commit directly to develop to correct a typo. The …

36d8356

…default dotsize if 1.0 rather than 10.

Merge branch 'develop' of github.com:dtcenter/MET into develop

c33a552

Merge pull request #2233 from dtcenter/feature_2225_level_string_with_at

a44176e

feature_2225_level_string_with_at

Merge branch 'develop-ref' into develop

5bc6fad

Feature 2207 map (#2241)

1680606

Feature #2237 tmp_dir (#2242)

0a27b94

Per #2196, updating files for changes to met base image (#2246)

c7bbab9

Hotfix to the develop branch to fix typos in the names of 3 tools (gr…

71c1939

…id_stat, gribtab_dat_to_flat, and gsidens2orank). Also removed commented out code from main.cc.

Feature 2250 accum (#2251)

973f1b9

Per #1744, adding names for rst files in index.rst

118214c

Reword to Grid-Stat opening paragraph

d91b103

Feature 1774 contrib outline (#2253)

7bf988f

* creating chapter files * putting a space in to work through the git add and commit process. * Changed formatting of one header Co-authored-by: Lisa Goodrich <[email protected]> Co-authored-by: jprestop <[email protected]>

Fine tune to grid-stat opening paragraph

98fecaf

automated tests: added ability to trigger build of develop-lite docke…

49f7546

…r image that it used in the METplus automated tests

Tweak the build_docker_image.sh script by removing references to MET_…

5efc65e

…BASE_IMAGE and MET_BASE_TAG since those variables are hard-coded in the Dockerfiles themselves and this script includes no logic to handle them.

Revert "Tweak the build_docker_image.sh script by removing references…

16c513c

… to MET_BASE_IMAGE and MET_BASE_TAG since those variables are hard-coded in the Dockerfiles themselves and this script includes no logic to handle them." This reverts commit 5efc65e.

Hotfix, found 2 more spots where I needed to change v1.1 to v1.0. We …

96bd183

…should really revisit having this setting spread across so many locations.

Merge branch 'develop-ref' into develop

688d3d8

JohnHalleyGotway added this to the MET 11.0.0 milestone Sep 14, 2022

JohnHalleyGotway merged commit 310c471 into develop-ref Sep 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update develop-ref after #2247 #2261

Update develop-ref after #2247 #2261

JohnHalleyGotway commented Sep 14, 2022

Update develop-ref after #2247 #2261

Update develop-ref after #2247 #2261

Conversation

JohnHalleyGotway commented Sep 14, 2022

Expected Differences