Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address findings from the SonarQube/Cppcheck code analysis tool #1996

Closed
22 tasks
hsoh-u opened this issue Dec 15, 2021 · 0 comments · Fixed by #2004, #2065 or #2073
Closed
22 tasks

Address findings from the SonarQube/Cppcheck code analysis tool #1996

hsoh-u opened this issue Dec 15, 2021 · 0 comments · Fixed by #2004, #2065 or #2073
Assignees
@hsoh-u
Labels
component: code cleanup Code cleanup and maintenance issue priority: medium Medium Priority reporting: DTC AF METplus Air Force METplus Project requestor: METplus Team METplus Development Team type: bug Fix something that is not working
Milestone
MET 10.1.0

Comments

@hsoh-u
Copy link
Collaborator

hsoh-u commented Dec 15, 2021 •
edited by JohnHalleyGotway
Loading

Cppcheck is a C++ code analysis tool similar to SonarQube.

Describe the Problem

CppCheck does the static code analysis like sonarqube. These are finding by CppCheck (not dedected by sonarqube).

Non initialized local variables at multiple places

Expected Behavior

Provide a clear and concise description of what you expected to happen here.

Note: I think "struct RecordInfo" at make_mapfiles.cc is OK because make_mapfiles.cc is not exposed.

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2771021

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@hsoh-u hsoh-u added type: bug Fix something that is not working alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Dec 15, 2021
@hsoh-u hsoh-u added this to the MET 10.1.0 milestone Dec 15, 2021
@hsoh-u hsoh-u self-assigned this Dec 15, 2021
@JohnHalleyGotway JohnHalleyGotway added component: code cleanup Code cleanup and maintenance issue priority: medium Medium Priority requestor: METplus Team METplus Development Team and removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Dec 16, 2021
@hsoh-u hsoh-u changed the title FIx findings from CppCheck Fix findings from CppCheck Dec 28, 2021
@TaraJensen TaraJensen removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Jan 6, 2022
@hsoh-u hsoh-u changed the title Fix findings from CppCheck Fix findings from CppCheck (addition to sonarqube) Jan 6, 2022
@TaraJensen TaraJensen added the reporting: DTC AF METplus Air Force METplus Project label Jan 6, 2022
hsoh-u pushed a commit that referenced this issue Jan 7, 2022
#1996 Initialize PT_new
1fcbbef
hsoh-u pushed a commit that referenced this issue Jan 7, 2022
#1996 Removed AllocInc
2e48bfa
hsoh-u pushed a commit that referenced this issue Jan 7, 2022
#1996 call missing var->getVar
cd1f7c9
hsoh-u pushed a commit that referenced this issue Jan 7, 2022
#1996 initialize interp_wdth
802a273
hsoh-u pushed a commit that referenced this issue Jan 7, 2022
#1996 initialize data_azi_mean[ir]
ffb89fd
hsoh-u pushed a commit that referenced this issue Jan 7, 2022
#1996 Check if cur_job is null
079eeca
hsoh-u pushed a commit that referenced this issue Jan 7, 2022
#1996 Removed Nalloc
0ce26dd
hsoh-u pushed a commit that referenced this issue Jan 7, 2022
#1996 Initialized MaxLength
6ae622d
hsoh-u pushed a commit that referenced this issue Jan 7, 2022
#1996 Check if cur_job is null
663fbfd
@hsoh-u hsoh-u linked a pull request Jan 7, 2022 that will close this issue
Feature 1996 uninitialized variables #2004
Merged
13 tasks
@JohnHalleyGotway JohnHalleyGotway changed the title Fix findings from CppCheck (addition to sonarqube) Fix findings from the Cppcheck code analysis tool Jan 15, 2022
@JohnHalleyGotway JohnHalleyGotway changed the title Fix findings from the Cppcheck code analysis tool Address findings from the Cppcheck code analysis tool Jan 15, 2022
hsoh-u pushed a commit that referenced this issue Jan 25, 2022
#1996 Initialize right and left
6b9b411
JohnHalleyGotway added a commit that referenced this issue Feb 3, 2022
@JohnHalleyGotway @jprestop
@sethlinden @j-opatz @hsoh-u @georgemccabe @mo-mglover
Update develop-ref after #2034 (#2037)
5eed9f1 
* Per #1906, modify code to pass entire path to make_temp_file_name instead of only the filename so that the function can tell whether or not the file exists. (#1952)

Co-authored-by: Julie Prestopnik <[email protected]>

* Feature 1761 percent thresh (#1956)

* Per issue #1761 in set_perc() adding code to get FBIAS numeric value, like 1.0 or 0.9, etc. SL

* Per issue #1761: in set_perc(), modified actual percentile calculation at end to use the extracted FBIAS numeric value (float). SL

* Per issue #1761: modified the check on the perc_thresh_freq_bias, just has to be > 0 now. SL

* Per issue #1761: cleaned up code in set_perc(). SL

* Per #1761, updates to Simple_Node::set_perc() to handle variable frequency bias amounts.
Changes include:
- Reverting the formatting of this back to how it originally was in the develop branch. In general, just match the formatting of the existing file, so as the minimize the number of difference lines.
- Add logic to adjust the percentile to be found based on the requested FBIAS value. Multiplying or dividing the percentile by the FBIAS value depends on the inequality type and whether we're bias adjusting the forecast or observation data.
- Adjust the log messages slightly.

Please be aware that I'm not totally confident in these changes. They warrant much more testing. This logic is very, very confusing.

* Per #1761, call compute_percentile() when double-checking the percentile values.

* Per #1761, remove unused variable.

* Per #1761, add warning for percentiles > 100.

* Per #1761. In set_perc(), after testing cleaned up code. SL

* Per issue #1761: adding new config file for testing dynamic FBIAS values. SL

* Per issue #1761: added new unit test for dynamic FBIAS values when running grid_stat. SL

* Per issue #1761, modified FBIAS section to indicated that the user can use dynamic values that are not 1.0. SL

* Update met/docs/Users_Guide/config_options.rst

Co-authored-by: johnhg <[email protected]>

* Update met/docs/Users_Guide/config_options.rst

Co-authored-by: johnhg <[email protected]>

* Update met/docs/Users_Guide/config_options.rst

Co-authored-by: johnhg <[email protected]>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <[email protected]>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <[email protected]>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <[email protected]>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <[email protected]>

* Per issue #1761, set nc_pairs_flag = FALSE. SL

Co-authored-by: Seth Linden <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>

* Feature 1905 ens_ctrl (#1955)

Co-authored-by: j-opatz <[email protected]>

* Hotfix after merging changing for #1761. Updating the list of expected output files.

* Per #1905, committing a hotfix directly to the develop branch. Reverting the logic for computing the ensemble range back to what it was previously. The new version produced very slight differences in the 6-th or 7-th decimal place when compared to previous results. There's not good reason for these changes which were caused by the order of operations in casting from doubles to floats. Reverting back to the old logic prevents diffs for anyone else downstream and is the prudent choice.

* Feature 1957 ascii2nc_python (#1958)

* Feature 1949 cf netcdf documentaton (#1951)

* #1949 Added CF compliant NetCDF into data IO

* #1949 Added commas

* #1948 Some corrections for typo and added the links for CF attributes

* #1948 Added Performance with NetCDF input data

* #1949 Corrected tyoe and applied Juloie's suggestions

Co-authored-by: Howard Soh <[email protected]>

* Feature 1968 ens_ctrl (#1969)

* Feature 1809 gen prob (#1967)

* Feature 1970 v10.1.0-beta4 (#1973)

* Fix tiny typo in plot_data_plane usage statement.

* Hotfix for the develop branch to get met-10.1.0-beta4 compiling on WCOSS. The intel compiler does not allow adjacent >> characters when defining maps.

* Updating the beta4 release date from 11/16 to 11/17 since the beta4 release needs to be recreated.

* Update the MET PR template to list expected changes up front.

* Bugfix 1976 develop cdist (#1979)

* #1936 Excludes precip3hr, precip6hr, precip12hr, and precip10min from required variables for MESONET

* Per #1985, correcting typo found while creating V10.0.1 in the develop branch as well.

* Per #1985, VERY minor change to fix alignment of titles in Point-Stat... updating the develop branch.

* #1936 Added an unit test for newer MESONET file

* Feature 1989 sort (#1990)

* Feature 1991 VCNT (#1992)

* Feature 1993 grid_mask (#1994)

* #1844 Added vx_pointdata_python

* #1844 Added vx_pointdata_python to PYTHON_LIBS & make file for vx_pointdata_python

* #1844 Added vx_pointdata_python to SUBDIRS

* #1844 Initial release

* #1844 Added met_point_data.cc & met_point_data.h

* #1844 NcHeaderData is renamed to MetPointHeader and moved to met_point_dataq.h

* #1844 NcPointObsData is derived from MetPointObsData. Many methods are moved to the base class MetPointObsData

* #1844 Moved varianbles and methods to the base class MetPointData

* #1844 override the obs_data pointer to the derived class

* #1844 Added pyobject_as_bool & pyobject_as_string_array

* #1844 Cleanup include statements and addpointdata_python.h if python is enabled

* #18443 Support python embedding

* #1844 Initial release

* #1844 Make buf_size const

* Add GitHub Actions workflow to trigger METplus testing workflow (#2002)

* changed names of inputs to send to METplus to match changes to METplus repo

* #1965 Excludes the duplicated variable names from multiple input files

* #1965 Processed with the raw variable names and update them when the output is saved.

* #1965 Added unit test ioda2nc_same_input

* #1965 Processed with the raw variable names and update them when the output is saved.

* #1965 Added unit test ioda2nc_same_input

* #1965 initialize var_idx

* Update the development environment for seneca to add /usr/local/nco/bin and /usr/local/netcdf/bin to the path. Also define MET_TEST_RSCRIPT to point to a new enough version of RSCRIPT that has the ncdf4 package 1.17 or later.

* send email address of user who triggered event to METplus workflow as input

* Fixup the Rscript diffing logic to support running the nightly build on seneca. The problem here is that the ncdiff -x -v command line options that worked in version 4.7.0 NO LONGER work in 4.9.2. Added a check to skip over the time_bounds variable when processing the ncdiff output.

* No real changes here. Just formatting

* Feature 1974 message_type_group_map (#1999)

Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>

* Feature 1996 uninitialized variables (#2004)

Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>

* Feature 1695 ensemble single file (gen_ens_prod) (#2001)

Co-authored-by: johnhg <[email protected]>

* Feature 1965 NB faile with time summary by ioda2nc (#2008)

Co-authored-by: Howard Soh <[email protected]>

* Feature 1810 shapes (#2005)

* #1844 Added log message for use_var_id

* #1844 Get use_var_id for python embedding

* #1844 Initial release

* #1844 Added met_point_obs.py and read_met_point_obs.py

* #1844 Added 4 unit test for python embedding of MET point data

* More changes to test_util.R to account for differences between 4.7.0 and 4.9.2 of ncdiff. The earlier version reported 0 diffs for the time_bounds, lat, lon, latitude, and longitude variables while the newer version reports their raw values. Simply ignore these variables for now. This isn't a great solution but when we reimplement this testing logic in python, we can address this issue then.

* #1844 Added python embedding for point observation data

* Feature 1926 gridstat openmp (#1977)

Co-authored-by: johnhg <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: Julie Prestopnik <[email protected]>

* feature 1695 ensemble single file (ensemble_stat) (#2007)

Co-authored-by: johnhg <[email protected]>

* Committing directly to the develop branch. Removing many, many instances of MET_BUILD_BASE and a couple instances of MET_BASE from the examples listed in Appendix A. The inconsistent use of these variables will only cause confusion. Removing them will help avoid that confusion. Big picture... MET_BASE defines the installed 'share/met' directory. It can be used to reference the location of map or polyline files. MET_BUILD_BASE is only used in the context of the test scripts. There, it's defined as the top-level source code directory in which the code was compiled. Its used to reference the location of sample data files or Rscript included in the tarball. I left a couple references to these variables in Appendix A where thier use is not confusing. But I removed all instances which are used to the define the location of the 'bin' directory. Instead, let's just assume the MET binaries are already in their path... or the user knows where to find them.

* feature 2011 v10.1.0-beta5 (#2014)

* feature 1695 fix issues with ensemble changes (#2012)

Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>

* Hotfix for #1695 committed directly to the develop branch. The new Ensemble-Stat config files added for this issue don't define a random number generator seed. This results in different output for each run and prevents the regression test from producing repeatable results. Defining the seed here to fix that.

* Adding George to email list for the nightly build.

* Fix the links for the met-10.1.0-beta5 release notes.

* #1844 Make met_point_obs as abstract class

* #1844 correctedb for loop end condition on processing obs bdata

* Feature 1546 unit_tests (#2021)

* #2020 Added SonarQube related varibales

* #2020 Initial release

* #2015 Avoid the repeasted debug message if derived varibales are disabled

* #1996 Initialize right and left

* #1966 Call clear() instead of reset memory for Header variable

* #1966 Make sure the levels from variable  does not exceed the maxLevel

* #1966 Removed unreachable codes

* #1966 Do not write into NetcDF if empty data

* #2015 Corrected "retained or derived" count

* Feature 1546 CI testing (#2029)

Co-authored-by: John Halley Gotway <[email protected]>

* fixed broken workflow by setting environment variable expected for docker build script

* add missing docker tag from push command

* added correct docker tag value

* fixed incorrect truth data version for updating -ref reference data

* Updating develop with changes to the unit tests names. Renaming unit_test.yml to a more generic testing.yml name since it compiles AND/OR runs unit tests. Also make the job names more concise so its easier to see what's running in the action summary window on GitHub.

* fixed directory to copy truth data into -- copy command was copying the content of the directory, not including the directory itself

* Per #1907, added warning about switch from Ensemble-Stat to Gen-Ens-Prod (#2032)

Co-authored-by: Julie Prestopnik <[email protected]>

* 2028 Check null for header data

* Removed un-reachable code

* #2028 Check if the pointer (d) is null

* #2015 Changed warning to debug message

* #2028 Passing two dimensionl cur and dim array

* #2028 Set obs_data

* Feature 2003 briercl (#2034)

Co-authored-by: jprestop <[email protected]>
Co-authored-by: Julie Prestopnik <[email protected]>
Co-authored-by: Seth Linden <[email protected]>
Co-authored-by: Seth Linden <[email protected]>
Co-authored-by: j-opatz <[email protected]>
Co-authored-by: hsoh-u <[email protected]>
Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: George McCabe <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: MET Tools Test Account <[email protected]>
Co-authored-by: mo-mglover <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: Howard Soh <[email protected]>
@hsoh-u hsoh-u reopened this Feb 3, 2022
@hsoh-u hsoh-u changed the title Address findings from the Cppcheck code analysis tool Address findings from the SonarQube/Cppcheck code analysis tool Feb 3, 2022
hsoh-u pushed a commit that referenced this issue Feb 10, 2022
#1996 Initialize i_point
b4ec7b8
JohnHalleyGotway added a commit that referenced this issue Feb 12, 2022
@JohnHalleyGotway @jprestop
@sethlinden @j-opatz @hsoh-u @georgemccabe @mo-mglover @davidalbo @lisagoodrich
Update develop-ref after #2047 (#2051)
ee1fb0d 
* Per #1906, modify code to pass entire path to make_temp_file_name instead of only the filename so that the function can tell whether or not the file exists. (#1952)

Co-authored-by: Julie Prestopnik <[email protected]>

* Feature 1761 percent thresh (#1956)

* Per issue #1761 in set_perc() adding code to get FBIAS numeric value, like 1.0 or 0.9, etc. SL

* Per issue #1761: in set_perc(), modified actual percentile calculation at end to use the extracted FBIAS numeric value (float). SL

* Per issue #1761: modified the check on the perc_thresh_freq_bias, just has to be > 0 now. SL

* Per issue #1761: cleaned up code in set_perc(). SL

* Per #1761, updates to Simple_Node::set_perc() to handle variable frequency bias amounts.
Changes include:
- Reverting the formatting of this back to how it originally was in the develop branch. In general, just match the formatting of the existing file, so as the minimize the number of difference lines.
- Add logic to adjust the percentile to be found based on the requested FBIAS value. Multiplying or dividing the percentile by the FBIAS value depends on the inequality type and whether we're bias adjusting the forecast or observation data.
- Adjust the log messages slightly.

Please be aware that I'm not totally confident in these changes. They warrant much more testing. This logic is very, very confusing.

* Per #1761, call compute_percentile() when double-checking the percentile values.

* Per #1761, remove unused variable.

* Per #1761, add warning for percentiles > 100.

* Per #1761. In set_perc(), after testing cleaned up code. SL

* Per issue #1761: adding new config file for testing dynamic FBIAS values. SL

* Per issue #1761: added new unit test for dynamic FBIAS values when running grid_stat. SL

* Per issue #1761, modified FBIAS section to indicated that the user can use dynamic values that are not 1.0. SL

* Update met/docs/Users_Guide/config_options.rst

Co-authored-by: johnhg <[email protected]>

* Update met/docs/Users_Guide/config_options.rst

Co-authored-by: johnhg <[email protected]>

* Update met/docs/Users_Guide/config_options.rst

Co-authored-by: johnhg <[email protected]>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <[email protected]>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <[email protected]>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <[email protected]>

* Update test/config/GridStatConfig_fbias_perc_thresh

Co-authored-by: johnhg <[email protected]>

* Per issue #1761, set nc_pairs_flag = FALSE. SL

Co-authored-by: Seth Linden <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>

* Feature 1905 ens_ctrl (#1955)

Co-authored-by: j-opatz <[email protected]>

* Hotfix after merging changing for #1761. Updating the list of expected output files.

* Per #1905, committing a hotfix directly to the develop branch. Reverting the logic for computing the ensemble range back to what it was previously. The new version produced very slight differences in the 6-th or 7-th decimal place when compared to previous results. There's not good reason for these changes which were caused by the order of operations in casting from doubles to floats. Reverting back to the old logic prevents diffs for anyone else downstream and is the prudent choice.

* Feature 1957 ascii2nc_python (#1958)

* Feature 1949 cf netcdf documentaton (#1951)

* #1949 Added CF compliant NetCDF into data IO

* #1949 Added commas

* #1948 Some corrections for typo and added the links for CF attributes

* #1948 Added Performance with NetCDF input data

* #1949 Corrected tyoe and applied Juloie's suggestions

Co-authored-by: Howard Soh <[email protected]>

* Feature 1968 ens_ctrl (#1969)

* Feature 1809 gen prob (#1967)

* Feature 1970 v10.1.0-beta4 (#1973)

* Fix tiny typo in plot_data_plane usage statement.

* Hotfix for the develop branch to get met-10.1.0-beta4 compiling on WCOSS. The intel compiler does not allow adjacent >> characters when defining maps.

* Updating the beta4 release date from 11/16 to 11/17 since the beta4 release needs to be recreated.

* Update the MET PR template to list expected changes up front.

* Bugfix 1976 develop cdist (#1979)

* #1936 Excludes precip3hr, precip6hr, precip12hr, and precip10min from required variables for MESONET

* Per #1985, correcting typo found while creating V10.0.1 in the develop branch as well.

* Per #1985, VERY minor change to fix alignment of titles in Point-Stat... updating the develop branch.

* #1936 Added an unit test for newer MESONET file

* Feature 1989 sort (#1990)

* Feature 1991 VCNT (#1992)

* Feature 1993 grid_mask (#1994)

* #1844 Added vx_pointdata_python

* #1844 Added vx_pointdata_python to PYTHON_LIBS & make file for vx_pointdata_python

* #1844 Added vx_pointdata_python to SUBDIRS

* #1844 Initial release

* #1844 Added met_point_data.cc & met_point_data.h

* #1844 NcHeaderData is renamed to MetPointHeader and moved to met_point_dataq.h

* #1844 NcPointObsData is derived from MetPointObsData. Many methods are moved to the base class MetPointObsData

* #1844 Moved varianbles and methods to the base class MetPointData

* #1844 override the obs_data pointer to the derived class

* #1844 Added pyobject_as_bool & pyobject_as_string_array

* #1844 Cleanup include statements and addpointdata_python.h if python is enabled

* #18443 Support python embedding

* #1844 Initial release

* #1844 Make buf_size const

* Add GitHub Actions workflow to trigger METplus testing workflow (#2002)

* changed names of inputs to send to METplus to match changes to METplus repo

* #1965 Excludes the duplicated variable names from multiple input files

* #1965 Processed with the raw variable names and update them when the output is saved.

* #1965 Added unit test ioda2nc_same_input

* #1965 Processed with the raw variable names and update them when the output is saved.

* #1965 Added unit test ioda2nc_same_input

* #1965 initialize var_idx

* Update the development environment for seneca to add /usr/local/nco/bin and /usr/local/netcdf/bin to the path. Also define MET_TEST_RSCRIPT to point to a new enough version of RSCRIPT that has the ncdf4 package 1.17 or later.

* send email address of user who triggered event to METplus workflow as input

* Fixup the Rscript diffing logic to support running the nightly build on seneca. The problem here is that the ncdiff -x -v command line options that worked in version 4.7.0 NO LONGER work in 4.9.2. Added a check to skip over the time_bounds variable when processing the ncdiff output.

* No real changes here. Just formatting

* Feature 1974 message_type_group_map (#1999)

Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>

* Feature 1996 uninitialized variables (#2004)

Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>

* Feature 1695 ensemble single file (gen_ens_prod) (#2001)

Co-authored-by: johnhg <[email protected]>

* Feature 1965 NB faile with time summary by ioda2nc (#2008)

Co-authored-by: Howard Soh <[email protected]>

* Feature 1810 shapes (#2005)

* #1844 Added log message for use_var_id

* #1844 Get use_var_id for python embedding

* #1844 Initial release

* #1844 Added met_point_obs.py and read_met_point_obs.py

* #1844 Added 4 unit test for python embedding of MET point data

* More changes to test_util.R to account for differences between 4.7.0 and 4.9.2 of ncdiff. The earlier version reported 0 diffs for the time_bounds, lat, lon, latitude, and longitude variables while the newer version reports their raw values. Simply ignore these variables for now. This isn't a great solution but when we reimplement this testing logic in python, we can address this issue then.

* #1844 Added python embedding for point observation data

* Feature 1926 gridstat openmp (#1977)

Co-authored-by: johnhg <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: Julie Prestopnik <[email protected]>

* feature 1695 ensemble single file (ensemble_stat) (#2007)

Co-authored-by: johnhg <[email protected]>

* Committing directly to the develop branch. Removing many, many instances of MET_BUILD_BASE and a couple instances of MET_BASE from the examples listed in Appendix A. The inconsistent use of these variables will only cause confusion. Removing them will help avoid that confusion. Big picture... MET_BASE defines the installed 'share/met' directory. It can be used to reference the location of map or polyline files. MET_BUILD_BASE is only used in the context of the test scripts. There, it's defined as the top-level source code directory in which the code was compiled. Its used to reference the location of sample data files or Rscript included in the tarball. I left a couple references to these variables in Appendix A where thier use is not confusing. But I removed all instances which are used to the define the location of the 'bin' directory. Instead, let's just assume the MET binaries are already in their path... or the user knows where to find them.

* feature 2011 v10.1.0-beta5 (#2014)

* feature 1695 fix issues with ensemble changes (#2012)

Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>

* Hotfix for #1695 committed directly to the develop branch. The new Ensemble-Stat config files added for this issue don't define a random number generator seed. This results in different output for each run and prevents the regression test from producing repeatable results. Defining the seed here to fix that.

* Adding George to email list for the nightly build.

* Fix the links for the met-10.1.0-beta5 release notes.

* #1844 Make met_point_obs as abstract class

* #1844 correctedb for loop end condition on processing obs bdata

* Feature 1546 unit_tests (#2021)

* #2020 Added SonarQube related varibales

* #2020 Initial release

* #2015 Avoid the repeasted debug message if derived varibales are disabled

* #1996 Initialize right and left

* #1966 Call clear() instead of reset memory for Header variable

* #1966 Make sure the levels from variable  does not exceed the maxLevel

* #1966 Removed unreachable codes

* #1966 Do not write into NetcDF if empty data

* #2015 Corrected "retained or derived" count

* Feature 1546 CI testing (#2029)

Co-authored-by: John Halley Gotway <[email protected]>

* fixed broken workflow by setting environment variable expected for docker build script

* add missing docker tag from push command

* added correct docker tag value

* fixed incorrect truth data version for updating -ref reference data

* Updating develop with changes to the unit tests names. Renaming unit_test.yml to a more generic testing.yml name since it compiles AND/OR runs unit tests. Also make the job names more concise so its easier to see what's running in the action summary window on GitHub.

* fixed directory to copy truth data into -- copy command was copying the content of the directory, not including the directory itself

* Per #1907, added warning about switch from Ensemble-Stat to Gen-Ens-Prod (#2032)

Co-authored-by: Julie Prestopnik <[email protected]>

* 2028 Check null for header data

* Removed un-reachable code

* #2028 Check if the pointer (d) is null

* #2015 Changed warning to debug message

* #2028 Passing two dimensionl cur and dim array

* #2028 Set obs_data

* Feature 2003 briercl (#2034)

* do not run testing workflow if changes are isolated to the met/docs directory

* Per #2013, changed source and README.  ci-run-unit (#2039)

* Feature 1055 read rot latlon (#2041)

* CI: output summary of differences in GHA log to easily see results without having to download the log artifact

* #2027 Added a debug message

* #2027 ci-run-unit Changed wind thres

* #2027 ci-run-unit Increased the precision to debug message

* print end of script after error summary, ci-run-unit

* #2027 Increased the buffer and cheking the status of sprintf

* Feature 1998 standard sections (#2038)

* fixing section headers to be consistent with METplus #1998

* fixing section headers to be consistent with METplus #1998

* fixing section headers to be consistent with METplus #1998 missed one

* fixing section headers to be consistent with METplus #1998 try again

* fixing section headers to be consistent with METplus #1998 I had it right the first time

* fixing section headers to be consistent with METplus #1998

* fixing section headers to be consistent with METplus #1998 fixing mistake

* fixing section headers to be consistent with METplus #1998

* fixing section headers to be consistent with METplus #1998

* fixing section headers to be consistent with METplus #1998

* fixing section headers to be consistent with METplus #1998

* fixing section header underscore to dash #1998

* updating TOC vs ref 1998

* updating TOC vs ref 1998 completed

* trying to fix link #1998

* trying to fix link adding reference back in #1998

* updating TOC again underscore vs dash #1998

* updating TOC again underscore vs dash #1998

* updating TOC vs ref 1998 try

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998 take 2

* standardizing TOC sections #1998 take 3

* re-standardizing TOC sections #1998

* re-standardizing TOC sections #1998

* re-standardizing TOC sections #1998

* re-standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998

* updating questions into the TOC.  test #1998

* updating questions into the TOC. #1998

* standardizing TOC sections #1998

* standardizing TOC sections #1998 fixing typo

* standardizing TOC sections #1998 fixing typo

* standardizing TOC sections #1998 fixing typo

* standardizing TOC sections #1998 fixing typo

* standardizing TOC sections #1998 fixing typo

* standardizing TOC sections #1998 fixing typo

* cleaning up questions. removing section title from questions.

* adding a period #1989.

* adding the line breaks back in to match other formatting within MET #1989.

* Changed some "^^^" to "----"

* Changed "###" to "***"

Co-authored-by: jprestop <[email protected]>

* Update met_stats.cc

#2047 Removed the debug message

* Update met_stats.cc

Removing variable that was set but never used because SonarQube might complain about that, like Fortify does.

* Feature 2040 parse timing (#2048)

Co-authored-by: Julie Prestopnik <[email protected]>

* CI: Add logic to auto update input data (#2046)

* Bugfix 2045 develop hira (#2049)

Co-authored-by: jprestop <[email protected]>
Co-authored-by: Julie Prestopnik <[email protected]>
Co-authored-by: Seth Linden <[email protected]>
Co-authored-by: Seth Linden <[email protected]>
Co-authored-by: j-opatz <[email protected]>
Co-authored-by: hsoh-u <[email protected]>
Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: George McCabe <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: MET Tools Test Account <[email protected]>
Co-authored-by: mo-mglover <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: davidalbo <[email protected]>
Co-authored-by: lisagoodrich <[email protected]>
@hsoh-u hsoh-u linked a pull request Feb 22, 2022 that will close this issue
Feature 1996 sonarqube findings #2065
Merged
15 tasks
hsoh-u pushed a commit that referenced this issue Feb 25, 2022
#1996 simplify the retrun statement (no effect with tf_left at the se…
eccbb38 
…cond return
hsoh-u pushed a commit that referenced this issue Feb 25, 2022
#1996 Add null terminator only if the pointer is not NULL
37aef73
hsoh-u pushed a commit that referenced this issue Feb 25, 2022
#1996 Reduced duplicated for loops
543370e
hsoh-u pushed a commit that referenced this issue Feb 25, 2022
#1996 Removed IsSet which is defined at the base class
4471c4a
hsoh-u pushed a commit that referenced this issue Feb 25, 2022
#1996 Initialize the variable
c5a80d5
hsoh-u pushed a commit that referenced this issue Feb 25, 2022
#1996 ci-run-test Initialize the variable, nxy
40569ff
@hsoh-u hsoh-u linked a pull request Feb 25, 2022 that will close this issue
Feature 1996 sonarqube findings #2073
Merged
15 tasks
hsoh-u pushed a commit that referenced this issue Mar 2, 2022
#1996 ci-run-test initialize tc
2084add
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsoh-u hsoh-u

Labels
component: code cleanup Code cleanup and maintenance issue priority: medium Medium Priority reporting: DTC AF METplus Air Force METplus Project requestor: METplus Team METplus Development Team type: bug Fix something that is not working
Projects
None yet
Milestone
MET 10.1.0
3 participants
@hsoh-u @JohnHalleyGotway @TaraJensen