Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 2040 patch #2053

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Feature 2040 patch #2053

merged 1 commit into from
Feb 15, 2022

Conversation

JohnHalleyGotway
Copy link
Collaborator

Expected Differences

@hsoh-u thanks for flagging the stale code in met_file.cc that required cleanup. This PR removes the code that is no longer needed.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    None.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Please confirm that all automated GitHub action tests pass before approving.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
    None needed.

  • Do these changes include sufficient testing updates? [Yes]
    None needed.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Wed 2/16/2022].

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…emoving old log messages and variables related to printing out the initialization time. Since InitTime has moved from MetNcFile to NcVarInfo, it is no longer included in the dump function.
@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.1.0 milestone Feb 15, 2022
@JohnHalleyGotway JohnHalleyGotway changed the title Feature 2048 patch Feature 2040 patch Feb 15, 2022
Copy link
Collaborator

@hsoh-u hsoh-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dump message was cleaned.

@JohnHalleyGotway JohnHalleyGotway removed the request for review from jprestop February 15, 2022 19:04
@JohnHalleyGotway JohnHalleyGotway merged commit fd95301 into develop Feb 15, 2022
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2048_patch branch February 15, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants