-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 1918 std climo #2061
Feature 1918 std climo #2061
Conversation
…d update the documentation.
…ze_flag is set to something other than NONE.
…ore similar to the convert and censor_thresh/censor_val options.
…e names or attributes. Normalizing the input data is similar to converting it or censoring it and that information is not written to the NetCDF output files. The nc_var_str config option can be used to customize the output variable names as the user sees fit.
… in the vx_util library so that that functionality is available to other MET tools. ci-run-unit
@j-opatz do you have updated requirements to share on this PR? Based on our discussion from this morning, should I remove the FCST_ANOM and FCST_STD_ANOM options from Gen-Ens-Prod? Honestly, that'd be more efficient anyway. Using them requires the tool to read the same data twice... once to compute the mean/spread and once to use that computed mean/spread to normalize each member. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation for the changes looks good, and updates to code still solve the problem in the original issue, with a slight change in approach (now includes series-analysis). Automated testing shows no issues, and code updates appear sound, both reading and during usage.
Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: johnhg <[email protected]> Co-authored-by: Seth Linden <[email protected]> Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: j-opatz <[email protected]> Co-authored-by: Howard Soh <[email protected]> Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: Howard Soh <[email protected]> Co-authored-by: Seth Linden <[email protected]> Co-authored-by: hsoh-u <[email protected]> Co-authored-by: George McCabe <[email protected]> Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: MET Tools Test Account <[email protected]> Co-authored-by: mo-mglover <[email protected]> Co-authored-by: davidalbo <[email protected]> Co-authored-by: lisagoodrich <[email protected]>
Expected Differences
If yes, please describe:
Adds "normalize" option to the Gen-Ens-Prod config file.
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Tested manually and also added a new call in unit_gen_ens_prod.xml to exercise all available options for the normalize config option.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review the code changes.
Review the documentation updates in the gen_ens_prod chapter.
Inspect the new unit test gen_ens_prod NetCDF output file to make sure the outputs look good.
Consider this design choice:
Test this feature branch manually using your own test data in:
seneca:/d1/projects/MET/MET_pull_requests/met-10.1.0/met-10.1.0-beta6/feature_1918/MET-feature_1918_std_climo_into_develop/met/bin
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
New output file named gen_ens_prod/gen_ens_prod_NORMALIZE.nc is created. That is the only difference flagged in the GitHub actions for this PR:
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes