Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the normalize option to the Gen-Ens-Prod wrapper. #1445

Closed
8 of 20 tasks
JohnHalleyGotway opened this issue Feb 20, 2022 · 0 comments · Fixed by #1478
Closed
8 of 20 tasks

Add support for the normalize option to the Gen-Ens-Prod wrapper. #1445

JohnHalleyGotway opened this issue Feb 20, 2022 · 0 comments · Fixed by #1478
Assignees
Labels
METplus: Configuration priority: high High Priority requestor: NOAA/CPC NOAA Climate Prediction Center requestor: UK Met Office United Kingdom Met Office required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Feb 20, 2022

Describe the Enhancement

Sorry about this last minute addition. The PR's dtcenter/MET#2061 and dtcenter/MET#2075 for dtcenter/MET#1918 issue adds a new configuration option to the Gen-Ens-Prod tool.

Similar to the convert and censor_thresh/censor_val options, it can be set separately for each ens.field array entry. It is a flag that can be set to one of 5 options. They can be seen by searching for "normalize" in this section of the feature branch documentation or in the develop branch after the PR has been merged.

Note that these are literals in the gen_ens_prod configuration file (like TRUE and FALSE). They are NOT strings. Also note that while normalize is currently only supported in gen_ens_prod, we will likely add support for it to any of the other MET tools that use climatology data via dtcenter/MET#2062.

Time Estimate

1/2 day?

Sub-Issues

Consider breaking the enhancement down into sub-issues.
No sub-issues needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2799991

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: @georgemccabe
  • Select scientist(s) or no scientist required: none needed but @j-opatz can answer questions about intended usage

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing priority: high High Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: UK Met Office United Kingdom Met Office required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone METplus: Configuration labels Feb 20, 2022
@JohnHalleyGotway JohnHalleyGotway added this to the METplus-4.1.0 milestone Feb 20, 2022
@JohnHalleyGotway JohnHalleyGotway added requestor: NOAA/CPC NOAA Climate Prediction Center and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Feb 20, 2022
georgemccabe added a commit that referenced this issue Mar 4, 2022
…n uncommenting -- indentation can be interpreted as a multiple line value in config files
georgemccabe added a commit that referenced this issue Mar 4, 2022
@georgemccabe georgemccabe linked a pull request Mar 4, 2022 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
METplus: Configuration priority: high High Priority requestor: NOAA/CPC NOAA Climate Prediction Center requestor: UK Met Office United Kingdom Met Office required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants