Feature 1824 pb2nc mlcape

[hsoh-u]

Expected Differences

• MLCAPE is computed if "D_MLCAPE" is added into obs_bufr_var (user PB2NCConfig) by using ivirt 1 & itype2

• The minimum number of records to calculate PBL is not confirmed yet. So temporarily set it 1

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

More data is added into point observation NetCDF.

• case 1: all variables - MLCAPE will be added without changes at the config file.
• case 2: specify MLCAPE output from the config file ("D_MLCAPE" at obs_bufr_var)

Pull Request Testing

• Describe testing already performed for these changes:
  

Added "D_MLCAPE" to obs_bufr_var at /d1/personal/d1/personal/hsoh/git/config_to_test/PB2NCConfig_cal_cape

obs_bufr_var = [ "QOB", "TOB", "ZOB", "D_CAPE", "D_MLCAPE" ];

/d1/personal/hsoh/git/features/feature_1824_pb2nc_MLCAPE/MET/met/bin/pb2nc /d1/personal/hsoh/data/CAPE_data/prepda.2018091100 ./prepda.2018091100.add_mlcape.nc /d1/personal/d1/personal/hsoh/git/config_to_test/PB2NCConfig_cal_cape -v 2 -nmsg 10%

Rscript  /d1/personal/hsoh/git/features/feature_1824_pb2nc_MLCAPE/MET/met/scripts/Rscripts/pntnc2ascii.R ./prepda.2018091100.add_mlcape.nc | grep MLCAPE

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

• Do these changes include sufficient testing updates? [No]

• Will this PR result in changes to the test suite? [Yes]
  
  If yes, describe the new output and/or changes to the existing output:
  

The PBL and CAPE unit test is moved to unit_pb2nc_indy.xml. The existing unit test "pb2nc_compute_pbl_cape" includes MLCAPE
Two changes were made:

• Added MLCAPE
  • 147 more MLCAPE data at nam.20210311.t00z.prepbufr.tm00.pbl.nc
  • One more variable (MLCAPE) & 5 data at the existing output, ndas.20120409.t12z.prepbufr.tm00.var_all.nc
• PBL is not computed if the merged PTQ & UV record is just 1 which was a difference between kiowa and seneca
  • no change at seneca
  • 4 less PBL data at nam.20210311.t00z.prepbufr.tm00.pbl.nc at kiowa & Docker
• summary at nam.20210311.t00z.prepbufr.tm00.pbl.nc
  • 147 more data (MLCAPE) at seneca
  • 143 (=147 - 4, MLCAPE and PBL ) more data at kiowa

hsoh@kiowa:$  Rscript /d1/personal/hsoh/git/pull_request/MET_feature_1824_pb2nc_MLCAPE/met/scripts/Rscripts/pntnc2ascii.R /d1/projects/MET/MET_regression/develop/NB20220218/MET-develop/test_output//pb2nc_indy/nam.20210311.t00z.prepbufr.tm00.pbl.nc | grep PBL | wc -l
     102
hsoh@kiowa:$  Rscript /d1/personal/hsoh/git/pull_request/MET_feature_1824_pb2nc_MLCAPE/met/scripts/Rscripts/pntnc2ascii.R unit_test_output/pb2nc_indy/nam.20210311.t00z.prepbufr.tm00.pbl.nc | grep PBL | wc -l
     98
hsoh@seneca:$ Rscript met/scripts/Rscripts/pntnc2ascii.R  /d1/personal/hsoh/MET/test_output/feature_1824_pb2nc_MLCAPE/pb2nc_indy/nam.20210311.t00z.prepbufr.tm00.pbl.nc | grep PBL  | wc -l
     98
hsoh@seneca:$  Rscript met/scripts/Rscripts/pntnc2ascii.R  /d1/personal/hsoh/MET/test_output/feature_1824_pb2nc_MLCAPE/pb2nc_indy/nam.20210311.t00z.prepbufr.tm00.pbl.nc | grep MLCAPE  | wc -l
    147

• Please complete this pull request review by [Fill in date].
  

Pull Request Checklist

See the METplus Workflow for details.

• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Linked issues with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[TaraJensen]

Looks good to me.