Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature set job controls #2066

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Feature set job controls #2066

merged 2 commits into from
Feb 23, 2022

Conversation

jprestop
Copy link
Collaborator

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Verified that the keyword ci-skip-all worked as expected here:
    https://github.com/dtcenter/MET/actions/runs/1884416209

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review the file that was modified and review the Actions link above, if desired.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]. There is a pending issue for a MET Contributor's Guide at which time this information will be added.

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Whenever you can (before or after beta release)].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone). ** No issue **
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number. N/A
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the MET 10.1.0 milestone Feb 23, 2022
@JohnHalleyGotway
Copy link
Collaborator

I approve of these changes. I reviewed the modified file and the changes make sense. I see from the GitHub actions history that "ci-skip-all" behaved as expected.

@jprestop jprestop merged commit 36bdf26 into develop Feb 23, 2022
@jprestop jprestop deleted the feature_set_job_controls branch February 23, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants