-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.34.0 (master) #4036
Merged
Merged
Release v0.34.0 (master) #4036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 0.33.0 to Develop
Merge v0.33.0 tag back to develop
* Make cli tests use build files * Update PENDING.md Add PR number.
Temporarily remove snap from installation instructions
Signed-off-by: Karoly Albert Szabo <[email protected]>
`gaiacli keys add a123 --multisig a1,a2,a3 --multisig-threshold 2` `gaiacli keys add temp --recover` with incorrect mnemonic
* Make IsAllGTE() more consistent Co-Authored-By: alessio <[email protected]>
* Add indent to JSON of `gaiacli key list` * Add `-o json --indent` to `keys [add|show|list]` * Add change log. * Move entry from CHANGELOG.md to PENDING.md * Update PENDING.md Add indent to JSON of `gaiacli key [add|show|list]` Co-Authored-By: yangyanqing <[email protected]>
… of file conflicts Closes: #2380
jackzampolin
reviewed
Apr 3, 2019
@@ -35,7 +36,7 @@ set_macos_env: &macos_env | |||
docs_update: &docs_deploy | |||
working_directory: ~/repo | |||
docker: | |||
- image: tendermint/docs_deployment | |||
- image: tendermintdev/jq_curl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
int
jackzampolin
approved these changes
Apr 9, 2019
fedekunze
approved these changes
Apr 9, 2019
alessio
approved these changes
Apr 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
rigelrozanski
approved these changes
Apr 9, 2019
5 tasks
Update Tendermint to the 0.31.4 release
zmanian
approved these changes
Apr 12, 2019
Why is this still on hold? |
Needs an approval and merge from @jaekwon |
zramsay
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v0.34.0 into
master
. PR intodevelop
: #4086.TODO (prior to merge):
master
), tag, and release Hotfix release/v0.33.2 #4039Nice-to-Have:
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]
rereviewed
Files changed
in the github PR explorerFor Admin Use: