Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation Performance Improvements #3818

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Mar 6, 2019

Disabling the distribution CanWithdrawInvariant invariant speeds up simulation noticeably.

/cc @jaekwon


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #3818 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3818      +/-   ##
===========================================
- Coverage    60.86%   60.84%   -0.02%     
===========================================
  Files          192      192              
  Lines        14288    14288              
===========================================
- Hits          8696     8694       -2     
- Misses        5025     5027       +2     
  Partials       567      567

@alexanderbez alexanderbez changed the base branch from develop to jack/release-0.33.0 March 6, 2019 21:45
@alexanderbez alexanderbez marked this pull request as ready for review March 6, 2019 21:48
@alexanderbez alexanderbez merged commit d7fc4e9 into jack/release-0.33.0 Mar 7, 2019
@alexanderbez alexanderbez deleted the bez/sim-perf-improvements branch March 7, 2019 02:03
@jackzampolin
Copy link
Member

This is a great one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants