Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Modify steak to stake. #3833 #3884

Merged
merged 1 commit into from
Mar 14, 2019
Merged

R4R: Modify steak to stake. #3833 #3884

merged 1 commit into from
Mar 14, 2019

Conversation

yangyanqing
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #3884 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3884      +/-   ##
===========================================
+ Coverage    60.94%   60.95%   +0.01%     
===========================================
  Files          192      192              
  Lines        14360    14360              
===========================================
+ Hits          8751     8753       +2     
+ Misses        5035     5033       -2     
  Partials       574      574

1 similar comment
@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #3884 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3884      +/-   ##
===========================================
+ Coverage    60.94%   60.95%   +0.01%     
===========================================
  Files          192      192              
  Lines        14360    14360              
===========================================
+ Hits          8751     8753       +2     
+ Misses        5035     5033       -2     
  Partials       574      574

@yangyanqing yangyanqing changed the title Modify steak to stake. #3833 R4R: Modify steak to stake. #3833 Mar 14, 2019
Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rigelrozanski rigelrozanski merged commit 7e53da8 into cosmos:develop Mar 14, 2019
@yangyanqing yangyanqing deleted the frank/issue-3833-1 branch March 15, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants