-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix release/v0.33.2 #4039
Merged
Merged
Hotfix release/v0.33.2 #4039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change points to a specific release branch of v0.31.0-dev0 which includes critical security fixes.
alexanderbez
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
April 3, 2019 20:04
jackzampolin
approved these changes
Apr 3, 2019
liamsi
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
#### Tendermint | ||
|
||
* Upgrade Tendermint to `v0.31.0-dev0-fix0` which includes critical security fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to mention what fixes in the changelog?
Codecov Report
@@ Coverage Diff @@
## master #4039 +/- ##
==========================================
- Coverage 60.85% 60.84% -0.02%
==========================================
Files 192 192
Lines 14289 14289
==========================================
- Hits 8696 8694 -2
- Misses 5026 5028 +2
Partials 567 567 |
ebuchman
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Tendermint to
v0.31.0-dev0-fix0
as it fixes critical security vulnerabilities. This update technically includes a minor API breaking change inGenPrivKeySecp256k1
./cc @ebuchman @zmanian
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]
rereviewed
Files changed
in the github PR explorerFor Admin Use: